1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 75BFC431FBD
\r
6 for <notmuch@notmuchmail.org>; Sun, 19 May 2013 07:33:35 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id erplEgQdO326 for <notmuch@notmuchmail.org>;
\r
16 Sun, 19 May 2013 07:33:30 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 9247B431FBC
\r
19 for <notmuch@notmuchmail.org>; Sun, 19 May 2013 07:33:30 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 14BF31002C3;
\r
22 Sun, 19 May 2013 17:33:25 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] emacs: Compute build dependencies to fix byte compile
\r
27 In-Reply-To: <1368821611-24110-1-git-send-email-amdragon@mit.edu>
\r
28 References: <1368821611-24110-1-git-send-email-amdragon@mit.edu>
\r
29 User-Agent: Notmuch/0.15.2+99~g7e455bc (http://notmuchmail.org) Emacs/24.3.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Sun, 19 May 2013 17:33:24 +0300
\r
35 Message-ID: <m2a9nrghu3.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Sun, 19 May 2013 14:33:35 -0000
\r
52 On Fri, May 17 2013, Austin Clements <amdragon@MIT.EDU> wrote:
\r
54 > Previously, we simply byte compiled each Elisp source file
\r
55 > independently. This is actually the wrong thing to do and can lead to
\r
56 > issues with macros and performance issues with substitutions because
\r
57 > 1) when the byte compiler encounters a (require 'x) form, it will load
\r
58 > x.elc in preference to x.el, even if x.el is newer, and as a result
\r
59 > may load old macro and substitution definitions and 2) if we update a
\r
60 > macro or substitution definition in one file, we currently won't
\r
61 > re-compile other files that depend on the file containing the
\r
64 > This patch addresses these problems by computing make dependency rules
\r
65 > from the (require 'x) forms in the Elisp source files, which we inject
\r
66 > into make's dependency database.
\r
68 > emacs/Makefile.local | 12 +++++++++
\r
69 > emacs/make-deps.el | 66 ++++++++++++++++++++++++++++++++++++++++++++++++++
\r
70 > 2 files changed, 78 insertions(+)
\r
71 > create mode 100644 emacs/make-deps.el
\r
73 > diff --git a/emacs/Makefile.local b/emacs/Makefile.local
\r
74 > index fb82247..456700a 100644
\r
75 > --- a/emacs/Makefile.local
\r
76 > +++ b/emacs/Makefile.local
\r
77 > @@ -22,6 +22,18 @@ emacs_images := \
\r
79 > emacs_bytecode = $(emacs_sources:.el=.elc)
\r
81 > +# Because of defmacro's and defsubst's, we have to account for load
\r
82 > +# dependencies between Elisp files when byte compiling. Otherwise,
\r
83 > +# the byte compiler may load an old .elc file when processing a
\r
84 > +# "require" or we may fail to rebuild a .elc that depended on a macro
\r
85 > +# from an updated file.
\r
86 > +$(dir)/.eldeps: $(dir)/Makefile.local $(dir)/make-deps.el $(emacs_sources)
\r
87 > + $(call quiet,EMACS) --directory emacs -batch -l make-deps.el \
\r
88 > + -f batch-make-deps $(emacs_sources) > $@.tmp && \
\r
89 > + (cmp -s $@.tmp $@ || mv $@.tmp $@)
\r
91 The last line above could be in format
\r
93 { cmp -s $@.tmp $@ || mv $@.tmp $@; }
\r
95 so that the expression is evaluated in current shell instead of a subshell.
\r
97 You may consider changing this if you add year to copyright line.
\r
102 > +-include $(dir)/.eldeps
\r
103 > +CLEAN+=$(dir)/.eldeps $(dir)/.eldeps.tmp
\r
105 > %.elc: %.el $(global_deps)
\r
106 > $(call quiet,EMACS) --directory emacs -batch -f batch-byte-compile $<
\r