55/e9a518868abbb0114abccec251ca1c8bf655b8

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id F2FDB431FB6\r
   6         for <notmuch@notmuchmail.org>; Tue, 27 Dec 2011 19:23:01 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id OpRSjuwr4tQ0 for <notmuch@notmuchmail.org>;\r
  16         Tue, 27 Dec 2011 19:23:01 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-3.mit.edu (DMZ-MAILSEC-SCANNER-3.MIT.EDU\r
  18         [18.9.25.14])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 31348431FD0\r
  20         for <notmuch@notmuchmail.org>; Tue, 27 Dec 2011 19:23:01 -0800 (PST)\r
  21 X-AuditID: 1209190e-b7f7c6d0000008c3-6f-4efa8b94720b\r
  22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
  23         by dmz-mailsec-scanner-3.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 90.14.02243.49B8AFE4; Tue, 27 Dec 2011 22:23:00 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id pBS3Mx8o030450\r
  27         for <notmuch@notmuchmail.org>; Tue, 27 Dec 2011 22:23:00 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pBS3MwBO009119\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT)\r
  33         for <notmuch@notmuchmail.org>; Tue, 27 Dec 2011 22:22:59 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>) id 1Rfk7H-0001Pd-PF\r
  36         for notmuch@notmuchmail.org; Tue, 27 Dec 2011 22:23:47 -0500\r
  37 Date: Tue, 27 Dec 2011 22:23:47 -0500\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: notmuch <notmuch@notmuchmail.org>\r
  40 Subject: Re: [PATCH 2/4] Introduce a generic tree-like abstraction for MIME\r
  41         traversal.\r
  42 Message-ID: <20111228032347.GA30150@mit.edu>\r
  43 References: <1323027100-10307-1-git-send-email-amdragon@mit.edu>\r
  44         <1323460468-4030-1-git-send-email-amdragon@mit.edu>\r
  45         <1323460468-4030-3-git-send-email-amdragon@mit.edu>\r
  46         <87k46572f7.fsf@gmail.com> <20111224034500.GA1927@mit.edu>\r
  47         <4EF9D5E8.4050203@fifthhorseman.net>\r
  48 MIME-Version: 1.0\r
  49 Content-Type: text/plain; charset=us-ascii\r
  50 Content-Disposition: inline\r
  51 In-Reply-To: <4EF9D5E8.4050203@fifthhorseman.net>\r
  52 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  53 X-Brightmail-Tracker:\r
  54  H4sIAAAAAAAAA+NgFnrHIsWRmVeSWpSXmKPExsUixCmqrDul+5efwacbYhbXb85kdmD0eLbq\r
  55         FnMAYxSXTUpqTmZZapG+XQJXxv1LTawFB7gqek+1sTUwfmXvYuTkkBAwkZi8dw0bhC0mceHe\r
  56         eiCbi0NIYB+jxKpHixghnHOMEif2vGKCcJ4zSax+f58ZwjkEVLZ7LQtIP4uAqsSNa09ZQWw2\r
  57         AQ2JbfuXM4LYIkDxTWvvAtkcHMICERJPd9SBhHkFdCSmHX0MtW4Sk8Sht/dYIRKCEidnPgGb\r
  58         ySygJXHj30smkF5mAWmJ5f84QMKcAoYSb75uZQKxRQVUJKac3MY2gVFwFpLuWUi6ZyF0L2Bk\r
  59         XsUom5JbpZubmJlTnJqsW5ycmJeXWqRrrJebWaKXmlK6iREcrJJ8Oxi/HlQ6xCjAwajEw3vr\r
  60         7U8/IdbEsuLK3EOMkhxMSqK8Xl2//IT4kvJTKjMSizPii0pzUouB4cHBrCTCa/kAqJw3JbGy\r
  61         KrUoHyYlzcGiJM6rpvXOT0ggPbEkNTs1tSC1CCYrw8GhJMGrDIxKIcGi1PTUirTMnBKENBMH\r
  62         J8hwHqDhz0EW8xYXJOYWZ6ZD5E8xKkqJ8wqCNAuAJDJK8+B6YcnkFaM40CvCvAwgVTzARATX\r
  63         /QpoMBPQ4DjlHyCDSxIRUlINjDnfRIN+8dxeNe3fmg9dld4CKX6n+sXDq77sqd7CE1A03aQ7\r
  64         mV98Ltsxh2m/t/OkBH80zdm+dD+bgsLPC6Krpre9mHrlbee1+wwVL3b4SK13v+PRsG3hTmUV\r
  65         y8DrlYemas+TKjfkXWu7gqViwpvpm05uNzlctPf4qcSLlpNZpSfd/Hk+8MqZahslluKMREMt\r
  66         5qLiRACcsZ0vAQMAAA==\r
  67 X-BeenThere: notmuch@notmuchmail.org\r
  68 X-Mailman-Version: 2.1.13\r
  69 Precedence: list\r
  70 List-Id: "Use and development of the notmuch mail system."\r
  71         <notmuch.notmuchmail.org>\r
  72 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  73         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  74 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  75 List-Post: <mailto:notmuch@notmuchmail.org>\r
  76 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  77 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  78         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  79 X-List-Received-Date: Wed, 28 Dec 2011 03:23:02 -0000\r
  80 \r
  81 Quoth Daniel Kahn Gillmor on Dec 27 at  9:27 am:\r
  82 > On 12/23/2011 10:45 PM, Austin Clements wrote:\r
  83 > > Quoth Dmitry Kurochkin on Dec 10 at  3:25 am:\r
  84 > >> +           /* For some reason the GMimeSignatureValidity returned\r
  85 > >> +            * here is not a const (inconsistent with that\r
  86 > >> +            * returned by\r
  87 > >> +            * g_mime_multipart_encrypted_get_signature_validity,\r
  88 > >> +            * and therefore needs to be properly disposed of.\r
  89 > >> +            * Hopefully the API will become more consistent. */\r
  90 > >>\r
  91 > >> Ouch.  In gmime 2.6 this API has changed, but looks like the\r
  92 > >> issue is still there.  Is there a bug for it?  If yes, we should\r
  93 > >> add a reference to the comment.  Otherwise, we should file the\r
  94 > >> bug and then add a reference to the comment :)\r
  95 > > \r
  96 > > It looks like they're both non-const in 2.6 (which makes more sense to\r
  97 > > me).  I updated the comment to mention this.\r
  98 > \r
  99 > Here's the bug report where this was discussed with upstream, fwiw:\r
 100 > \r
 101 >   https://bugzilla.gnome.org/show_bug.cgi?id=640911\r
 102 \r
 103 Oh, are we not supposed to be disposing of the GMimeSignatureValidity\r
 104 returned by g_mime_multipart_encrypted_get_signature_validity\r
 105 ourselves?  Comment 1 on that bug report suggests that we shouldn't.\r
 106 The old show code did, so I ported that behavior over to the new code.\r