1 Return-Path: <pieter@praet.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id DE4DB431FAF
\r
6 for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 13:16:27 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id OaG6rXScU-lp for <notmuch@notmuchmail.org>;
\r
16 Thu, 19 Jan 2012 13:16:27 -0800 (PST)
\r
17 Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com
\r
18 [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
19 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
20 3CF04431FAE for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 13:16:27 -0800
\r
22 Received: by wgbdt12 with SMTP id dt12so395549wgb.2
\r
23 for <notmuch@notmuchmail.org>; Thu, 19 Jan 2012 13:16:24 -0800 (PST)
\r
24 Received: by 10.180.24.105 with SMTP id t9mr47056386wif.19.1327007784833;
\r
25 Thu, 19 Jan 2012 13:16:24 -0800 (PST)
\r
26 Received: from localhost ([109.131.97.13])
\r
27 by mx.google.com with ESMTPS id g12sm1886220wiw.10.2012.01.19.13.16.23
\r
28 (version=TLSv1/SSLv3 cipher=OTHER);
\r
29 Thu, 19 Jan 2012 13:16:24 -0800 (PST)
\r
30 From: Pieter Praet <pieter@praet.org>
\r
31 To: Austin Clements <amdragon@MIT.EDU>
\r
32 Subject: Re: [PATCH 1/4] search: rename auto_exclude_tags to {search,
\r
34 In-Reply-To: <20120119194115.GO16740@mit.edu>
\r
35 References: <1326586654-16840-3-git-send-email-amdragon@mit.edu>
\r
36 <1327000744-25463-1-git-send-email-pieter@praet.org>
\r
37 <1327000744-25463-2-git-send-email-pieter@praet.org>
\r
38 <20120119194115.GO16740@mit.edu>
\r
39 User-Agent: Notmuch/0.11+99~gab86e73 (http://notmuchmail.org) Emacs/23.3.1
\r
40 (x86_64-unknown-linux-gnu)
\r
41 Date: Thu, 19 Jan 2012 22:14:33 +0100
\r
42 Message-ID: <87bopzo0na.fsf@praet.org>
\r
44 Content-Type: text/plain; charset=us-ascii
\r
45 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
46 X-BeenThere: notmuch@notmuchmail.org
\r
47 X-Mailman-Version: 2.1.13
\r
49 List-Id: "Use and development of the notmuch mail system."
\r
50 <notmuch.notmuchmail.org>
\r
51 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
53 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
54 List-Post: <mailto:notmuch@notmuchmail.org>
\r
55 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
56 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
58 X-List-Received-Date: Thu, 19 Jan 2012 21:16:28 -0000
\r
60 On Thu, 19 Jan 2012 14:41:15 -0500, Austin Clements <amdragon@MIT.EDU> wrote:
\r
61 > Quoth Pieter Praet on Jan 19 at 8:19 pm:
\r
62 > > All other config-related functions and args include the section
\r
63 > > title in their name, so for the sake of consistency, mirror that.
\r
65 > > Also, the "auto"matic part is a given, so that was dropped.
\r
67 > LGTM other than one nit, below.
\r
69 > > --- a/notmuch-config.c
\r
70 > > +++ b/notmuch-config.c
\r
71 > > @@ -89,9 +89,9 @@ static const char search_config_comment[] =
\r
73 > > " The following option is supported here:\n"
\r
75 > > - "\tauto_exclude_tags A ;-separated list of tags that will be\n"
\r
76 > > - "\t excluded from search results by default. Using an excluded tag\n"
\r
77 > > - "\t in a query will override that exclusion.\n";
\r
78 > > + "\texclude_tags A list (separated by ';') of the tags that will be\n"
\r
79 > > + "\t\texcluded from search results by default. Using an excluded tag in a\n"
\r
80 > > + "\t\tquery will override that exclusion.\n";
\r
82 > I'd propose that any tag whose name is more than seven characters long
\r
83 > should have its description start under it, indented by a tab, like I
\r
84 > did in id:"1326920205-31296-1-git-send-email-amdragon@mit.edu". That
\r
85 > looks nice and keeps the description indented consistently without
\r
86 > ridiculous amounts of negative space and narrow wrapping.
\r
88 Oh, nice. Looks like I should first work down to inbox zero
\r
89 (still got a looong way to go :/...) before submitting patches.
\r
91 I'll wait for yours to be pushed before resubmitting this series.
\r