55/cf9d8d7aa40f7775d1f00aecc8138a2396f70c

   1 Return-Path: <jani@nikula.org>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 445D6431FBF\r
   6         for <notmuch@notmuchmail.org>; Sat, 22 Nov 2014 03:29:49 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id BsaJKE9U9wi4 for <notmuch@notmuchmail.org>;\r
  16         Sat, 22 Nov 2014 03:29:43 -0800 (PST)\r
  17 Received: from mail-wi0-f182.google.com (mail-wi0-f182.google.com\r
  18         [209.85.212.182]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
  19         (No client certificate requested)\r
  20         by olra.theworths.org (Postfix) with ESMTPS id 878AA431FBC\r
  21         for <notmuch@notmuchmail.org>; Sat, 22 Nov 2014 03:29:43 -0800 (PST)\r
  22 Received: by mail-wi0-f182.google.com with SMTP id h11so1609629wiw.9\r
  23         for <notmuch@notmuchmail.org>; Sat, 22 Nov 2014 03:29:42 -0800 (PST)\r
  24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
  25         d=1e100.net; s=20130820;\r
  26         h=x-gm-message-state:from:to:subject:in-reply-to:references\r
  27         :user-agent:date:message-id:mime-version:content-type;\r
  28         bh=DrgbaI5zAsYjaFMHfB7+ZEWlTBTRnTgdRye55tvw6S4=;\r
  29         b=EqsbVYUaDDyXcxGBhC9vvnI+ZDpmiGoV0w+nQQYPaIlm0JVaFOnMJ9OiAP3ZeVatmN\r
  30         xHDywBJFpuslfpKLt5+DovCrZbg6FW9G+InYm25QWqgCB/e1SunQs+eJpKYnv2Fu+4EJ\r
  31         UynQ0M7wvXlpf56bnzs5ufx0U97xPifnELhvvbvtC6jpCTWF3CHRgow3BiVZdH343A/z\r
  32         Vp9651lDrniaBazU6ykv4fp8l1Nh4frA4+Mj6q3f5th0tPIMjkqQPgGVLiNI6oeAM12Z\r
  33         sIpKGRMZcFrngRfzJZEdPZExXUVLQTIKUjpFZNR0uXH9e0w9I6RQQD5EWgMEINyu7xcm\r
  34         HjoQ==\r
  35 X-Gm-Message-State:\r
  36  ALoCoQlLvrX3pFf3z9/YMdkPI2B8Es3Ivru4W61iv9CumWKQWYtzQTzIPtpWFPGxY71OWNpIxtDd\r
  37 X-Received: by 10.194.5.227 with SMTP id v3mr16827917wjv.63.1416655782310;\r
  38         Sat, 22 Nov 2014 03:29:42 -0800 (PST)\r
  39 Received: from localhost (dsl-hkibrasgw2-58c362-144.dhcp.inet.fi.\r
  40         [88.195.98.144])\r
  41         by mx.google.com with ESMTPSA id ud1sm11882740wjc.7.2014.11.22.03.29.40\r
  42         for <multiple recipients>\r
  43         (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
  44         Sat, 22 Nov 2014 03:29:41 -0800 (PST)\r
  45 From: Jani Nikula <jani@nikula.org>\r
  46 To: Jesse Rosenthal <jrosenthal@jhu.edu>, notmuch@notmuchmail.org\r
  47 Subject: Re: [PATCH v2 1/2] lib: Use email address instead of empty real name.\r
  48 In-Reply-To: <1416585462-24558-2-git-send-email-jrosenthal@jhu.edu>\r
  49 References: <1416585462-24558-1-git-send-email-jrosenthal@jhu.edu>\r
  50         <1416585462-24558-2-git-send-email-jrosenthal@jhu.edu>\r
  51 User-Agent: Notmuch/0.19+1~gcffa3cf (http://notmuchmail.org) Emacs/24.4.1\r
  52         (x86_64-pc-linux-gnu)\r
  53 Date: Sat, 22 Nov 2014 13:29:38 +0200\r
  54 Message-ID: <87ppcfqxr1.fsf@nikula.org>\r
  55 MIME-Version: 1.0\r
  56 Content-Type: text/plain\r
  57 X-BeenThere: notmuch@notmuchmail.org\r
  58 X-Mailman-Version: 2.1.13\r
  59 Precedence: list\r
  60 List-Id: "Use and development of the notmuch mail system."\r
  61         <notmuch.notmuchmail.org>\r
  62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  63         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  65 List-Post: <mailto:notmuch@notmuchmail.org>\r
  66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  68         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  69 X-List-Received-Date: Sat, 22 Nov 2014 11:29:49 -0000\r
  70 \r
  71 On Fri, 21 Nov 2014, Jesse Rosenthal <jrosenthal@jhu.edu> wrote:\r
  72 > Currently, if a From-header is of the form:\r
  73 >\r
  74 >     "" <address@example.com>\r
  75 >\r
  76 > the empty string will be treated as a valid real-name, and the entry\r
  77 > in the search results will be empty.\r
  78 >\r
  79 > The new behavior here is that we treat an empty real-name field as if\r
  80 > it were null, so that the email address will be used in the search\r
  81 > results instead.\r
  82 \r
  83 Makes sense.\r
  84 \r
  85 > Signed-off-by: Jesse Rosenthal <jrosenthal@jhu.edu>\r
  86 > ---\r
  87 >  lib/thread.cc | 3 ++-\r
  88 >  1 file changed, 2 insertions(+), 1 deletion(-)\r
  89 >\r
  90 > diff --git a/lib/thread.cc b/lib/thread.cc\r
  91 > index 8922403..68b2b94 100644\r
  92 > --- a/lib/thread.cc\r
  93 > +++ b/lib/thread.cc\r
  94 > @@ -277,7 +277,8 @@ _thread_add_message (notmuch_thread_t *thread,\r
  95 >       address = internet_address_list_get_address (list, 0);\r
  96 >       if (address) {\r
  97 >           author = internet_address_get_name (address);\r
  98 > -         if (author == NULL) {\r
  99 > +         // We treat quoted empty names as if they were empty.\r
 100 \r
 101 Nitpick, we don't use // style comments.\r
 102 \r
 103 > +         if (author == NULL || author[0]=='\0' ) {\r
 104 \r
 105 Nitpick, please add spaces around "==" but no space before closing ")".\r
 106 \r
 107 \r
 108 BR,\r
 109 Jani.\r
 110 \r
 111 >               InternetAddressMailbox *mailbox;\r
 112 >               mailbox = INTERNET_ADDRESS_MAILBOX (address);\r
 113 >               author = internet_address_mailbox_get_addr (mailbox);\r
 114 > -- \r
 115 > 2.1.3\r
 116 >\r
 117 > _______________________________________________\r
 118 > notmuch mailing list\r
 119 > notmuch@notmuchmail.org\r
 120 > http://notmuchmail.org/mailman/listinfo/notmuch\r