1 Return-Path: <olly@survex.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E950A431FB6
\r
6 for <notmuch@notmuchmail.org>; Thu, 1 Mar 2012 13:20:47 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id sB89M8KcWBs3 for <notmuch@notmuchmail.org>;
\r
16 Thu, 1 Mar 2012 13:20:47 -0800 (PST)
\r
17 Received: from atreus.tartarus.org (atreus.tartarus.org [80.252.125.10])
\r
18 (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 49FE0431FAF
\r
21 for <notmuch@notmuchmail.org>; Thu, 1 Mar 2012 13:20:47 -0800 (PST)
\r
22 Received: from olly by atreus.tartarus.org with local (Exim 4.69)
\r
23 (envelope-from <olly@survex.com>)
\r
24 id 1S3DQX-0001YB-57; Thu, 01 Mar 2012 21:20:41 +0000
\r
25 Date: Thu, 1 Mar 2012 21:20:41 +0000
\r
26 From: Olly Betts <olly@survex.com>
\r
27 To: Justus Winter <4winter@informatik.uni-hamburg.de>
\r
28 Subject: Re: [PATCH] Actually close the xapian database in
\r
29 notmuch_database_close
\r
30 Message-ID: <20120301212040.GW24964@survex.com>
\r
32 <1330507157-22859-1-git-send-email-4winter@informatik.uni-hamburg.de>
\r
33 <1330507157-22859-2-git-send-email-4winter@informatik.uni-hamburg.de>
\r
34 <20120229154833.GB772@mit.edu> <20120229211922.GQ24964@survex.com>
\r
35 <20120229221754.GD772@mit.edu>
\r
36 <20120301065930.5076.72748@thinkbox.jade-hamburg.de>
\r
38 Content-Type: text/plain; charset=us-ascii
\r
39 Content-Disposition: inline
\r
40 In-Reply-To: <20120301065930.5076.72748@thinkbox.jade-hamburg.de>
\r
41 User-Agent: Mutt/1.5.18 (2008-05-17)
\r
42 Cc: notmuch@notmuchmail.org
\r
43 X-BeenThere: notmuch@notmuchmail.org
\r
44 X-Mailman-Version: 2.1.13
\r
46 List-Id: "Use and development of the notmuch mail system."
\r
47 <notmuch.notmuchmail.org>
\r
48 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
50 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
51 List-Post: <mailto:notmuch@notmuchmail.org>
\r
52 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
53 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
55 X-List-Received-Date: Thu, 01 Mar 2012 21:20:48 -0000
\r
57 On Thu, Mar 01, 2012 at 07:59:30AM +0100, Justus Winter wrote:
\r
59 > >It is hard to say if calling close() is actually useful here from just
\r
60 > >seeing the patch.
\r
62 > Huh? I provided a test case...
\r
64 I only saw the part of the patch Austin quoted in the mail he cc-ed to
\r
67 > Quoting Austin Clements (2012-02-29 23:17:54)
\r
68 > >Also, since close could throw an exception, it should get wrapped in a
\r
69 > >try/catch like flush currently is.
\r
71 > My interpretation of [0] was that Xapian::Database::close() does not
\r
72 > throw any exceptions.
\r
74 Sadly there's not full documentation of exceptions which can be thrown
\r
75 by a particular method.
\r