53/910d6de24fc18a0f2c75e3ee593a16ecd79e09

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 11884429E3E\r
   6         for <notmuch@notmuchmail.org>; Fri, 23 Dec 2011 19:45:36 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id kMKeq3OeIXZH for <notmuch@notmuchmail.org>;\r
  16         Fri, 23 Dec 2011 19:45:35 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU\r
  18         [18.7.68.35])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 90C30429E3D\r
  20         for <notmuch@notmuchmail.org>; Fri, 23 Dec 2011 19:45:35 -0800 (PST)\r
  21 X-AuditID: 12074423-b7f9c6d0000008c3-af-4ef54adee8c5\r
  22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
  23         by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 6C.2C.02243.EDA45FE4; Fri, 23 Dec 2011 22:45:34 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id pBO3jXiG003716; \r
  27         Fri, 23 Dec 2011 22:45:34 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id pBO3jWes017779\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Fri, 23 Dec 2011 22:45:33 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1ReIZ7-0002Fm-Fu; Fri, 23 Dec 2011 22:46:33 -0500\r
  37 Date: Fri, 23 Dec 2011 22:46:33 -0500\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>\r
  40 Subject: Re: [PATCH 4/4] show: Rewrite show_message_body to use the MIME tree\r
  41         interface.\r
  42 Message-ID: <20111224034633.GD1927@mit.edu>\r
  43 References: <1323027100-10307-1-git-send-email-amdragon@mit.edu>\r
  44         <1323460468-4030-1-git-send-email-amdragon@mit.edu>\r
  45         <1323460468-4030-5-git-send-email-amdragon@mit.edu>\r
  46         <87ehwb75xx.fsf@gmail.com>\r
  47 MIME-Version: 1.0\r
  48 Content-Type: text/plain; charset=us-ascii\r
  49 Content-Disposition: inline\r
  50 In-Reply-To: <87ehwb75xx.fsf@gmail.com>\r
  51 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  52 X-Brightmail-Tracker:\r
  53  H4sIAAAAAAAAA+NgFmpmleLIzCtJLcpLzFFi42IR4hRV1r3n9dXPYPVSIYurW/vZLa7fnMns\r
  54         wOSxc9Zddo9nq24xBzBFcdmkpOZklqUW6dslcGVsPr6fpWAyW8X95Q8ZGxhvsXQxcnJICJhI\r
  55         rN20jwnCFpO4cG89G4gtJLCPUaK91bqLkQvI3sAocWnrI1aIxEkmiQ2nYiESSxgltn3fxgiS\r
  56         YBFQleideJIdxGYT0JDYtn85WFxEwFDi1sVXzCA2s4C0xLffzWDbhAWiJCYdXAd2Ba+AtsTZ\r
  57         xslMEENPMkrsOb2JFSIhKHFy5hMWiGYtiRv/XgIVcYANWv6PAyTMKaAu0X6hC2yXqICKxJST\r
  58         29gmMArNQtI9C0n3LITuBYzMqxhlU3KrdHMTM3OKU5N1i5MT8/JSi3TN9HIzS/RSU0o3MYLC\r
  59         mt1FeQfjn4NKhxgFOBiVeHibl37xE2JNLCuuzD3EKMnBpCTKe9Xtq58QX1J+SmVGYnFGfFFp\r
  60         TmrxIUYJDmYlEV7NJKBy3pTEyqrUonyYlDQHi5I4r4bWOz8hgfTEktTs1NSC1CKYrAwHh5IE\r
  61         rwIwfoUEi1LTUyvSMnNKENJMHJwgw3mAhruB1PAWFyTmFmemQ+RPMSpKifNqgyQEQBIZpXlw\r
  62         vbC084pRHOgVYV4pkCoeYMqC634FNJgJaHCMEcjVxSWJCCmpBkaunPKpHmxnr5ozdPRvyZm1\r
  63         yPz4Vmml07zvdma0HNT5o3TMyd4ow+Wsk6p23PboasGJBzXLwgpP3Cs6LLJlfeX2V0Ym8qty\r
  64         k6bwr7bdlXX+vprhnG2fL71w2M3PIdIWH6DW/CCn6srNOz6SkZOYcvdsP7jWSqxI++XuTanq\r
  65         k7w/OZ1UV78bXqbEUpyRaKjFXFScCACh8q65FgMAAA==\r
  66 Cc: notmuch@notmuchmail.org\r
  67 X-BeenThere: notmuch@notmuchmail.org\r
  68 X-Mailman-Version: 2.1.13\r
  69 Precedence: list\r
  70 List-Id: "Use and development of the notmuch mail system."\r
  71         <notmuch.notmuchmail.org>\r
  72 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  73         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  74 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  75 List-Post: <mailto:notmuch@notmuchmail.org>\r
  76 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  77 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  78         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  79 X-List-Received-Date: Sat, 24 Dec 2011 03:45:36 -0000\r
  80 \r
  81 Quoth Dmitry Kurochkin on Dec 11 at  2:34 pm:\r
  82 > Hi Austin.\r
  83 > \r
  84 > I enjoyed reviewing this patch.  It is a pleasure to see how complex and\r
  85 > confusing code becomes much smaller and cleaner.\r
  86 > \r
  87 > I still have some questions with the new code.  It seems confusing to me\r
  88 > that part_content is called first and then go envelope headers.  But I\r
  89 > this is just the first step of the rewrite, right? :)\r
  90 \r
  91 Yeah, this is weird, but I'm just being compatible with the existing\r
  92 code at this point.  This code is about to go away.\r
  93 \r
  94 > The only comment I have:\r
  95 > \r
  96 > +    format->part_content (part);\r
  97 > \r
  98 > For all other format members that are function pointers, we have a check\r
  99 > for NULL.  Perhaps we should add it here as well?\r
 100 \r
 101 I would if I weren't about to delete this.  ]:--8)\r