1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 78846431FBD
\r
6 for <notmuch@notmuchmail.org>; Sat, 25 Jan 2014 10:34:33 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id Pk+9GqXTn9q7 for <notmuch@notmuchmail.org>;
\r
16 Sat, 25 Jan 2014 10:34:28 -0800 (PST)
\r
17 Received: from yantan.tethera.net (yantan.tethera.net [199.188.72.155])
\r
18 (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id BA06C431FBC
\r
21 for <notmuch@notmuchmail.org>; Sat, 25 Jan 2014 10:34:28 -0800 (PST)
\r
22 Received: from remotemail by yantan.tethera.net with local (Exim 4.80)
\r
23 (envelope-from <david@tethera.net>)
\r
24 id 1W783l-0003Qy-KZ; Sat, 25 Jan 2014 14:34:25 -0400
\r
25 Received: (nullmailer pid 3574 invoked by uid 1000); Sat, 25 Jan 2014
\r
27 From: David Bremner <david@tethera.net>
\r
28 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
29 Subject: Re: [PATCH] emacs: initialize ido mode in notmuch-mua.el
\r
30 In-Reply-To: <1329900529-16295-1-git-send-email-markwalters1009@gmail.com>
\r
31 References: <87y5sipcjn.fsf@qmul.ac.uk>
\r
32 <1329900529-16295-1-git-send-email-markwalters1009@gmail.com>
\r
33 User-Agent: Notmuch/0.17+42~gb867564 (http://notmuchmail.org) Emacs/24.3.1
\r
34 (x86_64-pc-linux-gnu)
\r
35 Date: Sat, 25 Jan 2014 14:34:22 -0400
\r
36 Message-ID: <87bnyzoqq9.fsf@zancas.localnet>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.13
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Sat, 25 Jan 2014 18:34:33 -0000
\r
53 Mark Walters <markwalters1009@gmail.com> writes:
\r
55 > ido-completing-read is used in notmuch-mua.el without any
\r
56 > initialization. This should work but a bug (emacs bug #3247) in some
\r
57 > emacs 23 versions (including 23.2.1 from Debian stable) causes emacs
\r
58 > to get stuck in the mini-buffer. This tests to see if ido-mode has
\r
59 > been initialized and if not calls it. This avoids the bug for these
\r
60 > older versions of emacs.
\r
62 > This is the only place that ido-completing-read is used so an alternative
\r
63 > would be to replace ido-completing-read by completing-read but cworth
\r
64 > expressed a preference for the ido version in
\r
65 > id:"87wrhfvk6a.fsf@yoom.home.cworth.
\r
67 This patch was tagged wip, but then there was no progress ;). It still
\r
68 applies cleanly, and doesn't seem to do any harm in emacs 23.4 nor
\r
69 emacs24.3. I don't have 23.2 at hand but I guess Tomi or Mark can
\r
70 confirm it actually fixes the bug there.
\r
72 I propose we either apply the patch or ::wontfix the bug.
\r