1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E52C4431FAF
\r
6 for <notmuch@notmuchmail.org>; Tue, 10 Apr 2012 13:52:46 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=1.401 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 FREEMAIL_REPLY=2.499, NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3]
\r
15 Received: from olra.theworths.org ([127.0.0.1])
\r
16 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
17 with ESMTP id 8J1HohkXfIO0 for <notmuch@notmuchmail.org>;
\r
18 Tue, 10 Apr 2012 13:52:46 -0700 (PDT)
\r
19 Received: from mail2.qmul.ac.uk (mail2.qmul.ac.uk [138.37.6.6])
\r
20 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
21 (No client certificate requested)
\r
22 by olra.theworths.org (Postfix) with ESMTPS id 17AEA431FAE
\r
23 for <notmuch@notmuchmail.org>; Tue, 10 Apr 2012 13:52:46 -0700 (PDT)
\r
24 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
25 by mail2.qmul.ac.uk with esmtp (Exim 4.71)
\r
26 (envelope-from <m.walters@qmul.ac.uk>)
\r
27 id 1SHi3N-0001fy-Pa; Tue, 10 Apr 2012 21:52:42 +0100
\r
28 Received: from 94-192-233-223.zone6.bethere.co.uk ([94.192.233.223]
\r
30 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.69)
\r
31 (envelope-from <m.walters@qmul.ac.uk>)
\r
32 id 1SHi3N-0005jd-EH; Tue, 10 Apr 2012 21:52:41 +0100
\r
33 From: Mark Walters <markwalters1009@gmail.com>
\r
34 To: Adam Wolfe Gordon <awg+notmuch@xvx.ca>
\r
35 Subject: Re: [PATCH 1/2] cli: make --entire-thread=false work for format=json.
\r
37 <CAMoJFUuXmLQR+awJnPKg8ZJAKbHbPAmSrEUVoFj_=dZ76WiKzw@mail.gmail.com>
\r
38 References: <1334077496-9172-1-git-send-email-markwalters1009@gmail.com>
\r
39 <1334077496-9172-2-git-send-email-markwalters1009@gmail.com>
\r
40 <CAMoJFUuXmLQR+awJnPKg8ZJAKbHbPAmSrEUVoFj_=dZ76WiKzw@mail.gmail.com>
\r
41 User-Agent: Notmuch/0.12+101~g43fd4f1 (http://notmuchmail.org) Emacs/23.3.1
\r
42 (x86_64-pc-linux-gnu)
\r
43 Date: Tue, 10 Apr 2012 21:52:58 +0100
\r
44 Message-ID: <87zkajux5h.fsf@qmul.ac.uk>
\r
46 Content-Type: text/plain; charset=utf-8
\r
47 Content-Transfer-Encoding: quoted-printable
\r
48 X-Sender-Host-Address: 94.192.233.223
\r
49 X-QM-SPAM-Info: Sender has good ham record. :)
\r
50 X-QM-Body-MD5: 4061f153276e8083fe348e752afd52a1 (of first 20000 bytes)
\r
51 X-SpamAssassin-Score: -1.2
\r
52 X-SpamAssassin-SpamBar: -
\r
53 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
55 spam. We require at least 5.0 points to mark a message as spam.
\r
56 This message scored -1.2 points.
\r
57 Summary of the scoring:
\r
58 * -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at http://www.dnswl.org/,
\r
60 * [138.37.6.40 listed in list.dnswl.org]
\r
61 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
62 provider * (markwalters1009[at]gmail.com)
\r
63 * -0.0 T_RP_MATCHES_RCVD Envelope sender domain matches handover relay
\r
65 * 1.0 FREEMAIL_REPLY From and body contain different freemails
\r
66 * 0.1 AWL AWL: From: address is in the auto white-list
\r
67 X-QM-Scan-Virus: ClamAV says the message is clean
\r
68 Cc: notmuch@notmuchmail.org
\r
69 X-BeenThere: notmuch@notmuchmail.org
\r
70 X-Mailman-Version: 2.1.13
\r
72 List-Id: "Use and development of the notmuch mail system."
\r
73 <notmuch.notmuchmail.org>
\r
74 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
76 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
77 List-Post: <mailto:notmuch@notmuchmail.org>
\r
78 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
79 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
80 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
81 X-List-Received-Date: Tue, 10 Apr 2012 20:52:47 -0000
\r
83 On Tue, 10 Apr 2012, Adam Wolfe Gordon <awg+notmuch@xvx.ca> wrote:
\r
86 > This looks good to me, but I haven't tested it. It's probably worth
\r
87 > adding a test for the new functionality.
\r
89 Yes I agree. I could add a test to the json tests, or I could update the
\r
90 pair of test patches at
\r
91 id:"1332171061-27983-1-git-send-email-markwalters1009@gmail.com" as
\r
92 there do not seem to be any tests for --entire-thread or not for the
\r
93 other formats either. What do you think?
\r
95 > One style issue below, which is a matter of taste and I'll defer to
\r
96 > others if they disagree:
\r
98 > On Tue, Apr 10, 2012 at 11:04, Mark Walters <markwalters1009@gmail.com> w=
\r
100 >> @@ -895,10 +905,11 @@ show_messages (void *ctx,
\r
101 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0if (status && !res)
\r
102 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0res =3D status;
\r
103 >> =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0next_indent =3D indent + 1;
\r
104 >> + =C2=A0 =C2=A0 =C2=A0 } else
\r
105 >> + =C2=A0 =C2=A0 =C2=A0 =C2=A0 =C2=A0 status =3D show_null_message (forma=
\r
108 > I accept, but don't particularly like, the notmuch style of omitting
\r
109 > braces where they aren't required. However, an else with a brace on
\r
110 > only one side just looks weird. If they're like this everywhere else
\r
111 > then I guess it's best to be consistent, but to me it's a lot more
\r
112 > readable as } else {.
\r
114 > As I said above, I'll defer to others' judgement here, just thought it
\r
115 > was worth pointing out.
\r
117 Yes I will fix this in the next version (I recall Jani agreed with you
\r
118 so I will take that as preferred unless someone says otherwise.)
\r