1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 203D4431FC7
\r
6 for <notmuch@notmuchmail.org>; Wed, 23 Oct 2013 11:28:45 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id hsG3898Ahk5s for <notmuch@notmuchmail.org>;
\r
16 Wed, 23 Oct 2013 11:28:35 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id ABB26431FBC
\r
19 for <notmuch@notmuchmail.org>; Wed, 23 Oct 2013 11:28:35 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id E9976100217;
\r
22 Wed, 23 Oct 2013 21:28:27 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH v2 0/8] Improve tag change completion
\r
26 In-Reply-To: <87k3h40y64.fsf@qmul.ac.uk>
\r
27 References: <1382487721-31776-1-git-send-email-amdragon@mit.edu>
\r
28 <87k3h40y64.fsf@qmul.ac.uk>
\r
29 User-Agent: Notmuch/0.16+115~g11c2ff5 (http://notmuchmail.org) Emacs/24.3.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Wed, 23 Oct 2013 21:28:27 +0300
\r
35 Message-ID: <m2hac7u9is.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Wed, 23 Oct 2013 18:28:45 -0000
\r
52 On Wed, Oct 23 2013, Mark Walters <markwalters1009@gmail.com> wrote:
\r
54 > In might of id:20131023154404.GE20337@mit.edu I am now happy with this
\r
57 Looks Good To Me, too - and worked in my test tagging operations as
\r
68 > On Wed, 23 Oct 2013, Austin Clements <amdragon@MIT.EDU> wrote:
\r
69 >> This is v2 of id:1382471457-26056-1-git-send-email-amdragon@mit.edu.
\r
70 >> It improves some documentation strings, fixes one bug, and elimintes
\r
71 >> some redundant code. The diff from v1 is below.
\r
73 >> diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
74 >> index ef77839..f66d669 100644
\r
75 >> --- a/emacs/notmuch-show.el
\r
76 >> +++ b/emacs/notmuch-show.el
\r
77 >> @@ -1800,7 +1800,6 @@ See `notmuch-tag' for information on the format of TAG-CHANGES."
\r
78 >> (list (let (tags)
\r
79 >> (notmuch-show-mapc
\r
80 >> (lambda () (setq tags (append (notmuch-show-get-tags) tags))))
\r
81 >> - (delete-dups tags)
\r
82 >> (notmuch-read-tag-changes tags "Tag thread"))))
\r
83 >> (notmuch-tag (notmuch-show-get-messages-ids-search) tag-changes)
\r
84 >> (notmuch-show-mapc
\r
85 >> diff --git a/emacs/notmuch-tag.el b/emacs/notmuch-tag.el
\r
86 >> index feee17c..7b21006 100644
\r
87 >> --- a/emacs/notmuch-tag.el
\r
88 >> +++ b/emacs/notmuch-tag.el
\r
89 >> @@ -189,6 +189,9 @@ the messages that were tagged"
\r
90 >> `notmuch-read-tag-changes' function.")
\r
92 >> (defun notmuch-tag-completions (&rest search-terms)
\r
93 >> + "Return a list of tags for messages matching SEARCH-TERMS.
\r
95 >> +Returns all tags if no search terms are given."
\r
96 >> (if (null search-terms)
\r
97 >> (setq search-terms (list "*")))
\r
99 >> @@ -199,7 +202,7 @@ the messages that were tagged"
\r
102 >> (defun notmuch-select-tag-with-completion (prompt &rest search-terms)
\r
103 >> - (let ((tag-list (notmuch-tag-completions search-terms)))
\r
104 >> + (let ((tag-list (apply #'notmuch-tag-completions search-terms)))
\r
105 >> (completing-read prompt tag-list nil nil nil 'notmuch-select-tag-history)))
\r
107 >> (defun notmuch-read-tag-changes (current-tags &optional prompt initial-input)
\r
108 >> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
109 >> index 5492e1b..53e9826 100644
\r
110 >> --- a/emacs/notmuch.el
\r
111 >> +++ b/emacs/notmuch.el
\r
112 >> @@ -584,7 +584,10 @@ Returns (TAG-CHANGES REGION-BEGIN REGION-END)."
\r
113 >> "Change tags for the currently selected thread or region.
\r
115 >> See `notmuch-tag' for information on the format of TAG-CHANGES.
\r
116 >> -If BEG or END are nil, applies to the thread at point."
\r
117 >> +When called interactively, this uses the region if the region is
\r
118 >> +active. When called directly, BEG and END provide the region.
\r
119 >> +If these are nil or not provided, this applies to the thread at
\r
121 >> (interactive (notmuch-search-interactive-tag-changes))
\r
122 >> (unless (and beg end) (setq beg (point) end (point)))
\r
123 >> (let ((search-string (notmuch-search-find-thread-id-region-search beg end)))
\r
124 > _______________________________________________
\r
125 > notmuch mailing list
\r
126 > notmuch@notmuchmail.org
\r
127 > http://notmuchmail.org/mailman/listinfo/notmuch
\r