1 Return-Path: <dme@dme.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 485006DE1765
\r
6 for <notmuch@notmuchmail.org>; Tue, 9 Feb 2016 12:31:10 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-0.083 tagged_above=-999 required=5
\r
12 tests=[AWL=-0.016, DKIM_SIGNED=0.1, DKIM_VALID=-0.1,
\r
13 RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=-0.01,
\r
14 RCVD_IN_MSPIKE_WL=-0.01, SPF_NEUTRAL=0.652, UNPARSEABLE_RELAY=0.001]
\r
16 Received: from arlo.cworth.org ([127.0.0.1])
\r
17 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
18 with ESMTP id HTMUQsKlIfIw for <notmuch@notmuchmail.org>;
\r
19 Tue, 9 Feb 2016 12:31:08 -0800 (PST)
\r
20 Received: from mail-wm0-f67.google.com (mail-wm0-f67.google.com
\r
21 [74.125.82.67]) by arlo.cworth.org (Postfix) with ESMTPS id 10ED16DE1635 for
\r
22 <notmuch@notmuchmail.org>; Tue, 9 Feb 2016 12:31:08 -0800 (PST)
\r
23 Received: by mail-wm0-f67.google.com with SMTP id g62so48966wme.2
\r
24 for <notmuch@notmuchmail.org>; Tue, 09 Feb 2016 12:31:07 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
26 d=dme-org.20150623.gappssmtp.com; s=20150623;
\r
27 h=to:subject:in-reply-to:references:from:date:message-id:mime-version
\r
28 :content-type; bh=NtIR1h+52vW3r1iPYVOaIofqE7rXZG24yMIACReV7i4=;
\r
29 b=I1yXH6ZNhVbRW7ZM+7EUwtjpF7QYGqBYijo7dvUEJyDbE4ojpb/JY+g6lm9JJYoFm5
\r
30 So2G2aAX9PSn4ba33wbrCRxxoZENcAyBp1K2fz5SsMc2cZ7StbAmOt0jHBDk8ITxPyHq
\r
31 EKaQfoIZ5azAYg2eEXhAolncEQnSPYRwgf21SyCZxh18PvUa3oGRImW3mLvALST0PQFw
\r
32 GF3NZJElH3kKKSt2448NsdQfe7avWJixGkclgEd9UICNaFFBZNalamfpdqw0gZiceuE6
\r
33 MZ8O0LokkTypqbb84pvsOQbCYUsxBlIQgKp5ToB36Q7QYSjEWSUcA5OFf5fiWPOIp6zC
\r
35 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
36 d=1e100.net; s=20130820;
\r
37 h=x-gm-message-state:to:subject:in-reply-to:references:from:date
\r
38 :message-id:mime-version:content-type;
\r
39 bh=NtIR1h+52vW3r1iPYVOaIofqE7rXZG24yMIACReV7i4=;
\r
40 b=cq5XvcvLbqpxMWBNieiYzEhrj/lA+iZd2JtZ7akuvZmUzekWC/Cuz1YD02r+PuMWyk
\r
41 5kuJTXvIm+MDbZlGFVRcBZr4ZKrkxKSBe7uqoLPWRWOmSC7t4bhMfFPHVZh5eTRBzK3z
\r
42 c4FEjytiLiG1+M4/sPJM/e/IN9ppgUc+xZRVuuKzu+qSKVN673EpLnModd0RZ03j54QB
\r
43 ZnhwPcjQFGtlrk+1ofhjdchx5UG4+bY/bX5/qIbWAhlGnHnk+bZn0s1e1AT3aUB8xC3z
\r
44 /ab7OLKTXE+p6J/PH3SfbSTe0qvMKZdwkV4lraG9vDX8GG3gPhNa9wjfGWa4H5jPM9t0
\r
47 AG10YOQM91+Yba6TEIxwfKDE3qJRZy4hCgYQaYnAVnAMVrqAlOy1TVzU0EWLwlskDiFhnw==
\r
48 X-Received: by 10.28.145.7 with SMTP id t7mr7019661wmd.98.1455049866755;
\r
49 Tue, 09 Feb 2016 12:31:06 -0800 (PST)
\r
50 Received: from disaster-area.hh.sledj.net
\r
51 ([2a01:348:1a2:1:ea39:35ff:fe2c:a227])
\r
52 by smtp.gmail.com with ESMTPSA id g126sm3942653wmf.16.2016.02.09.12.31.05
\r
53 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
\r
54 Tue, 09 Feb 2016 12:31:05 -0800 (PST)
\r
55 Received: from localhost (disaster-area.hh.sledj.net [local])
\r
56 by disaster-area.hh.sledj.net (OpenSMTPD) with ESMTPA id 634294d7;
\r
57 Tue, 9 Feb 2016 20:31:05 +0000 (UTC)
\r
58 To: Mark Walters <markwalters1009@gmail.com>, notmuch@notmuchmail.org
\r
59 Subject: Re: [PATCH v4 4/7] emacs/show: Remove the 'no-buttons option of
\r
60 `notmuch-show-insert-bodypart'
\r
61 In-Reply-To: <1446894276-7814-5-git-send-email-markwalters1009@gmail.com>
\r
62 References: <1446894276-7814-1-git-send-email-markwalters1009@gmail.com>
\r
63 <1446894276-7814-5-git-send-email-markwalters1009@gmail.com>
\r
64 From: David Edmondson <dme@dme.org>
\r
65 Date: Tue, 09 Feb 2016 20:31:05 +0000
\r
66 Message-ID: <m27fid4ody.fsf@dme.org>
\r
68 Content-Type: text/plain
\r
69 X-BeenThere: notmuch@notmuchmail.org
\r
70 X-Mailman-Version: 2.1.20
\r
72 List-Id: "Use and development of the notmuch mail system."
\r
73 <notmuch.notmuchmail.org>
\r
74 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
76 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
77 List-Post: <mailto:notmuch@notmuchmail.org>
\r
78 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
79 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
80 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
81 X-List-Received-Date: Tue, 09 Feb 2016 20:31:10 -0000
\r
83 On Sat, Nov 07 2015, Mark Walters wrote:
\r
84 > From: David Edmondson <dme@dme.org>
\r
86 > No code uses the 'no-buttons argument to
\r
87 > `notmuch-show-insert-bodypart', so remove it.
\r
91 > emacs/notmuch-show.el | 7 ++-----
\r
92 > 1 file changed, 2 insertions(+), 5 deletions(-)
\r
94 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
95 > index 9fc79e0..f8184e2 100644
\r
96 > --- a/emacs/notmuch-show.el
\r
97 > +++ b/emacs/notmuch-show.el
\r
98 > @@ -956,9 +956,7 @@ (defun notmuch-show-insert-bodypart (msg part depth &optional hide)
\r
100 > HIDE determines whether to show or hide the part and the button
\r
101 > as follows: If HIDE is nil, show the part and the button. If HIDE
\r
102 > -is t, hide the part initially and show the button. If HIDE is
\r
103 > -'no-buttons, show the part but do not add any buttons (this is
\r
104 > -useful for quoting in replies)."
\r
105 > +is t, hide the part initially and show the button."
\r
107 > (let* ((content-type (downcase (plist-get part :content-type)))
\r
108 > (mime-type (notmuch-show-mime-type part))
\r
109 > @@ -969,8 +967,7 @@ (defun notmuch-show-insert-bodypart (msg part depth &optional hide)
\r
111 > ;; We omit the part button for the first (or only) part if
\r
112 > ;; this is text/plain, or HIDE is 'no-buttons.
\r
113 > - (button (when (and (not (equal hide 'no-buttons))
\r
114 > - (notmuch-show-insert-header-p part hide))
\r
115 > + (button (when (notmuch-show-insert-header-p part hide)
\r
116 > (notmuch-show-insert-part-header nth mime-type content-type (plist-get part :filename))))
\r
117 > ;; Hide the part initially if HIDE is t, or if it is too long
\r
118 > ;; and we have a button to allow toggling (thus reply which
\r