1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 726736DE0298
\r
6 for <notmuch@notmuchmail.org>; Mon, 28 Sep 2015 04:44:33 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.106 tagged_above=-999 required=5 tests=[AWL=0.106]
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id DfUSOkKbPCe6 for <notmuch@notmuchmail.org>;
\r
16 Mon, 28 Sep 2015 04:44:31 -0700 (PDT)
\r
17 Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])
\r
18 by arlo.cworth.org (Postfix) with ESMTPS id 3410B6DE0274
\r
19 for <notmuch@notmuchmail.org>; Mon, 28 Sep 2015 04:44:31 -0700 (PDT)
\r
20 Received: from remotemail by gitolite.debian.net with local (Exim 4.80)
\r
21 (envelope-from <david@tethera.net>)
\r
22 id 1ZgWpP-0003pU-BJ; Mon, 28 Sep 2015 11:42:43 +0000
\r
23 Received: (nullmailer pid 12592 invoked by uid 1000); Mon, 28 Sep 2015
\r
25 From: David Bremner <david@tethera.net>
\r
26 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
27 Subject: Re: [PATCH 2/3] lib: add interface to delete directory documents
\r
29 <a9303b1bb200dc529b3bdfa35dc8f9f7e603a06f.1443213654.git.jani@nikula.org>
\r
30 References: <cover.1443213654.git.jani@nikula.org>
\r
31 <a9303b1bb200dc529b3bdfa35dc8f9f7e603a06f.1443213654.git.jani@nikula.org>
\r
32 User-Agent: Notmuch/0.20.2+93~g33c8777 (http://notmuchmail.org) Emacs/24.5.1
\r
33 (x86_64-pc-linux-gnu)
\r
34 Date: Mon, 28 Sep 2015 08:42:24 -0300
\r
35 Message-ID: <871tdidb33.fsf@zancas.localnet>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.18
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Mon, 28 Sep 2015 11:44:33 -0000
\r
52 Jani Nikula <jani@nikula.org> writes:
\r
55 > XXX: Should this also remove the files under it, or assume that's been
\r
56 > done by the caller? Should this incorporate some or all of the
\r
57 > functionality of _remove_directory() in notmuch-new.c?
\r
59 1) The top level _remove_directory function does seem to make sense in
\r
61 2) it calls remove_filename, which reads and writes add_files_state in
\r
63 3) In particular it needs to read synchronize_flags, and write
\r
64 renamed_messages and removed_messages.
\r
66 I guess one solution would be to pass through three arguments. A fancier
\r
67 version would be to pass in a "visitor" function and closure pointer.
\r
69 The cowardly solution would be to point at POSIX rmdir, and leave the
\r
70 discussion immediately above for the future.
\r