1 Return-Path: <markwalters1009@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 76F6E6DE0BF6
\r
6 for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 13:05:31 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-0.236 tagged_above=-999 required=5 tests=[AWL=0.334,
\r
12 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7,
\r
14 RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001]
\r
16 Received: from arlo.cworth.org ([127.0.0.1])
\r
17 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
18 with ESMTP id 5zcP7GkW4j5h for <notmuch@notmuchmail.org>;
\r
19 Wed, 10 Feb 2016 13:05:29 -0800 (PST)
\r
20 Received: from mail-wm0-f65.google.com (mail-wm0-f65.google.com
\r
21 [74.125.82.65]) by arlo.cworth.org (Postfix) with ESMTPS id 2882C6DE0B36 for
\r
22 <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 13:05:29 -0800 (PST)
\r
23 Received: by mail-wm0-f65.google.com with SMTP id c200so6711228wme.0
\r
24 for <notmuch@notmuchmail.org>; Wed, 10 Feb 2016 13:05:29 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=aYyK8J7ZlfylLkp6CLJVp27u2O0p3pUzJHowm3+Pocg=;
\r
29 b=I3rLZRKTU+dIX9XywReWMnV9o49iksYRHgrtcVQeh7VIqUvCujz/fD/qTXPi0QEJBf
\r
30 dBoGPfFAggEL2qyzeC9Z22b/gqaJOHLoROPOzGSc/lcc+jf2zT5wTpnv/NDHbXbHTcas
\r
31 kLgTV7ZNdcbUQDwbibVZJo19YE6ufsRm4jXFRqaaqDLmSY2ZTvyYd0nTq1YadS+Eyjh1
\r
32 IUmAN+/33TNWcxLJW5FNjqFB915sdwWk/33qYhxa9fsGAobOWTrwgMFwst7i82o7bhzs
\r
33 CtsqrwhW6yb2vp4wTRlIRyB42A5VHk5rYm+2z8bhmkP1Woobtu3Pe9kMqCMtz2AnOPC8
\r
35 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
36 d=1e100.net; s=20130820;
\r
37 h=x-gm-message-state:from:to:subject:in-reply-to:references
\r
38 :user-agent:date:message-id:mime-version:content-type;
\r
39 bh=aYyK8J7ZlfylLkp6CLJVp27u2O0p3pUzJHowm3+Pocg=;
\r
40 b=g9/N1+Ak5SdN6e00zMX+3bRfGjiQoHmrK20gB1y74bF3DVsyrsZsWtiNGyD3OYJGXA
\r
41 WKrhnWnc0s1ZIYzuKB4WwL+Ha+TCalrxI+1jDHmPUy/d3nM4syHBwk+uyZ8qLM5Gkeyb
\r
42 s1p3HLOkgn9HvhtVbl5ATnVfMp6Q8KZGX19tEZ0OxMfpUrSlcZcY/qCk2q0qqaFv9TXU
\r
43 jICBcM8nEwyi52N55gqu2sTFrQIcBl6nfoj6cKGP/X8q3lLTW39SzFzz9cnqsyB9mSV+
\r
44 Y9uhbgqf2ffVlPMcV6aU0hvmD/SL6j0NkHLPABlKBtWlEquz3GiE5teqnljQr0yE2KKJ
\r
47 AG10YORevTE9Me3bfhUXM9etm05UoEuKh+USFcmSf+8TLtOWa3Msy1bAaXTteA3K+Eygcg==
\r
48 X-Received: by 10.28.210.143 with SMTP id j137mr13161038wmg.13.1455138327703;
\r
49 Wed, 10 Feb 2016 13:05:27 -0800 (PST)
\r
50 Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162])
\r
51 by smtp.gmail.com with ESMTPSA id c7sm5035587wmd.13.2016.02.10.13.05.26
\r
52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
\r
53 Wed, 10 Feb 2016 13:05:27 -0800 (PST)
\r
54 From: Mark Walters <markwalters1009@gmail.com>
\r
55 To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
\r
56 Subject: Re: [PATCH v2] emacs: Report a lack of matches when calling
\r
58 In-Reply-To: <m260xw2vim.fsf@dme.org>
\r
59 References: <1455112878-23497-1-git-send-email-dme@dme.org>
\r
60 <1455112878-23497-2-git-send-email-dme@dme.org> <87oabo5rix.fsf@qmul.ac.uk>
\r
61 <m260xw2vim.fsf@dme.org>
\r
62 User-Agent: Notmuch/0.18.1+485~gca076ce (http://notmuchmail.org) Emacs/24.4.1
\r
63 (x86_64-pc-linux-gnu)
\r
64 Date: Wed, 10 Feb 2016 21:05:25 +0000
\r
65 Message-ID: <87lh6s5l9m.fsf@qmul.ac.uk>
\r
67 Content-Type: text/plain
\r
68 X-BeenThere: notmuch@notmuchmail.org
\r
69 X-Mailman-Version: 2.1.20
\r
71 List-Id: "Use and development of the notmuch mail system."
\r
72 <notmuch.notmuchmail.org>
\r
73 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
74 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
75 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
76 List-Post: <mailto:notmuch@notmuchmail.org>
\r
77 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
78 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
79 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
80 X-List-Received-Date: Wed, 10 Feb 2016 21:05:31 -0000
\r
83 On Wed, 10 Feb 2016, David Edmondson <dme@dme.org> wrote:
\r
84 > On Wed, Feb 10 2016, Mark Walters wrote:
\r
85 >> This basically looks fine to me and all tests pass. The code movement
\r
86 >> and cleanup all looks fine.
\r
90 >> Two minor things, one tiny nit below; and I wonder whether just having
\r
91 >> the buffer say "No search results" (or something similar) and leave
\r
92 >> the user to kill it would be nicer than dinging (and more in line with
\r
93 >> the way search and tree behave).
\r
95 >> [In some sense I think this way is right and search and tree are wrong,
\r
96 >> but that is probably difficult to get round as search and tree run
\r
99 > What if we did "notmuch count $query" first in the search and tree case,
\r
100 > and did the "(ding) (message ...)" thing if the count returned 0? (Just
\r
101 > wondering about whether having everything behave that way would be
\r
102 > possible and acceptable.)
\r
104 > The original impetus for this change was someone who hits an id: button
\r
105 > that is either a false match (i.e it wasn't ever intended to be a
\r
106 > notmuch reference) or for a message that they don't have. In both of
\r
107 > those cases popping up a buffer that says only "No match." would be
\r
108 > annoying. If we were considering the case where people are using "M-x
\r
109 > notmuch-show", it seems less clear on the right thing to do, but overall
\r
110 > I prefer this approach to the useless buffer that I have to kill/quit.
\r
113 I am quite happy to leave it as you have it with the ding; currently we
\r
114 have an obscure error message and this is obviously better so (with the
\r
115 comment change below) +1 from me.
\r
121 >>> + ;; Cache the original tags for each message so that we can display
\r
124 >> ^^ I think "Store the original tags for each message" would be better,
\r
125 >> particularly as this is nothing to do with the tag cache as used by say
\r
126 >> notmuch-tag-clear-cache.
\r