1 Return-Path: <aaronecay@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 14698421197
\r
6 for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 12:10:45 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id kyxQgSG1E6wv for <notmuch@notmuchmail.org>;
\r
17 Tue, 17 Jan 2012 12:10:44 -0800 (PST)
\r
18 Received: from mail-qw0-f46.google.com (mail-qw0-f46.google.com
\r
19 [209.85.216.46]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 82DB3421192
\r
22 for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 12:10:44 -0800 (PST)
\r
23 Received: by qadc10 with SMTP id c10so1216254qad.5
\r
24 for <notmuch@notmuchmail.org>; Tue, 17 Jan 2012 12:10:44 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=OkoAYgNPN0kKDcAhIsMKlu7ACzVOCTAvj1s11Mvjquk=;
\r
29 b=N+xPBIy2eaOYDlSfzhVG/xQDZsZQXw/zuryWn262v3TMZH9K3xFA7Eb/gRBMMyV/Qx
\r
30 oKKSljA0aEnaNp/PImpfbXmjmsZyZVOkDWKhXkzj7iROHGG9ce48q+LO5BnI0RxyC3aQ
\r
31 V1/sSZ4sFzuyoHOKmg2tX94RoFjVhtkdWGnGk=
\r
32 Received: by 10.229.135.9 with SMTP id l9mr6880686qct.66.1326831043956;
\r
33 Tue, 17 Jan 2012 12:10:43 -0800 (PST)
\r
34 Received: from localhost (luw017.wlan.gapsa.upenn.edu. [128.91.230.146])
\r
35 by mx.google.com with ESMTPS id m20sm45603617qaj.14.2012.01.17.12.10.42
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Tue, 17 Jan 2012 12:10:43 -0800 (PST)
\r
38 From: Aaron Ecay <aaronecay@gmail.com>
\r
39 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
40 Notmuch Mail <notmuch@notmuchmail.org>
\r
41 Subject: Re: [PATCH 1/6] emacs: break up notmuch-show-archive-thread-internal
\r
42 into two generally useful functions
\r
43 In-Reply-To: <1326823531-14549-1-git-send-email-jrollins@finestructure.net>
\r
44 References: <871uqy19yo.fsf@servo.finestructure.net>
\r
45 <1326823531-14549-1-git-send-email-jrollins@finestructure.net>
\r
46 User-Agent: Notmuch/0.11+62~ge41b0d3 (http://notmuchmail.org) Emacs/24.0.92.1
\r
47 (i386-apple-darwin10.8.0)
\r
48 Date: Tue, 17 Jan 2012 15:10:40 -0500
\r
49 Message-ID: <m2d3aiay4f.fsf@gmail.com>
\r
51 Content-Type: text/plain
\r
52 X-BeenThere: notmuch@notmuchmail.org
\r
53 X-Mailman-Version: 2.1.13
\r
55 List-Id: "Use and development of the notmuch mail system."
\r
56 <notmuch.notmuchmail.org>
\r
57 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
59 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
60 List-Post: <mailto:notmuch@notmuchmail.org>
\r
61 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
62 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
64 X-List-Received-Date: Tue, 17 Jan 2012 20:10:45 -0000
\r
66 On Tue, 17 Jan 2012 10:05:26 -0800, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
67 > Brake up notmuch-show-archive-thread-internal into two new functions:
\r
69 > notmuch-show-tag-thread-internal: applies a tag to all messages in
\r
70 > thread. If option remove flag is t, tags will be removed instead of
\r
73 > notmuch-show-next-thread: moves to the next thread in the search
\r
74 > result. If given a prefix, will show the next result, otherwise will
\r
75 > just move to it in the search view.
\r
77 > Two new interactive functions, notmuch-show-{add,remove}-tag-thread,
\r
78 > are also added. Together, these provide a better suit of thread
\r
79 > tagging and navigation tools.
\r
81 > The higher level thread archiving functions are modified to use these
\r
84 > emacs/notmuch-show.el | 33 ++++++++++++++++++++++++++-------
\r
85 > 1 files changed, 26 insertions(+), 7 deletions(-)
\r
87 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
88 > index 03c1f6b..3625afd 100644
\r
89 > --- a/emacs/notmuch-show.el
\r
90 > +++ b/emacs/notmuch-show.el
\r
91 > @@ -1421,12 +1421,29 @@ argument, hide all of the messages."
\r
93 > (backward-button 1))
\r
95 > -(defun notmuch-show-archive-thread-internal (show-next)
\r
96 > - ;; Remove the tag from the current set of messages.
\r
97 > +(defun notmuch-show-tag-thread-internal (tag &optional remove)
\r
98 > + ;; Add tag to the current set of messages. If the remove switch is
\r
99 > + ;; given, tags will be removed instead of added.
\r
101 This should be a docstring instead of a comment. (This applies equally
\r
102 to the old version....)
\r