1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 17A1E431FB6
\r
6 for <notmuch@notmuchmail.org>; Sat, 28 Jan 2012 14:49:24 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id tTG+WEhRcTK0 for <notmuch@notmuchmail.org>;
\r
17 Sat, 28 Jan 2012 14:49:23 -0800 (PST)
\r
18 Received: from mail-bk0-f53.google.com (mail-bk0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 4CD93431FAE
\r
22 for <notmuch@notmuchmail.org>; Sat, 28 Jan 2012 14:49:23 -0800 (PST)
\r
23 Received: by bke11 with SMTP id 11so313138bke.26
\r
24 for <notmuch@notmuchmail.org>; Sat, 28 Jan 2012 14:49:21 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=USwfWTuF3WvwyKDMIdj4yl2xbuXWN/nC0yCw2VLYIl0=;
\r
29 b=jDz7JT7ZfEx2wVh2MGRvO/BGxW57n7BbCeLohf1tpZTWlUYfsCqw8+k8CvzpDM3+xE
\r
30 8YRMs8bBH/424iCFVThBlDQH2BaNKPRJX71XPXtsErcbLaVFsNvWl1iARtYqh/PNKuNw
\r
31 FOWxlMA4lioKy90lx+nCRDRyQswQcnZSdqcK4=
\r
32 Received: by 10.205.130.12 with SMTP id hk12mr5654469bkc.56.1327790961812;
\r
33 Sat, 28 Jan 2012 14:49:21 -0800 (PST)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id bw9sm26076852bkb.8.2012.01.28.14.49.20
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Sat, 28 Jan 2012 14:49:21 -0800 (PST)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Daniel Schoepe <daniel@schoepe.org>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH v7 2/2] emacs: Tests for user-defined sections
\r
41 In-Reply-To: <87ehujqzu6.fsf@schoepe.localhost>
\r
42 References: <87d3ac8ta9.fsf@schoepe.localhost>
\r
43 <1327193689-6011-1-git-send-email-daniel@schoepe.org>
\r
44 <1327193689-6011-2-git-send-email-daniel@schoepe.org>
\r
45 <87y5sym31d.fsf@gmail.com> <87ehujqzu6.fsf@schoepe.localhost>
\r
46 User-Agent: Notmuch/0.11+134~g7ddba9d (http://notmuchmail.org) Emacs/23.3.1
\r
47 (x86_64-pc-linux-gnu)
\r
48 Date: Sun, 29 Jan 2012 02:48:12 +0400
\r
49 Message-ID: <87ipjv8mvn.fsf@gmail.com>
\r
51 Content-Type: text/plain; charset=us-ascii
\r
52 X-BeenThere: notmuch@notmuchmail.org
\r
53 X-Mailman-Version: 2.1.13
\r
55 List-Id: "Use and development of the notmuch mail system."
\r
56 <notmuch.notmuchmail.org>
\r
57 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
59 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
60 List-Post: <mailto:notmuch@notmuchmail.org>
\r
61 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
62 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
64 X-List-Received-Date: Sat, 28 Jan 2012 22:49:24 -0000
\r
68 On Sat, 28 Jan 2012 22:30:57 +0100, Daniel Schoepe <daniel@schoepe.org> wrote:
\r
71 > On Tue, 24 Jan 2012 03:07, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
72 > > There are some trailing whitespaces in the tests.
\r
74 > those are also produced by the various notmuch-hello functions, and are
\r
75 > also in the existing tests. If someone is bothered by this, it should be
\r
76 > fixed in a separate patch.
\r
79 I only meant trailing whitespaces in test/emacs file in the lines added
\r
80 by the patch. Trailing whitespaces in expected results are obviously
\r
84 > > Also, please consider moving the hello sections tests to a separate file
\r
85 > > (emacs-hello-sections, perhaps?). I am worried that test/emacs file
\r
86 > > becomes too big. And we will probably add more notmuch-hello
\r
87 > > section-related tests in the future.
\r
89 > I think it's better to split it up into more than just
\r
90 > emacs-hello-sections and emacs, as there are also quite a few tests
\r
91 > relating solely to, e.g., -show or -search.
\r
94 I think splitting emacs tests based on -hello, -show and -search views
\r
95 is a good idea. Splitting existing tests is out of scope of this
\r
96 patch. But I think it may be a good opportunity to add a new file with
\r
99 > Anyhow, I'll send another rebased version fixing conflicts with the
\r
100 > search-interface changes.
\r
103 Thanks, I will try to review it soon.
\r