1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E7526431FB6
\r
6 for <notmuch@notmuchmail.org>; Mon, 13 Aug 2012 08:16:17 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id 8deIaSaNQN0q for <notmuch@notmuchmail.org>;
\r
16 Mon, 13 Aug 2012 08:16:17 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-5.mit.edu (DMZ-MAILSEC-SCANNER-5.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 63048431FAE
\r
20 for <notmuch@notmuchmail.org>; Mon, 13 Aug 2012 08:16:17 -0700 (PDT)
\r
21 X-AuditID: 12074422-b7f1f6d00000090b-a0-50291a408d66
\r
22 Received: from mailhub-auth-4.mit.edu ( [18.7.62.39])
\r
23 by dmz-mailsec-scanner-5.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 05.02.02315.04A19205; Mon, 13 Aug 2012 11:16:16 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-4.mit.edu (8.13.8/8.9.2) with ESMTP id q7DFGFj6002248;
\r
27 Mon, 13 Aug 2012 11:16:16 -0400
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q7DFGD5Q007553
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Mon, 13 Aug 2012 11:16:14 -0400 (EDT)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1T0wNJ-0001FB-No; Mon, 13 Aug 2012 11:16:13 -0400
\r
37 Date: Mon, 13 Aug 2012 11:16:13 -0400
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Tomi Ollila <tomi.ollila@iki.fi>
\r
40 Subject: Re: [PATCH 2/2] test: emacs: run list-processes after
\r
41 accept-process-output in emacs 23.1
\r
42 Message-ID: <20120813151613.GN11179@mit.edu>
\r
43 References: <1344165182-29246-1-git-send-email-tomi.ollila@iki.fi>
\r
44 <1344165182-29246-2-git-send-email-tomi.ollila@iki.fi>
\r
46 Content-Type: text/plain; charset=us-ascii
\r
47 Content-Disposition: inline
\r
48 In-Reply-To: <1344165182-29246-2-git-send-email-tomi.ollila@iki.fi>
\r
49 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
50 X-Brightmail-Tracker:
\r
51 H4sIAAAAAAAAA+NgFmpgleLIzCtJLcpLzFFi42IRYrdT13WQ0gwwmLzPxOL6zZnMFm9WzmN1
\r
52 YPI4/HUhi8ezVbeYA5iiuGxSUnMyy1KL9O0SuDLOfJ/BWPCHt6LvQyNTA+MC7i5GDg4JAROJ
\r
53 97Pcuhg5gUwxiQv31rOB2EIC+xglpu4N6WLkArI3MEpc/P2GGcI5ySTxsrGNEcJZwijxevsq
\r
54 FpBJLAKqEt2fk0C62QQ0JLbtX84IYosIqEg8aFvPCmIzC0hLfPvdzARiCwukSPS3z2AFaeUV
\r
55 0JHY878WYnG1xOmnB5lBbF4BQYmTM5+wQLRqSdz495IJpBxkzPJ/HCBhTgFnic87m8GmiwJt
\r
56 mnJyG9sERqFZSLpnIemehdC9gJF5FaNsSm6Vbm5iZk5xarJucXJiXl5qka6pXm5miV5qSukm
\r
57 RnBAuyjtYPx5UOkQowAHoxIP7yU7jQAh1sSy4srcQ4ySHExKorxcEpoBQnxJ+SmVGYnFGfFF
\r
58 pTmpxYcYJTiYlUR4JU4BlfOmJFZWpRblw6SkOViUxHmvpdz0FxJITyxJzU5NLUgtgsnKcHAo
\r
59 SfC+kgQaKliUmp5akZaZU4KQZuLgBBnOAzT8NUgNb3FBYm5xZjpE/hSjopQ4722QhABIIqM0
\r
60 D64XlnBeMYoDvSLM2wFSxQNMVnDdr4AGMwEN/s6hBjK4JBEhJdXAGPz5y6/LBk6iM8T6NZbN
\r
61 tHb/bG8qq3Gh/7ROpcpct6w3B29m3DKLF8p16LluyzVn1dTm6/565X8mvIv52mdht2hzr7Ja
\r
62 SmjAnx7Fp9vC4sLsvk65r7h7r1jkNEPJnWmGJ4yX+e9fUsh07rt+52uRLXOM2JacFe5mWvV4
\r
63 01vTSwKTV0ZPswtxUmIpzkg01GIuKk4EAJzuXHMTAwAA
\r
64 Cc: notmuch@notmuchmail.org
\r
65 X-BeenThere: notmuch@notmuchmail.org
\r
66 X-Mailman-Version: 2.1.13
\r
68 List-Id: "Use and development of the notmuch mail system."
\r
69 <notmuch.notmuchmail.org>
\r
70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
71 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
73 List-Post: <mailto:notmuch@notmuchmail.org>
\r
74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
76 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
77 X-List-Received-Date: Mon, 13 Aug 2012 15:16:18 -0000
\r
79 Quoth Tomi Ollila on Aug 05 at 2:13 pm:
\r
80 > When running emacs tests using emacs 23.1.1 the tests block (until timeout)
\r
81 > when emacs function (notmuch-test-wait) is called.
\r
83 > There is an emacs bug #2930 titled:
\r
84 > 23.0.92; `accept-process-output' and `sleep-for' do not run sentinel
\r
86 > It seems this is present in emacs 23.1.
\r
88 > Calling list-processes after accept-process-output seems work around
\r
89 > this problem; in case Emacs version is 23.1 a defadvice is activated
\r
92 Should this workaround perhaps go in notmuch-test-wait directly,
\r
93 instead of being implemented as advice? If we do want to keep it as
\r
94 advice, should it go in notmuch-lib.el along with the few other
\r
95 compatibility functions?
\r
99 > Thanks to Austin for the comments and IRC discussions on the matter.
\r
101 > test/test-lib.el | 8 ++++++++
\r
102 > 1 files changed, 8 insertions(+), 0 deletions(-)
\r
104 > diff --git a/test/test-lib.el b/test/test-lib.el
\r
105 > index 52d9936..4330352 100644
\r
106 > --- a/test/test-lib.el
\r
107 > +++ b/test/test-lib.el
\r
108 > @@ -35,6 +35,16 @@
\r
109 > "Disable yes-or-no-p before executing kill-emacs"
\r
110 > (defun yes-or-no-p (prompt) t)))
\r
112 > +;; Emacs bug #2930:
\r
113 > +;; 23.0.92; `accept-process-output' and `sleep-for' do not run sentinels
\r
114 > +;; seems to be present in Emacs 23.1.
\r
115 > +;; Running `list-processes' after `accept-process-output' seems to work
\r
116 > +;; around this problem.
\r
117 > +(if (and (= emacs-major-version 23) (= emacs-minor-version 1))
\r
118 > + (defadvice accept-process-output (after run-list-processes activate)
\r
119 > + "run list-processes after executing accept-process-output"
\r
120 > + (list-processes)))
\r
122 > (defun notmuch-test-wait ()
\r
123 > "Wait for process completion."
\r
124 > (while (get-buffer-process (current-buffer))
\r