1 Return-Path: <bremner@unb.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 7467F431FB6
\r
6 for <notmuch@notmuchmail.org>; Sun, 2 Sep 2012 08:51:17 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id ufYernDCprE0 for <notmuch@notmuchmail.org>;
\r
16 Sun, 2 Sep 2012 08:51:17 -0700 (PDT)
\r
17 Received: from tesseract.cs.unb.ca (tesseract.cs.unb.ca [131.202.240.238])
\r
18 (using TLSv1 with cipher AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 0068E431FAF
\r
21 for <notmuch@notmuchmail.org>; Sun, 2 Sep 2012 08:51:16 -0700 (PDT)
\r
22 Received: from fctnnbsc30w-156034089108.dhcp-dynamic.fibreop.nb.bellaliant.net
\r
23 ([156.34.89.108] helo=zancas.localnet)
\r
24 by tesseract.cs.unb.ca with esmtpsa
\r
25 (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72)
\r
26 (envelope-from <bremner@unb.ca>)
\r
27 id 1T8CSB-0008FC-EX; Sun, 02 Sep 2012 12:51:15 -0300
\r
28 Received: from bremner by zancas.localnet with local (Exim 4.80)
\r
29 (envelope-from <bremner@unb.ca>)
\r
30 id 1T8CS5-0008Cf-TE; Sun, 02 Sep 2012 12:51:09 -0300
\r
31 From: David Bremner <david@tethera.net>
\r
32 To: Mark Walters <markwalters1009@gmail.com>
\r
33 Subject: Re: [PATCH v2 (Draft)] emacs: split async json parser into utility
\r
35 In-Reply-To: <87k3xlyoek.fsf@qmul.ac.uk>
\r
36 References: <87k3xo85tv.fsf@qmul.ac.uk> <20120730013506.GF8502@mit.edu>
\r
37 <87obmxyokt.fsf@qmul.ac.uk> <87k3xlyoek.fsf@qmul.ac.uk>
\r
38 User-Agent: Notmuch/0.14 (http://notmuchmail.org) Emacs/24.1.1
\r
39 (x86_64-pc-linux-gnu)
\r
40 Date: Sun, 02 Sep 2012 12:51:09 -0300
\r
41 Message-ID: <87vcfw779u.fsf@zancas.localnet>
\r
43 Content-Type: text/plain
\r
45 Cc: notmuch@notmuchmail.org
\r
46 X-BeenThere: notmuch@notmuchmail.org
\r
47 X-Mailman-Version: 2.1.13
\r
49 List-Id: "Use and development of the notmuch mail system."
\r
50 <notmuch.notmuchmail.org>
\r
51 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
52 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
53 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
54 List-Post: <mailto:notmuch@notmuchmail.org>
\r
55 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
56 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
57 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
58 X-List-Received-Date: Sun, 02 Sep 2012 15:51:17 -0000
\r
60 Mark Walters <markwalters1009@gmail.com> writes:
\r
62 > Split out the json parser into a utility function.
\r
65 > Most of this patch is code movement: but I don't see how to arrange the
\r
66 > patch to show that.
\r
69 "git gui blame notmuch.el" gives some clues, although it isn't perfect.
\r
70 Maybe you could explain in the commit message what is _not_ code
\r
73 > +(defvar notmuch-json-parser nil
\r
74 > + "Incremental JSON parser.")
\r
76 This docstring needs expanding. I suppose that this is for internal use,
\r
77 but it isn't clear from the docstring.
\r