1 Return-Path: <bremner@unb.ca>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 8C5A0431FD0
\r
6 for <notmuch@notmuchmail.org>; Fri, 26 Aug 2011 05:46:32 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id YfNCxh-ty3aJ for <notmuch@notmuchmail.org>;
\r
16 Fri, 26 Aug 2011 05:46:32 -0700 (PDT)
\r
17 Received: from tempo.its.unb.ca (tempo.its.unb.ca [131.202.1.21])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 11F19431FB6
\r
21 for <notmuch@notmuchmail.org>; Fri, 26 Aug 2011 05:46:31 -0700 (PDT)
\r
22 Received: from zancas.localnet
\r
23 (fctnnbsc36w-156034065066.pppoe-dynamic.High-Speed.nb.bellaliant.net
\r
24 [156.34.65.66]) (authenticated bits=0)
\r
25 by tempo.its.unb.ca (8.13.8/8.13.8) with ESMTP id p7QCkROg010388
\r
26 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NO);
\r
27 Fri, 26 Aug 2011 09:46:28 -0300
\r
28 Received: from bremner by zancas.localnet with local (Exim 4.76)
\r
29 (envelope-from <bremner@unb.ca>)
\r
30 id 1Qwvnn-0002nD-8k; Fri, 26 Aug 2011 09:46:27 -0300
\r
31 From: David Bremner <david@tethera.net>
\r
32 To: richardmurri@gmail.com, notmuch@notmuchmail.org
\r
33 Subject: Re: Fix for emacs 24
\r
34 In-Reply-To: <877h6x6oor.fsf@veracitynetworks.com>
\r
35 References: <877h6x6oor.fsf@veracitynetworks.com>
\r
36 User-Agent: Notmuch/0.7 (http://notmuchmail.org) Emacs/23.3.1
\r
37 (x86_64-pc-linux-gnu)
\r
38 Date: Fri, 26 Aug 2011 09:46:27 -0300
\r
39 Message-ID: <878vqgz6fw.fsf@zancas.localnet>
\r
41 Content-Type: text/plain; charset=us-ascii
\r
42 X-BeenThere: notmuch@notmuchmail.org
\r
43 X-Mailman-Version: 2.1.13
\r
45 List-Id: "Use and development of the notmuch mail system."
\r
46 <notmuch.notmuchmail.org>
\r
47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
48 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
50 List-Post: <mailto:notmuch@notmuchmail.org>
\r
51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
53 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
54 X-List-Received-Date: Fri, 26 Aug 2011 12:46:32 -0000
\r
56 On Mon, 01 Aug 2011 11:12:36 -0600, richardmurri@gmail.com wrote:
\r
57 > Emacs added another parameter to the send mail functions. This caused
\r
58 > emacs to error out.
\r
60 > (defun notmuch-mua-mail (&optional to subject other-headers continue
\r
61 > - switch-function yank-action send-actions)
\r
62 > + switch-function yank-action send-actions
\r
65 Thanks for sending a patch. I'm sure we need lots of help to get notmuch
\r
66 working well with emacs24. Some comments about your patch
\r
68 - It would be nice to have a bit more informative single line summary to
\r
71 - I don't really understand from the long commit message what problem
\r
72 this fixes. I take it some function outside of notmuch is calling
\r
75 - The convention on the notmuch list is to use "git send-email" if you
\r
76 can. This makes it easier to apply patches. Any discussion not meant
\r
77 to be part of the commit message can go after the --- at the end of the
\r
78 commit message (and I admit that isn't very obvious).
\r
80 Thanks again, and welcome to the team ;)
\r