48/9b781ba0ee2152bb4733c3bd8befc59c1d7d27

   1 Return-Path: <david@tethera.net>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5  by arlo.cworth.org (Postfix) with ESMTP id 9B7A16DE028C\r
   6  for <notmuch@notmuchmail.org>; Sat,  9 Apr 2016 04:31:57 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at cworth.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.019\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.019 tagged_above=-999 required=5\r
  12  tests=[AWL=-0.008, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01]\r
  13  autolearn=disabled\r
  14 Received: from arlo.cworth.org ([127.0.0.1])\r
  15  by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16  with ESMTP id 931waPqS2z_R for <notmuch@notmuchmail.org>;\r
  17  Sat,  9 Apr 2016 04:31:49 -0700 (PDT)\r
  18 Received: from fethera.tethera.net (fethera.tethera.net [198.245.60.197])\r
  19  by arlo.cworth.org (Postfix) with ESMTPS id A16DB6DE0173\r
  20  for <notmuch@notmuchmail.org>; Sat,  9 Apr 2016 04:31:49 -0700 (PDT)\r
  21 Received: from remotemail by fethera.tethera.net with local (Exim 4.84)\r
  22  (envelope-from <david@tethera.net>)\r
  23  id 1aor7O-0000SI-JO; Sat, 09 Apr 2016 07:31:58 -0400\r
  24 Received: (nullmailer pid 24373 invoked by uid 1000);\r
  25  Sat, 09 Apr 2016 11:31:47 -0000\r
  26 From: David Bremner <david@tethera.net>\r
  27 To: Daniel Kahn Gillmor <dkg@fifthhorseman.net>,\r
  28  Notmuch Mail <notmuch@notmuchmail.org>\r
  29 Subject: Re: [PATCH v4 7/7] complete\r
  30  ghost-on-removal-when-shared-thread-exists\r
  31 In-Reply-To: <1460166892-29721-7-git-send-email-dkg@fifthhorseman.net>\r
  32 References: <1459445693-3900-1-git-send-email-dkg@fifthhorseman.net>\r
  33  <1460166892-29721-1-git-send-email-dkg@fifthhorseman.net>\r
  34  <1460166892-29721-7-git-send-email-dkg@fifthhorseman.net>\r
  35 User-Agent: Notmuch/0.21+99~gd93d377 (http://notmuchmail.org) Emacs/24.5.1\r
  36  (x86_64-pc-linux-gnu)\r
  37 Date: Sat, 09 Apr 2016 08:31:47 -0300\r
  38 Message-ID: <871t6f3tng.fsf@zancas.localnet>\r
  39 MIME-Version: 1.0\r
  40 Content-Type: text/plain\r
  41 X-BeenThere: notmuch@notmuchmail.org\r
  42 X-Mailman-Version: 2.1.20\r
  43 Precedence: list\r
  44 List-Id: "Use and development of the notmuch mail system."\r
  45  <notmuch.notmuchmail.org>\r
  46 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,\r
  47  <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  48 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>\r
  49 List-Post: <mailto:notmuch@notmuchmail.org>\r
  50 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  51 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,\r
  52  <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  53 X-List-Received-Date: Sat, 09 Apr 2016 11:31:57 -0000\r
  54 \r
  55 Daniel Kahn Gillmor <dkg@fifthhorseman.net> writes:\r
  56 \r
  57 \r
  58 > +             status = _notmuch_message_delete (message);\r
  59 > +             if (status) /* we'll report the last failure we see;\r
  60 > +                          * if there is more than one failure, we\r
  61 > +                          * forget about previous ones */\r
  62 > +                 last_error = status;\r
  63 \r
  64 I was initially worried/paranoid that there might be some risk of data\r
  65 loss by continuing deleting after the first bad status; that doesn't\r
  66 seem to be the case, but there doesn't seem to be much advantage in\r
  67 continuing either, since the only error currently returned from\r
  68 _notmuch_message_delete is from _notmuch_database_ensure_writable, which\r
  69 seems likely to persist.  So perhaps exiting the loop on the first error\r
  70 might be less confusing.\r
  71 \r
  72 Other than that, and my bug in ghost-report, the series looks good to\r
  73 me.\r
  74 \r
  75 d\r
  76 \r