1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 293B0431FBC
\r
6 for <notmuch@notmuchmail.org>; Mon, 3 Dec 2012 08:47:37 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id MVHHrjhI-qm8 for <notmuch@notmuchmail.org>;
\r
16 Mon, 3 Dec 2012 08:47:36 -0800 (PST)
\r
17 Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU
\r
19 by olra.theworths.org (Postfix) with ESMTP id 8E324431FB6
\r
20 for <notmuch@notmuchmail.org>; Mon, 3 Dec 2012 08:47:36 -0800 (PST)
\r
21 X-AuditID: 12074423-b7fcb6d000000927-25-50bcd7a791a2
\r
22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])
\r
23 by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id 54.94.02343.7A7DCB05; Mon, 3 Dec 2012 11:47:35 -0500 (EST)
\r
25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])
\r
26 by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id qB3GlYiU029477;
\r
27 Mon, 3 Dec 2012 11:47:35 -0500
\r
28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id qB3GlVU3009563
\r
32 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES128-SHA bits=128 verify=NOT);
\r
33 Mon, 3 Dec 2012 11:47:33 -0500 (EST)
\r
34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.80)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1TfZB4-0002U9-QR; Mon, 03 Dec 2012 11:47:30 -0500
\r
37 Date: Mon, 3 Dec 2012 11:47:30 -0500
\r
38 From: Austin Clements <amdragon@MIT.EDU>
\r
39 To: Mark Walters <markwalters1009@gmail.com>
\r
40 Subject: Re: [PATCH] emacs: show: refresh buffer did not remove overlays
\r
41 Message-ID: <20121203164730.GE1020@mit.edu>
\r
42 References: <1354540260-21814-1-git-send-email-markwalters1009@gmail.com>
\r
44 Content-Type: text/plain; charset=us-ascii
\r
45 Content-Disposition: inline
\r
46 In-Reply-To: <1354540260-21814-1-git-send-email-markwalters1009@gmail.com>
\r
47 User-Agent: Mutt/1.5.21 (2010-09-15)
\r
48 X-Brightmail-Tracker:
\r
49 H4sIAAAAAAAAA+NgFmpkleLIzCtJLcpLzFFi42IR4hRV1l1+fU+AwdRP/Bar5/JYXL85k9mB
\r
50 yWPnrLvsHs9W3WIOYIrisklJzcksSy3St0vgyli9JbHgmXDFnJ1b2BoYb/N3MXJySAiYSDze
\r
51 0csOYYtJXLi3nq2LkYtDSGAfo8SPWc+ZIZz1jBLTG6azglQJCVxgkmju04dILGGU6Fswnxkk
\r
52 wSKgIvHs4WGwUWwCGhLb9i9nBLFFBHQkbh9aABZnFpCW+Pa7mQnEFhbwkJh/pIUNxOYV0JZY
\r
53 MncxE8QCT4nbW3exQMQFJU7OfMIC0aslcePfS6AaDrA5y/9xgIQ5BbwkHnasBVslCnTClJPb
\r
54 2CYwCs1C0j0LSfcshO4FjMyrGGVTcqt0cxMzc4pTk3WLkxPz8lKLdM30cjNL9FJTSjcxgkKa
\r
55 3UV5B+Ofg0qHGAU4GJV4eB982R0gxJpYVlyZe4hRkoNJSZT3+Zk9AUJ8SfkplRmJxRnxRaU5
\r
56 qcWHGCU4mJVEeHduBMrxpiRWVqUW5cOkpDlYlMR5r6Xc9BcSSE8sSc1OTS1ILYLJynBwKEnw
\r
57 tl4DahQsSk1PrUjLzClBSDNxcIIM5wEa/uQqyPDigsTc4sx0iPwpRkUpcd6DIAkBkERGaR5c
\r
58 LyzlvGIUB3pFmPcYSBUPMF3Bdb8CGswENPiF0G6QwSWJCCmpBkbuG2bnVsyYvKFr3+Hdp3I2
\r
59 z69evr6gcCn7hOspLXnbPqpbaHolBqs1h7x/HNYoeqyqWXfihJfHGuc3NJdfDWd6xyj+0Xra
\r
60 udjNh58/m+VgfTsm6V/3y1/Pb2/byRT/JbCeI1ZQUsBS8KuV8z1nG5d5f36ciSstf61mev3Q
\r
61 ncZ38/e5POlZYhWtxFKckWioxVxUnAgACfehuBQDAAA=
\r
62 Cc: notmuch@notmuchmail.org
\r
63 X-BeenThere: notmuch@notmuchmail.org
\r
64 X-Mailman-Version: 2.1.13
\r
66 List-Id: "Use and development of the notmuch mail system."
\r
67 <notmuch.notmuchmail.org>
\r
68 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
70 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
71 List-Post: <mailto:notmuch@notmuchmail.org>
\r
72 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
73 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
74 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
75 X-List-Received-Date: Mon, 03 Dec 2012 16:47:37 -0000
\r
77 Quoth Mark Walters on Dec 03 at 1:11 pm:
\r
78 > Previously refreshing the notmuch show buffer did not remove overlays
\r
79 > which meant that if the user refreshed a message with images the
\r
80 > images would remain and then the new text was added after.
\r
82 > One might have guessed that erase-buffer would have removed them but
\r
83 > it seems not. Thus force the removal of overlays with remove-overlay.
\r
85 > The new toggle-parts code makes this bug much more likely to trigger
\r
86 > (as the user is quite likely to toggle a part in a message with an
\r
87 > image). However, it was already present if anyone tried refreshing a
\r
88 > show buffer with an image in it.
\r
90 > It would be good if someone could check whether there is anything else
\r
91 > that also needs to be manually removed. But, for me at least, this
\r
92 > seems to fix the problem.
\r
94 > Many thanks to Jani for finding the bug and helping with the diagnosis.
\r
96 >From the source for erase-buffer it's clear that it is not intended to
\r
97 delete non-evaporating overlays (and overlays are non-evaporating by
\r
100 AFAIK, the only other things that stick around are buffer-local
\r
101 variables (which we clear in notmuch-show-refresh-view ->
\r
102 notmuch-show-build-buffer -> notmuch-show-mode) and markers.
\r
111 > emacs/notmuch-show.el | 3 +++
\r
112 > 1 files changed, 3 insertions(+), 0 deletions(-)
\r
114 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
115 > index c8c1657..e89dba2 100644
\r
116 > --- a/emacs/notmuch-show.el
\r
117 > +++ b/emacs/notmuch-show.el
\r
118 > @@ -1214,6 +1214,9 @@ reset based on the original query."
\r
119 > (setq notmuch-show-message-multipart/alternative-display-parts nil)
\r
120 > (notmuch-show-capture-state))))
\r
123 This isn't exactly related to your patch, but it looks like
\r
124 notmuch-show-build-buffer also calls erase-buffer, so I wonder if this
\r
127 > + ;; erase-buffer does not seem to remove overlays so do it manually.
\r
128 > + ;; This can lead to weird effects such as remaining images.
\r
130 I parse this as "Doing this manually can lead to weird effects...".
\r
133 erase-buffer does not seem to remove overlays, which can lead to weird
\r
134 effects such as remaining images, so remove them manually.
\r
138 > + (remove-overlays)
\r
140 For performance, it's probably slightly better to do this before the
\r
141 erase-buffer so that erase-buffer doesn't have to shift around the
\r
144 > (notmuch-show-build-buffer)
\r
146 > (notmuch-show-apply-state state)
\r