1 Return-Path: <markwalters1009@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 01FAB6DE17AC
\r
6 for <notmuch@notmuchmail.org>; Tue, 9 Feb 2016 13:04:26 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-0.219 tagged_above=-999 required=5 tests=[AWL=0.351,
\r
12 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7,
\r
14 RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001]
\r
16 Received: from arlo.cworth.org ([127.0.0.1])
\r
17 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
18 with ESMTP id ujzQ2zQ6OYs2 for <notmuch@notmuchmail.org>;
\r
19 Tue, 9 Feb 2016 13:04:24 -0800 (PST)
\r
20 Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com
\r
21 [74.125.82.68]) by arlo.cworth.org (Postfix) with ESMTPS id DB3EA6DE17A4 for
\r
22 <notmuch@notmuchmail.org>; Tue, 9 Feb 2016 13:04:23 -0800 (PST)
\r
23 Received: by mail-wm0-f68.google.com with SMTP id p63so140143wmp.1
\r
24 for <notmuch@notmuchmail.org>; Tue, 09 Feb 2016 13:04:23 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=Yg/MNWf128V9TepUeMrAjzdAGBzj+0SJWDyGjSVQNAw=;
\r
29 b=sd+lZQl1eD9G3tRZxh3d6uakFUvLuUFRz5BbyS8OSTcCEvQ57z7DV4Q6tpgUYOu0mP
\r
30 mr8zuU10/IJS7osDGvmVi3pi25QouxygxVQRyOXsFGGuWS9opI0qGAMwlSQAVihdvEpx
\r
31 bag1ypboIPk+thjSRvLRm6DmE4/nHYUZkJ+KrYxXlCbc9s1eexyCZBAtRuylp2RbP6r+
\r
32 8NnUbFheuSJmcIlzCcI9Fxlp6xaBdq0bHFUO94m+m6L8XUURBAdAcTunhkmesM/QFxAc
\r
33 a0RkepNf+4bFlyARqgRbTr7CG7v/o/NXLIUF8riFNp96YeydZtt+IrIfEfhIoeJ3H4FX
\r
35 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
36 d=1e100.net; s=20130820;
\r
37 h=x-gm-message-state:from:to:subject:in-reply-to:references
\r
38 :user-agent:date:message-id:mime-version:content-type;
\r
39 bh=Yg/MNWf128V9TepUeMrAjzdAGBzj+0SJWDyGjSVQNAw=;
\r
40 b=hf/q47tDrHg8KQZaQesJLALhjMkr2e6AuHsF4K+5P6479qvWpj3do/PxYuGZHtDJZ2
\r
41 Tcpv4Tl9+nBW71dvmucWPeM7DLPnJKCUJa4kjzHvdPlwzZhI1aNC1xTBU3fL9qo5H/tu
\r
42 l6DYvPiBfBAftJkcgQ5MEHQ312YSfDZmLxBWQsN8e1qlS71BhJycm/LRKBpj0mm4wMW3
\r
43 +ZzvMqfUUQ3Xv9Rs4aUHXhkh5aXacT+JI2gTdEbDXRFaaegTbR0IylHvVPlfnrW8LSHV
\r
44 MEz2BMDOIWbrPJIlrfq5yj1rB9765CeYpdJ04iQd0tzxZAqBU2beji+lly5kvyTxtP9D
\r
47 AG10YOQUsQQTHktvQd9Uz91LMEsxKQHJs9odqZEIHcHZsOqtstMG4gxGOJeRUX3N5KUpMw==
\r
48 X-Received: by 10.194.62.179 with SMTP id z19mr5512753wjr.96.1455051862412;
\r
49 Tue, 09 Feb 2016 13:04:22 -0800 (PST)
\r
50 Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162])
\r
51 by smtp.gmail.com with ESMTPSA id gt7sm36463789wjc.1.2016.02.09.13.04.21
\r
52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
\r
53 Tue, 09 Feb 2016 13:04:21 -0800 (PST)
\r
54 From: Mark Walters <markwalters1009@gmail.com>
\r
55 To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
\r
56 Subject: Re: [PATCH v5 3/3] emacs: Bind filter in search to 'l'
\r
57 In-Reply-To: <m2io1x4oop.fsf@dme.org>
\r
58 References: <1434182890-8047-1-git-send-email-markwalters1009@gmail.com>
\r
59 <1434182890-8047-4-git-send-email-markwalters1009@gmail.com>
\r
60 <m2io1x4oop.fsf@dme.org>
\r
61 User-Agent: Notmuch/0.18.1+485~gca076ce (http://notmuchmail.org) Emacs/24.4.1
\r
62 (x86_64-pc-linux-gnu)
\r
63 Date: Tue, 09 Feb 2016 21:04:20 +0000
\r
64 Message-ID: <87wpqd61ez.fsf@qmul.ac.uk>
\r
66 Content-Type: text/plain
\r
67 X-BeenThere: notmuch@notmuchmail.org
\r
68 X-Mailman-Version: 2.1.20
\r
70 List-Id: "Use and development of the notmuch mail system."
\r
71 <notmuch.notmuchmail.org>
\r
72 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
74 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
75 List-Post: <mailto:notmuch@notmuchmail.org>
\r
76 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
77 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
78 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
79 X-List-Received-Date: Tue, 09 Feb 2016 21:04:26 -0000
\r
82 On Tue, 09 Feb 2016, David Edmondson <dme@dme.org> wrote:
\r
83 > On Sat, Jun 13 2015, Mark Walters wrote:
\r
84 >> Change the key binding for filter (or "limit") in search-mode. This
\r
85 >> gives consistency with the new filter in show-mode, and frees 'f' for
\r
86 >> forward-thread in the future.
\r
88 > Is there a conclusion on this change? The patch itself seems obviously
\r
89 > fine from a code perspective, at issue is more whether it's acceptable
\r
90 > to change the key binding.
\r
92 > The equivalent binding in notmuch-show mode is already "l", and I think
\r
93 > that it makes sense to be consistent (i.e. the change should be
\r
96 I broadly agree, particularly as it will free up f for forwarding a
\r
97 thread in search view (which is easy to do on top of
\r
98 id:1454931262-21362-1-git-send-email-dme@dme.org).
\r
100 It will be annoying in the short term to learn the change, but I don't
\r
101 see a way round that.
\r
112 >> emacs/notmuch.el | 4 ++--
\r
113 >> 1 file changed, 2 insertions(+), 2 deletions(-)
\r
115 >> diff --git a/emacs/notmuch.el b/emacs/notmuch.el
\r
116 >> index 6564816..06e3b94 100644
\r
117 >> --- a/emacs/notmuch.el
\r
118 >> +++ b/emacs/notmuch.el
\r
119 >> @@ -166,7 +166,7 @@ (defvar notmuch-search-mode-map
\r
120 >> (define-key map "o" 'notmuch-search-toggle-order)
\r
121 >> (define-key map "c" 'notmuch-search-stash-map)
\r
122 >> (define-key map "t" 'notmuch-search-filter-by-tag)
\r
123 >> - (define-key map "f" 'notmuch-search-filter)
\r
124 >> + (define-key map "l" 'notmuch-search-filter)
\r
125 >> (define-key map [mouse-1] 'notmuch-search-show-thread)
\r
126 >> (define-key map "*" 'notmuch-search-tag-all)
\r
127 >> (define-key map "a" 'notmuch-search-archive-thread)
\r
128 >> @@ -983,7 +983,7 @@ (defun notmuch-search-toggle-order ()
\r
129 >> (notmuch-search-refresh-view))
\r
131 >> (defun notmuch-search-filter (query)
\r
132 >> - "Filter the current search results based on an additional query string.
\r
133 >> + "Filter or LIMIT the current search results based on an additional query string.
\r
135 >> Runs a new search matching only messages that match both the
\r
136 >> current search results AND the additional query string provided."
\r