41/a2c57df37ccef2691cc1eb5302ec9fdf9f6050

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 66A08431FB6\r
   6         for <notmuch@notmuchmail.org>; Sun, 19 Feb 2012 09:27:36 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id fwktTYtHw1id for <notmuch@notmuchmail.org>;\r
  16         Sun, 19 Feb 2012 09:27:35 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU\r
  18         [18.7.68.35])\r
  19         by olra.theworths.org (Postfix) with ESMTP id B3F7B431FAE\r
  20         for <notmuch@notmuchmail.org>; Sun, 19 Feb 2012 09:27:35 -0800 (PST)\r
  21 X-AuditID: 12074423-b7f9c6d0000008c3-0c-4f4131072d6c\r
  22 Received: from mailhub-auth-3.mit.edu ( [18.9.21.43])\r
  23         by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id FD.06.02243.701314F4; Sun, 19 Feb 2012 12:27:35 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-3.mit.edu (8.13.8/8.9.2) with ESMTP id q1JHRYL3025989; \r
  27         Sun, 19 Feb 2012 12:27:34 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q1JHRWFC009074\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Sun, 19 Feb 2012 12:27:33 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1RzAW5-0007W5-Qu; Sun, 19 Feb 2012 12:25:41 -0500\r
  37 Date: Sun, 19 Feb 2012 12:25:41 -0500\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: Tomi Ollila <tomi.ollila@iki.fi>\r
  40 Subject: Re: [PATCH 0/3] Make notmuch-show-refresh-view retain state by\r
  41  default\r
  42 Message-ID: <20120219172541.GQ5991@mit.edu>\r
  43 References: <1329632533-16152-1-git-send-email-amdragon@mit.edu>\r
  44         <m2k43jw43j.fsf@guru.guru-group.fi>\r
  45 MIME-Version: 1.0\r
  46 Content-Type: text/plain; charset=us-ascii\r
  47 Content-Disposition: inline\r
  48 In-Reply-To: <m2k43jw43j.fsf@guru.guru-group.fi>\r
  49 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  50 X-Brightmail-Tracker:\r
  51  H4sIAAAAAAAAA+NgFupjleLIzCtJLcpLzFFi42IR4hTV1mU3dPQ32N7OZnH95kxmizcr57E6\r
  52         MHkc/rqQxePZqlvMAUxRXDYpqTmZZalF+nYJXBm35zxgLDjCUXHxhHkD4xu2LkZODgkBE4mH\r
  53         v49A2WISF+6tB7K5OIQE9jFKnO34xgLhbGCUePjmAyOEc5JJonH+UiYIZwmjxMlnTYwg/SwC\r
  54         qhJnNs5gBrHZBDQktu1fDhYXEVCReNC2nhXEZhaQlvj2u5kJxBYWCJSY934KO4jNK6Atcf7i\r
  55         HxYQW0ggTaKjeQkzRFxQ4uTMJywQvVoSN/69BOrlAJuz/B8HiMkpYCDxd0IJSIUo0KYpJ7ex\r
  56         TWAUmoWkeRaS5lkIzQsYmVcxyqbkVunmJmbmFKcm6xYnJ+blpRbpmunlZpbopaaUbmIEBTW7\r
  57         i/IOxj8HlQ4xCnAwKvHwSpU5+AuxJpYVV+YeYpTkYFIS5bUxcPQX4kvKT6nMSCzOiC8qzUkt\r
  58         PsQowcGsJMJbetPeX4g3JbGyKrUoHyYlzcGiJM6rofXOT0ggPbEkNTs1tSC1CCYrw8GhJMHr\r
  59         AzJUsCg1PbUiLTOnBCHNxMEJMpwHaLgeSA1vcUFibnFmOkT+FKMux8cDTy4wCrHk5eelSonz\r
  60         qoMUCYAUZZTmwc2BJaNXjOJAbwnzmoNU8QATGdykV0BLmICW8ArZgSwpSURISTUwCqclWrn7\r
  61         X3ZzM3S8n/KG31A5qXPD/ENrTt7L6d5gb3kocOefN3OObmh3besqXCzP//24V3V2wrqfbk7q\r
  62         aRK+vadqv08tVhCvnPNzt/I1ie3M0qcXCZYvmbl9dbKGdmqE7T62ZXu/X7WacCrWdvP5vtaL\r
  63         4c8EXNn3f/55NGLL1NVb5DfYXn6eqsRSnJFoqMVcVJwIAFzbWl0hAwAA\r
  64 Cc: notmuch@notmuchmail.org\r
  65 X-BeenThere: notmuch@notmuchmail.org\r
  66 X-Mailman-Version: 2.1.13\r
  67 Precedence: list\r
  68 List-Id: "Use and development of the notmuch mail system."\r
  69         <notmuch.notmuchmail.org>\r
  70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  71         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  73 List-Post: <mailto:notmuch@notmuchmail.org>\r
  74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  76         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  77 X-List-Received-Date: Sun, 19 Feb 2012 17:27:36 -0000\r
  78 \r
  79 Quoth Tomi Ollila on Feb 19 at 11:43 am:\r
  80 > On Sun, 19 Feb 2012 01:22:10 -0500, Austin Clements <amdragon@MIT.EDU> wrote:\r
  81 > > Based on the thread at id:"20120213152858.GO27039@mit.edu" it seems\r
  82 > > like people want show refresh to retain message state by default (I\r
  83 > > certainly do), rather than reset it by default.  As a nice bonus, this\r
  84 > > fixes a broken test.\r
  85 > \r
  86 > Hmm\r
  87 > \r
  88 > Every '=' keypress in a thread removes 'unread' tag from next unread \r
  89 > message :o\r
  90 \r
  91 Oh dear.  It's slightly subtler than that, though.  Refreshing will\r
  92 remove the unread tag from the first message matching the query.  (I\r
  93 suspect you had tag:unread in your query?)  This is particularly\r
  94 confusing for state-retaining refresh because that message might not\r
  95 even be open.\r
  96 \r
  97 > That is probably desirable feature when refreshing view without\r
  98 > retaining state. Also, probably notmuch-show-refresh-view should\r
  99 > be fixed not to mark next message unread when retaining state ?\r
 100 \r
 101 I would argue that refresh should never have side-effects, so neither\r
 102 case should mark anything read.  I'll send a v2.\r