1 Return-Path: <blakej@foo.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 3A231431FC0
\r
6 for <notmuch@notmuchmail.org>; Mon, 5 Nov 2012 10:36:14 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id f8-G5VSUuj9Q for <notmuch@notmuchmail.org>;
\r
16 Mon, 5 Nov 2012 10:36:13 -0800 (PST)
\r
17 Received: from foo.net (70-36-235-136.dsl.static.sonic.net [70.36.235.136])
\r
18 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id BB3A3431FAE
\r
21 for <notmuch@notmuchmail.org>; Mon, 5 Nov 2012 10:36:13 -0800 (PST)
\r
22 Received: from foo.net (localhost [127.0.0.1])
\r
23 by foo.net (8.14.5+Sun/8.14.5) with ESMTP id qA5Ia8SG010910;
\r
24 Mon, 5 Nov 2012 10:36:08 -0800 (PST)
\r
25 To: Tomi Ollila <tomi.ollila@iki.fi>
\r
26 Subject: Re: [PATCH 00/10] Solaris support
\r
27 In-Reply-To: Your message of "Mon, 05 Nov 2012 19:43:08 +0200."
\r
28 <m2fw4oeyj7.fsf@guru.guru-group.fi>
\r
29 Date: Mon, 05 Nov 2012 10:36:08 -0800
\r
30 Message-ID: <10909.1352140568@foo.net>
\r
31 From: Blake Jones <blakej@foo.net>
\r
32 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-2.0.2
\r
33 (foo.net [127.0.0.1]); Mon, 05 Nov 2012 10:36:08 -0800 (PST)
\r
34 Cc: notmuch@notmuchmail.org
\r
35 X-BeenThere: notmuch@notmuchmail.org
\r
36 X-Mailman-Version: 2.1.13
\r
38 List-Id: "Use and development of the notmuch mail system."
\r
39 <notmuch.notmuchmail.org>
\r
40 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
41 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
42 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
43 List-Post: <mailto:notmuch@notmuchmail.org>
\r
44 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
45 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
47 X-List-Received-Date: Mon, 05 Nov 2012 18:36:14 -0000
\r
49 > Just now I don't have more time to comment and review more, but in the
\r
50 > first 2/3 patches when I tried to compile I got problem NULL not
\r
53 Oh! Yes, I should include <stdio.h> to pull in the definition of NULL.
\r
56 > Another thing: you have this
\r
58 > +# Whether the asctime_r function is standards-compliant
\r
59 > +# (if not, then notmuch will compile with -D_POSIX_PTHREAD_SEMANTICS
\r
60 > +# to enable the standards-compliant version -- needed for Solaris)
\r
62 > which is not exactly so.. you added the following lines in compat.h
\r
64 > +#if !STD_GETPWUID
\r
65 > +#define _POSIX_PTHREAD_SEMANTICS
\r
68 > which is slightly different as -D_POSIX_PTHREAD_SEMANTICS is equivalent to
\r
69 > #define _POSIX_PTHREAD_SEMANTICS 1
\r
71 > (you probably knew this and your comments have drifted from actual
\r
72 > implementation but just to make sure)
\r
74 I'll make the code and comment line up better.
\r
76 Thanks for your comments.
\r