1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 98619431FC3
\r
6 for <notmuch@notmuchmail.org>; Thu, 16 May 2013 05:01:19 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id L8Al97T2CiPT for <notmuch@notmuchmail.org>;
\r
16 Thu, 16 May 2013 05:01:14 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 68C68431FC2
\r
19 for <notmuch@notmuchmail.org>; Thu, 16 May 2013 05:01:14 -0700 (PDT)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id DFB07100094;
\r
22 Thu, 16 May 2013 15:01:10 +0300 (EEST)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, Jani Nikula <jani@nikula.org>,
\r
25 notmuch@notmuchmail.org
\r
26 Subject: Re: [PATCH] build: fix out-of-tree builds
\r
27 In-Reply-To: <87hai3dvkm.fsf@zancas.localnet>
\r
28 References: <1368615519-25977-1-git-send-email-jani@nikula.org>
\r
29 <87ehd8fdzg.fsf@zancas.localnet> <874ne49pcm.fsf@nikula.org>
\r
30 <87hai3dvkm.fsf@zancas.localnet>
\r
31 User-Agent: Notmuch/0.15.2+99~g7e455bc (http://notmuchmail.org) Emacs/24.3.1
\r
32 (x86_64-unknown-linux-gnu)
\r
33 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
34 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
35 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
36 Date: Thu, 16 May 2013 15:01:10 +0300
\r
37 Message-ID: <m2sj1n6smx.fsf@guru.guru-group.fi>
\r
39 Content-Type: text/plain
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Thu, 16 May 2013 12:01:19 -0000
\r
54 On Thu, May 16 2013, David Bremner <david@tethera.net> wrote:
\r
56 > Jani Nikula <jani@nikula.org> writes:
\r
58 >> On Wed, 15 May 2013, David Bremner <david@tethera.net> wrote:
\r
59 >>> Jani Nikula <jani@nikula.org> writes:
\r
60 >>>> # List all subdirectories here. Each contains its own Makefile.local
\r
61 >>>> -subdirs := compat completion emacs lib man parse-time-string
\r
62 >>>> -subdirs += performance-test util test
\r
63 >>>> +subdirs = compat completion emacs lib man parse-time-string performance-test util test
\r
65 >>> Is this a functional change or a cosmetic one?
\r
67 >> Functional. All of it seems to be required for out-of-tree builds (*) to
\r
68 >> work. I'm afraid I've forgotten exactly why both := and += make it fail
\r
69 >> (I wrote the patch a few months ago).
\r
72 > Still I guess it deserves a comment so we don't break it again?
\r
74 The following options could be tested (some day in (distant?) future):
\r
76 subdirs = compat completion emacs lib man parse-time-string
\r
77 subdirs += performance-test util test
\r
81 SUBDIRS := compat completion emacs lib man parse-time-string
\r
82 SUBDIRS += performance-test util test
\r
83 subdirs = $(SUBDIRS)
\r
85 but as Jani has already tested his version works just adding that
\r
86 comment David asked is the least labor-intensive thing to do --
\r
87 and therefore IMHO the best thing to do for this case
\r
88 (for sure I'm not going to spend more time on this now :D).
\r