1 Return-Path: <sojkam1@fel.cvut.cz>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 4F3B7431FAF
\r
6 for <notmuch@notmuchmail.org>; Thu, 6 Sep 2012 05:39:22 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.3 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id EUG3XtiA8vfN for <notmuch@notmuchmail.org>;
\r
16 Thu, 6 Sep 2012 05:39:21 -0700 (PDT)
\r
17 Received: from max.feld.cvut.cz (max.feld.cvut.cz [147.32.192.36])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 1F725431FAE
\r
19 for <notmuch@notmuchmail.org>; Thu, 6 Sep 2012 05:39:21 -0700 (PDT)
\r
20 Received: from localhost (unknown [192.168.200.4])
\r
21 by max.feld.cvut.cz (Postfix) with ESMTP id 6534B19F3333;
\r
22 Thu, 6 Sep 2012 14:39:16 +0200 (CEST)
\r
23 X-Virus-Scanned: IMAP AMAVIS
\r
24 Received: from max.feld.cvut.cz ([192.168.200.1])
\r
25 by localhost (styx.feld.cvut.cz [192.168.200.4]) (amavisd-new,
\r
27 with ESMTP id xfJ4XuCkEyzi; Thu, 6 Sep 2012 14:39:14 +0200 (CEST)
\r
28 Received: from imap.feld.cvut.cz (imap.feld.cvut.cz [147.32.192.34])
\r
29 by max.feld.cvut.cz (Postfix) with ESMTP id BA8AD19F2F4D;
\r
30 Thu, 6 Sep 2012 14:39:14 +0200 (CEST)
\r
31 Received: from steelpick.2x.cz (note-sojka.felk.cvut.cz [147.32.86.30])
\r
32 (Authenticated sender: sojkam1)
\r
33 by imap.feld.cvut.cz (Postfix) with ESMTPSA id 7F66D660904;
\r
34 Thu, 6 Sep 2012 14:39:14 +0200 (CEST)
\r
35 Received: from wsh by steelpick.2x.cz with local (Exim 4.80)
\r
36 (envelope-from <sojkam1@fel.cvut.cz>)
\r
37 id 1T9bMY-0000pr-BP; Thu, 06 Sep 2012 14:39:14 +0200
\r
38 From: Michal Sojka <sojkam1@fel.cvut.cz>
\r
39 To: Tomi Ollila <tomi.ollila@iki.fi>, notmuch@notmuchmail.org
\r
40 Subject: Re: [PATCH v2] emacs: Add customization group for replying
\r
41 In-Reply-To: <m2wr07fs0y.fsf@guru.guru-group.fi>
\r
42 References: <1346919815-20397-1-git-send-email-sojkam1@fel.cvut.cz>
\r
43 <m2wr07fs0y.fsf@guru.guru-group.fi>
\r
44 User-Agent: Notmuch/0.14+23~g9d68aca (http://notmuchmail.org) Emacs/24.1.1
\r
45 (x86_64-pc-linux-gnu)
\r
46 Date: Thu, 06 Sep 2012 14:39:14 +0200
\r
47 Message-ID: <87y5kntjf1.fsf@steelpick.2x.cz>
\r
49 Content-Type: text/plain
\r
50 X-BeenThere: notmuch@notmuchmail.org
\r
51 X-Mailman-Version: 2.1.13
\r
53 List-Id: "Use and development of the notmuch mail system."
\r
54 <notmuch.notmuchmail.org>
\r
55 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
56 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
57 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
58 List-Post: <mailto:notmuch@notmuchmail.org>
\r
59 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
60 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
62 X-List-Received-Date: Thu, 06 Sep 2012 12:39:22 -0000
\r
64 On Thu, Sep 06 2012, Tomi Ollila wrote:
\r
65 > On Thu, Sep 06 2012, Michal Sojka <sojkam1@fel.cvut.cz> wrote:
\r
67 >> When one wants to customize the format of reply message, there is nothing
\r
68 >> to tell the user how to do it. Without knowing that construction of
\r
69 >> reply buffer is actually implemented in the message package, it seems
\r
70 >> that replying cannot be customized.
\r
72 >> Because I was getting annoyed by the empty line the between the citation
\r
73 >> line and the quoted message, I figured out that changing this is fairly
\r
74 >> easy when one knows what to customize.
\r
76 >> This patch adds notmuch-reply customization group that contains
\r
77 >> references to the relevant customization options. The new group is easy
\r
78 >> to find as it is shown as a result of running "M-x customize-group RET
\r
82 > So far good, but...
\r
84 > You forgot to handle the current group setting for
\r
85 > notmuch-message-replied-tags -- currently notmuch-message.el has this:
\r
87 > (defcustom notmuch-message-replied-tags '("replied")
\r
88 > "Tags to be automatically added to or removed from a message when it is
\r
90 > Any tag in the list will be added to a replied message or,
\r
91 > if it is prefaced with a \"-\", removed.
\r
93 > For example, if you wanted to add a \"replied\" tag and remove
\r
94 > the \"inbox\" and \"todo\", you would set
\r
95 > (\"replied\" \"-inbox\" \"-todo\"\)"
\r
97 > :group 'notmuch-send)
\r
99 > If the above was changed to 'normuch-send, (require 'notmuch-lib)
\r
100 > was added to the beginning of notmuch-message.el and the defgroup
\r
101 > below was written as
\r
103 > (defgroup notmuch-reply
\r
104 > '((message-insertion custom-group)))
\r
105 > "Replying to messages.
\r
108 > would that work as expected ?
\r
112 I don't really get what are you trying to say. Do you mean that
\r
113 notmuch-message-replied-tags is referenced from notmuch-lib.el without
\r
114 (require 'notmuch-message)? I'm not sure whether it is required, but it
\r
115 works here without problems.
\r
117 Running M-x customize-variable RET notmuch-message-replied-tags RET
\r
118 shows the following. Note that both groups are mentioned at the bottom.
\r
119 No warning or errors are produced.
\r
123 --8<---------------cut here---------------start------------->8---
\r
124 To apply changes, use the Save or Set buttons.
\r
125 For details, see Saving Customizations in the Emacs manual.
\r
129 Operate on all settings in this buffer:
\r
130 Set for current session Save for future sessions
\r
131 Undo edits Reset to saved Erase customizations Exit
\r
133 Hide notmuch-message-replied-tags: '("replied")
\r
134 State : STANDARD. (mismatch)
\r
135 Tags to be automatically added to or removed from a message when it is replied to. Hide
\r
136 Any tag in the list will be added to a replied message or,
\r
137 if it is prefaced with a "-", removed.
\r
139 For example, if you wanted to add a "replied" tag and remove
\r
140 the "inbox" and "todo", you would set
\r
141 ("replied" "-inbox" "-todo")
\r
142 Groups: Notmuch Send Notmuch Reply
\r
143 --8<---------------cut here---------------end--------------->8---
\r