1 Return-Path: <david@tethera.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 4DA5C6DE00CB
\r
6 for <notmuch@notmuchmail.org>; Sat, 29 Aug 2015 18:31:58 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=0.118 tagged_above=-999 required=5 tests=[AWL=0.118]
\r
13 Received: from arlo.cworth.org ([127.0.0.1])
\r
14 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id RnBGhOQ5KsSE for <notmuch@notmuchmail.org>;
\r
16 Sat, 29 Aug 2015 18:31:56 -0700 (PDT)
\r
17 Received: from gitolite.debian.net (gitolite.debian.net [87.98.215.224])
\r
18 by arlo.cworth.org (Postfix) with ESMTPS id 226F76DE005F
\r
19 for <notmuch@notmuchmail.org>; Sat, 29 Aug 2015 18:31:55 -0700 (PDT)
\r
20 Received: from remotemail by gitolite.debian.net with local (Exim 4.80)
\r
21 (envelope-from <david@tethera.net>)
\r
22 id 1ZVrRf-0005Rn-Hd; Sun, 30 Aug 2015 01:30:07 +0000
\r
23 Received: (nullmailer pid 18833 invoked by uid 1000); Sun, 30 Aug 2015
\r
25 From: David Bremner <david@tethera.net>
\r
26 To: Jani Nikula <jani@nikula.org>, notmuch@notmuchmail.org
\r
27 Subject: Re: [RFC PATCH 3/5] cli: add support for not deduplicating notmuch
\r
30 <5badd1d1d46690987558dd2283efdc69be4c8c99.1440859765.git.jani@nikula.org>
\r
31 References: <cover.1440859765.git.jani@nikula.org>
\r
32 <5badd1d1d46690987558dd2283efdc69be4c8c99.1440859765.git.jani@nikula.org>
\r
33 User-Agent: Notmuch/0.20.2+60~gcb08a2e (http://notmuchmail.org) Emacs/24.5.1
\r
34 (x86_64-pc-linux-gnu)
\r
35 Date: Sat, 29 Aug 2015 22:29:46 -0300
\r
36 Message-ID: <87d1y5tvg5.fsf@maritornes.cs.unb.ca>
\r
38 Content-Type: text/plain
\r
39 X-BeenThere: notmuch@notmuchmail.org
\r
40 X-Mailman-Version: 2.1.18
\r
42 List-Id: "Use and development of the notmuch mail system."
\r
43 <notmuch.notmuchmail.org>
\r
44 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
45 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
46 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
47 List-Post: <mailto:notmuch@notmuchmail.org>
\r
48 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
49 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
50 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
51 X-List-Received-Date: Sun, 30 Aug 2015 01:31:58 -0000
\r
53 Jani Nikula <jani@nikula.org> writes:
\r
56 > + { NOTMUCH_OPT_KEYWORD, &ctx->dupe, "deduplicate", 'x',
\r
58 probably you want 'D' or 'd' here. Not that it makes a practical
\r
59 difference at this point.
\r
61 > + (notmuch_keyword_t []){ { "yes", -1 },
\r
63 I'm not very enthusiastic about reusing ctx->dupe for this.
\r
64 In particular the use of -1 for yes is off-putting
\r
65 It seems better to allocate another word of memory and use an
\r