1 Return-Path: <dmitry.kurochkin@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 07D78429E32
\r
6 for <notmuch@notmuchmail.org>; Tue, 28 Jun 2011 13:47:47 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id jrECC2k8YtgV for <notmuch@notmuchmail.org>;
\r
17 Tue, 28 Jun 2011 13:47:46 -0700 (PDT)
\r
18 Received: from mail-bw0-f53.google.com (mail-bw0-f53.google.com
\r
19 [209.85.214.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id D1CF6429E25
\r
22 for <notmuch@notmuchmail.org>; Tue, 28 Jun 2011 13:47:45 -0700 (PDT)
\r
23 Received: by bwg12 with SMTP id 12so550388bwg.26
\r
24 for <notmuch@notmuchmail.org>; Tue, 28 Jun 2011 13:47:44 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=from:to:cc:subject:in-reply-to:references:user-agent:date
\r
27 :message-id:mime-version:content-type;
\r
28 bh=ngeOqTlsQNcPiMwGKKWn3AiObuTynZHH+qMOIWy/jlk=;
\r
29 b=vAcE8icOooFRHaFZula1Q5weI4ZeHpL3Ai7ch/aeSh/sYujxYThUL2lkEHmrvB1Rgu
\r
30 eCHXT0jTuLaxqt6IAaBu5r00DkD9TbEHnsh3fHiJEuBCysU5pAatOTezx7FRDxXKUoqs
\r
31 Epmu0I98xmNyMDQqBPV1PVscqpQ0PQK5dPLXM=
\r
32 Received: by 10.204.104.1 with SMTP id m1mr2294294bko.162.1309294064327;
\r
33 Tue, 28 Jun 2011 13:47:44 -0700 (PDT)
\r
34 Received: from localhost ([91.144.186.21])
\r
35 by mx.google.com with ESMTPS id u6sm512851bkj.18.2011.06.28.13.47.41
\r
36 (version=TLSv1/SSLv3 cipher=OTHER);
\r
37 Tue, 28 Jun 2011 13:47:43 -0700 (PDT)
\r
38 From: Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
39 To: Carl Worth <cworth@cworth.org>, Austin Clements <amdragon@MIT.EDU>
\r
40 Subject: Re: [PATCH 2/2] test: use emacsclient(1) for Emacs tests
\r
41 In-Reply-To: <87zkl190od.fsf@yoom.home.cworth.org>
\r
42 References: <1309132379-24089-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
43 <1309146846-30991-1-git-send-email-dmitry.kurochkin@gmail.com>
\r
44 <1309146846-30991-2-git-send-email-dmitry.kurochkin@gmail.com>
\r
45 <BANLkTi=nwHRndz367K5oh4=tPaU-KNeZ8Q@mail.gmail.com>
\r
46 <87hb7byqge.fsf@gmail.com> <87d3hyzs1c.fsf@gmail.com>
\r
47 <20110628034937.GB4120@mit.edu> <20110628162257.GD4120@mit.edu>
\r
48 <871uydzz3x.fsf@gmail.com> <87zkl190od.fsf@yoom.home.cworth.org>
\r
49 User-Agent: Notmuch/0.5-275-g75c95e5 (http://notmuchmail.org) Emacs/23.3.1
\r
50 (x86_64-pc-linux-gnu)
\r
51 Date: Wed, 29 Jun 2011 00:47:37 +0400
\r
52 Message-ID: <87mxh1y97a.fsf@gmail.com>
\r
54 Content-Type: text/plain; charset=us-ascii
\r
55 Cc: notmuch@notmuchmail.org
\r
56 X-BeenThere: notmuch@notmuchmail.org
\r
57 X-Mailman-Version: 2.1.13
\r
59 List-Id: "Use and development of the notmuch mail system."
\r
60 <notmuch.notmuchmail.org>
\r
61 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
63 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
64 List-Post: <mailto:notmuch@notmuchmail.org>
\r
65 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
66 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
68 X-List-Received-Date: Tue, 28 Jun 2011 20:47:47 -0000
\r
70 On Tue, 28 Jun 2011 13:10:58 -0700, Carl Worth <cworth@cworth.org> wrote:
\r
71 > On Tue, 28 Jun 2011 20:42:42 +0400, Dmitry Kurochkin <dmitry.kurochkin@gmail.com> wrote:
\r
72 > > I would like to hear what other (Carl in particular) think about this.
\r
73 > > If the consensus is for your approach, I would be happy to implement
\r
76 > In general, I love the whole series, thanks! I'm looking forward to our
\r
77 > future, faster test suite.
\r
79 > Even more, I love the constructive dialog that follows the original
\r
80 > series and the attention being focused on getting things right.
\r
82 > As for the detail of whether to use emacsclient or Austin's look-alike,
\r
83 > I don't have a strong attachment to either solution. I do appreciate
\r
84 > concrete technical things like "robust against recycled PIDs",
\r
86 This is an issue indeed. We can take more care to better identify the
\r
87 process. But I think this is not really needed. I am fine with leaving
\r
88 a small (very tiny, really :)) possibility for leaving Emacs running for
\r
89 longer than needed. Note this only happens if test is terminated
\r
93 > robust against leaving daemon's around for some reason", etc.
\r
96 Not sure I agree with this. The watchdog is not perfect, but not less
\r
97 reliable. It reacts with a delay, but again I do not think this is so
\r
100 I think I found an issue with Austin's approach: if an error happens
\r
101 (and is not catched), the loop would stop. Currently, this would result
\r
102 in non-working tests and also would leave the Emacs process behind. I
\r
103 guess we will have to add error catching in the loop. Austin?
\r
105 > Would any of this potentially interfere with my own usage of emacsclient
\r
106 > and emacs server? I use them regularly and would be quite surprised (and
\r
107 > likely frustrated) if the test suite got mixed up with my existing emacs
\r
108 > server (or the other way around). Maybe that's already taken care of
\r
109 > with either approach? (A quick skim of the emacsclient manual age didn't
\r
110 > make it obvious to me how emacslcient finds its server.)
\r
113 Emacs uses `server-name' and emacsclient --socket-name to identify the
\r
114 server. Tests use "notmuch-test-suite-<TEST_SHELL_PID>" server name.
\r
115 While it is not entirely impossible to mess your existing Emacs server,
\r
116 it is unlikely enough IMO.
\r
124 > carl.d.worth@intel.com
\r