3c/567764ffa896bad97467d50e80650d6b77ecc1

   1 Return-Path: <tomi.ollila@iki.fi>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id DB42D431FC2\r
   6         for <notmuch@notmuchmail.org>; Tue,  6 May 2014 11:21:56 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: 0\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
  12         autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id CeUt1mjVvkIc for <notmuch@notmuchmail.org>;\r
  16         Tue,  6 May 2014 11:21:50 -0700 (PDT)\r
  17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
  18         by olra.theworths.org (Postfix) with ESMTP id 480F8431FAF\r
  19         for <notmuch@notmuchmail.org>; Tue,  6 May 2014 11:21:50 -0700 (PDT)\r
  20 Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
  21         by guru.guru-group.fi (Postfix) with ESMTP id 367181000E5;\r
  22         Tue,  6 May 2014 21:21:44 +0300 (EEST)\r
  23 From: Tomi Ollila <tomi.ollila@iki.fi>\r
  24 To: Charles Celerier <cceleri@cs.stanford.edu>, notmuch@notmuchmail.org\r
  25 Subject: Re: [PATCH 4/5] T360-symbol-hiding: Added code to support testing on\r
  26         Mac     OS X.\r
  27 In-Reply-To: <1399395748-44920-5-git-send-email-cceleri@cs.stanford.edu>\r
  28 References: <1399395748-44920-1-git-send-email-cceleri@cs.stanford.edu>\r
  29         <1399395748-44920-2-git-send-email-cceleri@cs.stanford.edu>\r
  30         <1399395748-44920-3-git-send-email-cceleri@cs.stanford.edu>\r
  31         <1399395748-44920-4-git-send-email-cceleri@cs.stanford.edu>\r
  32         <1399395748-44920-5-git-send-email-cceleri@cs.stanford.edu>\r
  33 User-Agent: Notmuch/0.18+12~gbfbd199 (http://notmuchmail.org) Emacs/24.3.1\r
  34         (x86_64-unknown-linux-gnu)\r
  35 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
  36         $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
  37         !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
  38 Date: Tue, 06 May 2014 21:21:43 +0300\r
  39 Message-ID: <m21tw6ix8o.fsf@guru.guru-group.fi>\r
  40 MIME-Version: 1.0\r
  41 Content-Type: text/plain\r
  42 X-BeenThere: notmuch@notmuchmail.org\r
  43 X-Mailman-Version: 2.1.13\r
  44 Precedence: list\r
  45 List-Id: "Use and development of the notmuch mail system."\r
  46         <notmuch.notmuchmail.org>\r
  47 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  48         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  49 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  50 List-Post: <mailto:notmuch@notmuchmail.org>\r
  51 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  52 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  53         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  54 X-List-Received-Date: Tue, 06 May 2014 18:21:57 -0000\r
  55 \r
  56 On Tue, May 06 2014, Charles Celerier <cceleri@cs.stanford.edu> wrote:\r
  57 \r
  58 > The Mac OS X platform uses *.dylib object files instead of *.so object\r
  59 > files for linking. Adding the path to notmuch.dylib to the end of\r
  60 > DYLD_FALLBACK_LIBRARY_PATH has a similar effect to adding the path to\r
  61 > notmuch.so to LD_LIBRARY_PATH on most Linux-based platforms (see\r
  62 > dyld(1)).\r
  63 \r
  64 This series LGTM. I don't understand this difference suffixing\r
  65 DYLD_FALLBACK_LIBRARY_PATH with $TEST_DIRECTORY/../lib on Mac OS X\r
  66 compared to prefixing LD_LIBRARY_PATH with the same on other\r
  67 systems, so I take your word that it works :D\r
  68 \r
  69 Tomi\r
  70 \r
  71 \r
  72 >\r
  73 > Signed-off-by: Charles Celerier <cceleri@cs.stanford.edu>\r
  74 > ---\r
  75 >  test/T360-symbol-hiding.sh | 9 ++++++++-\r
  76 >  1 file changed, 8 insertions(+), 1 deletion(-)\r
  77 >\r
  78 > diff --git a/test/T360-symbol-hiding.sh b/test/T360-symbol-hiding.sh\r
  79 > index 636ec91..97c734a 100755\r
  80 > --- a/test/T360-symbol-hiding.sh\r
  81 > +++ b/test/T360-symbol-hiding.sh\r
  82 > @@ -12,7 +12,14 @@ test_description='exception symbol hiding'\r
  83 >  . ./test-lib.sh\r
  84 >  \r
  85 >  run_test(){\r
  86 > -    result=$(LD_LIBRARY_PATH="$TEST_DIRECTORY/../lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}" $TEST_DIRECTORY/symbol-test 2>&1)\r
  87 > +    case $(uname -s) in\r
  88 > +    Darwin)\r
  89 > +        result=$(DYLD_FALLBACK_LIBRARY_PATH="${DYLD_FALLBACK_LIBRARY_PATH:+$DYLD_FALLBACK_LIBRARY_PATH:}$TEST_DIRECTORY/../lib" $TEST_DIRECTORY/symbol-test 2>&1)\r
  90 > +        ;;\r
  91 > +    *)\r
  92 > +        result=$(LD_LIBRARY_PATH="$TEST_DIRECTORY/../lib${LD_LIBRARY_PATH:+:$LD_LIBRARY_PATH}" $TEST_DIRECTORY/symbol-test 2>&1)\r
  93 > +        ;;\r
  94 > +    esac\r
  95 >  }\r
  96 >  \r
  97 >  output="A Xapian exception occurred opening database: Couldn't stat 'fakedb/.notmuch/xapian'\r
  98 > -- \r
  99 > 1.8.5.2 (Apple Git-48)\r
 100 >\r
 101 > _______________________________________________\r
 102 > notmuch mailing list\r
 103 > notmuch@notmuchmail.org\r
 104 > http://notmuchmail.org/mailman/listinfo/notmuch\r