Re: [PATCH] test:Folder tags shouldn't match after removal of file in given folder

[notmuch-archives.git] / 3b / ee6e8422d35fb1f86d9360701718ecfa03ad7d

Return-Path: <jrollins@finestructure.net>\r
X-Original-To: notmuch@notmuchmail.org\r
Delivered-To: notmuch@notmuchmail.org\r
Received: from localhost (localhost [127.0.0.1])\r
        by olra.theworths.org (Postfix) with ESMTP id 4B73B431FD0\r
        for <notmuch@notmuchmail.org>; Sat, 28 May 2011 14:31:25 -0700 (PDT)\r
X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
X-Spam-Flag: NO\r
X-Spam-Score: -2.29\r
X-Spam-Level: \r
X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5\r
        tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled\r
Received: from olra.theworths.org ([127.0.0.1])\r
        by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
        with ESMTP id jIAUmvBvKqVZ for <notmuch@notmuchmail.org>;\r
        Sat, 28 May 2011 14:31:23 -0700 (PDT)\r
Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu\r
        [131.215.239.19])\r
        by olra.theworths.org (Postfix) with ESMTP id 1C003431FB6\r
        for <notmuch@notmuchmail.org>; Sat, 28 May 2011 14:31:23 -0700 (PDT)\r
Received: from earth-doxen.imss.caltech.edu (localhost [127.0.0.1])\r
        by earth-doxen-postvirus (Postfix) with ESMTP id 7A27B66E035B;\r
        Sat, 28 May 2011 14:31:17 -0700 (PDT)\r
X-Spam-Scanned: at Caltech-IMSS on earth-doxen by amavisd-new\r
Received: from servo.finestructure.net (cpe-98-149-172-122.socal.res.rr.com\r
        [98.149.172.122]) (Authenticated sender: jrollins)\r
        by earth-doxen-submit (Postfix) with ESMTP id 2685A66E01E4;\r
        Sat, 28 May 2011 14:31:14 -0700 (PDT)\r
Received: by servo.finestructure.net (Postfix, from userid 1000)\r
        id 1FA0B4C5; Sat, 28 May 2011 14:31:11 -0700 (PDT)\r
From: Jameson Graef Rollins <jrollins@finestructure.net>\r
To: Carl Worth <cworth@cworth.org>, notmuch@notmuchmail.org\r
Subject: Re: normalizing part numbering across PGP/MIME processing\r
In-Reply-To: <87lixr1w87.fsf@yoom.home.cworth.org>\r
References: <1306371680-19441-1-git-send-email-jrollins@finestructure.net>\r
        <1306492059-7706-1-git-send-email-jrollins@finestructure.net>\r
        <87lixr1w87.fsf@yoom.home.cworth.org>\r
User-Agent: Notmuch/0.5-170-gfa54148 (http://notmuchmail.org) Emacs/23.3.1\r
        (x86_64-pc-linux-gnu)\r
Date: Sat, 28 May 2011 14:31:08 -0700\r
Message-ID: <87k4daecmb.fsf@servo.factory.finestructure.net>\r
MIME-Version: 1.0\r
Content-Type: multipart/signed; boundary="=-=-=";\r
        micalg=pgp-sha256; protocol="application/pgp-signature"\r
X-BeenThere: notmuch@notmuchmail.org\r
X-Mailman-Version: 2.1.13\r
Precedence: list\r
List-Id: "Use and development of the notmuch mail system."\r
        <notmuch.notmuchmail.org>\r
List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
        <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
List-Post: <mailto:notmuch@notmuchmail.org>\r
List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
        <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
X-List-Received-Date: Sat, 28 May 2011 21:31:25 -0000\r
\r
--=-=-=\r
Content-Transfer-Encoding: quoted-printable\r
\r
On Fri, 27 May 2011 17:53:44 -0700, Carl Worth <cworth@cworth.org> wrote:\r
> So, well done, Jameson! You've been extremely patient as I sat on this\r
> patch series for *so* long, and then made you rebuild it so many\r
> times. I hope you think the rebuilds were at least worth it for the much\r
> cleaner final state, (I know that the useless waiting wasn't worth it).\r
\r
w00t!  Thanks so much, Carl!  I definitely think the whole branch turned\r
out to be a lot cleaner in the end.\r
\r
> That said, here are the (minor) issues I have with the series:\r
>=20\r
>   * More tests should be switched to the new text_expect_equal_file\r
>=20\r
>       This isn't a problem with the series---but will be a nice\r
>       fix. I think the current "notmuch search --output=3Dtags *" is\r
>       broken due to a missing final newline---or at least has been\r
>       broken that way recently. So it will be nice to have this\r
>       support for testing a final newline.\r
\r
Yes, I agree.  I'm about to send a patch series to the list that\r
includes a bunch of random stuff that should be include in 0.6, and it\r
includes some of these fixes.\r
\r
>   * Should we set the crypto option to verify/decrypt by default?\r
>=20\r
>       That would certainly be convenient for me at least.\r
>=20\r
>       For people who don't want this, they can set the variable to\r
>       nil. But then they'll still have the following issue:\r
\r
I don't really have an opinion on this.  I have it set now, so whether\r
or not it's set by default doesn't make much difference to me.\r
\r
>   * I'm not a fan of the M-RET option for decrypting a message\r
>=20\r
>       If someone is going to have encrypted messages not decrypted by\r
>       default, then they can currently decrypt by opening the message\r
>       with M-RET. But I think in common use, the user is likely to\r
>       only realize too late that they want to decrypt the message.\r
>=20\r
>       So what I'd love to see is a keybinding for decrypting a message\r
>       from the view of the message itself. (One natural place would be\r
>       by activating the button of the encrypted part---but a\r
>       keybinding to review with decryption would be fine too---likely\r
>       easier to code and easier to use.)\r
\r
I agree it would definitely be better to have the redisplay happen from\r
inside the message show.  That would be much cleaner and more intuitive.\r
It will require a bit of work to add something like a "redisplay" in\r
notmuch-show, but I see no reason it can't be done.\r
\r
>   * I can't actually get decryption to work for me. :-(\r
>=20\r
>       When I run "notmuch show --decrypt" on a message encrypted with\r
>       my public key I get a segfault within libgmime, specifically in\r
>       the g_mime_session_request_passwd function.\r
\r
Yikes!\r
\r
>       My first guess is that this is due to the fact that gpg-agent\r
>       can't be run on my system (Debian unstable):\r
>=20\r
>       $ gpg-agent\r
>       gpg-agent: symbol lookup error: /usr/lib/libassuan.so.0: undefined symbo=\r
l: gpg_err_set_errno\r
>=20\r
>       I've got a Debian bug report queued up for this.\r
\r
hrm, that's very strange, unfortunately I'm not sure what's happening\r
there.  Bug in gpg-agent, I assume?\r
\r
>       I also tried running the same "notmuch show" command without\r
>       gpg-agent installed. How is libgmime supposed to actually\r
>       request a password in a case like this?\r
\r
That's a good question, actually, and I don't actually know the answer.\r
\r
Ok, so more release-candidate/0.6 patches to follow.\r
\r
Thanks again for pushing all this stuff through, Carl.\r
\r
jamie.\r
\r
--=-=-=\r
Content-Type: application/pgp-signature\r
\r
-----BEGIN PGP SIGNATURE-----\r
Version: GnuPG v1.4.11 (GNU/Linux)\r
\r
iQIcBAEBCAAGBQJN4WmcAAoJEO00zqvie6q8SdkP/1tBGU4rYZX4+bM8SUxZ0YkM\r
FJzEDf7KV1IddqZxJRVZxbRB/K6zAJUPioG2KuLqF7dP53HyuGbcQF43eyc/zXzF\r
Q6esAaMasL6dGvpa8jzKJSEQhqG8ZdTv5Am8/BOK1buzGb+xljB71g8s+lczzXa2\r
n8mifD07jKEcraZwlGQPSxPshuEQf6gklad8TASzkamUsxAW68n8YJfZ5zM2EZvR\r
qHOvkc27sxf6E2nFxyNYp8YciyVv60SN3pQAuwlCM0SiehCjKjdH7Olu+jZkxK0b\r
pCrTXxRq0tUR6XkOX802Dm1Qpepk9Mwy/WXxerMlvWxeNfdjVamibCzZbAkNXG5b\r
+E5UeSA8JpTA4viFiZeekNUeD986aXgbRm/YWQZy8QWWvCzfz+8Rh0xC1SrMCVFs\r
TLR9IiT0+ehzuo5nBgQszcR/PGdDAtSS/P5596W2OiKjvHkwkYp/i9qzFnOuK6zJ\r
77o4hqGJIyPynlXyRtv8f3symW9IEBj9ZyiSwj1Jb1ceK+r1D+Prkh3nFEhnlC9d\r
nIFdoOEE6rJG4Ssbl2WBTj7F18SPwi14JV8c5W72ZQy8YiqqaYqGP9GBEv/okReD\r
rKarRJftJqB/eA9GenKNeURnhhs/INCAVEavJ52jdkKQHrlUkA7qZLxVnlhv7r1D\r
6+V1auGVz7ACliIIcE7s\r
=x4jM\r
-----END PGP SIGNATURE-----\r
--=-=-=--\r