3b/b914e91184359a806105d5c8883abe9c0851a8

   1 Return-Path: <amdragon@mit.edu>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id D4928429E29\r
   6         for <notmuch@notmuchmail.org>; Wed, 11 Jan 2012 19:57:37 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.7\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5\r
  12         tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id dcwebr+Y6lhz for <notmuch@notmuchmail.org>;\r
  16         Wed, 11 Jan 2012 19:57:37 -0800 (PST)\r
  17 Received: from dmz-mailsec-scanner-6.mit.edu (DMZ-MAILSEC-SCANNER-6.MIT.EDU\r
  18         [18.7.68.35])\r
  19         by olra.theworths.org (Postfix) with ESMTP id 5E15C429E25\r
  20         for <notmuch@notmuchmail.org>; Wed, 11 Jan 2012 19:57:37 -0800 (PST)\r
  21 X-AuditID: 12074423-b7f9c6d0000008c3-e9-4f0e5a309d62\r
  22 Received: from mailhub-auth-1.mit.edu ( [18.9.21.35])\r
  23         by dmz-mailsec-scanner-6.mit.edu (Symantec Messaging Gateway) with SMTP\r
  24         id 9D.64.02243.03A5E0F4; Wed, 11 Jan 2012 22:57:36 -0500 (EST)\r
  25 Received: from outgoing.mit.edu (OUTGOING-AUTH.MIT.EDU [18.7.22.103])\r
  26         by mailhub-auth-1.mit.edu (8.13.8/8.9.2) with ESMTP id q0C3vZpc030544; \r
  27         Wed, 11 Jan 2012 22:57:35 -0500\r
  28 Received: from awakening.csail.mit.edu (awakening.csail.mit.edu [18.26.4.91])\r
  29         (authenticated bits=0)\r
  30         (User authenticated as amdragon@ATHENA.MIT.EDU)\r
  31         by outgoing.mit.edu (8.13.6/8.12.4) with ESMTP id q0C3vYvS015394\r
  32         (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);\r
  33         Wed, 11 Jan 2012 22:57:35 -0500 (EST)\r
  34 Received: from amthrax by awakening.csail.mit.edu with local (Exim 4.77)\r
  35         (envelope-from <amdragon@mit.edu>)\r
  36         id 1RlBnH-0004ju-Fv; Wed, 11 Jan 2012 22:57:39 -0500\r
  37 Date: Wed, 11 Jan 2012 22:57:39 -0500\r
  38 From: Austin Clements <amdragon@MIT.EDU>\r
  39 To: David Bremner <david@tethera.net>\r
  40 Subject: Re: [PATCH 2/2] notmuch-reply.c: uncrustify\r
  41 Message-ID: <20120112035739.GW20796@mit.edu>\r
  42 References: <1324135695-15487-1-git-send-email-david@tethera.net>\r
  43         <1326197228-10356-1-git-send-email-david@tethera.net>\r
  44         <1326197228-10356-3-git-send-email-david@tethera.net>\r
  45 MIME-Version: 1.0\r
  46 Content-Type: text/plain; charset=us-ascii\r
  47 Content-Disposition: inline\r
  48 In-Reply-To: <1326197228-10356-3-git-send-email-david@tethera.net>\r
  49 User-Agent: Mutt/1.5.21 (2010-09-15)\r
  50 X-Brightmail-Tracker:\r
  51  H4sIAAAAAAAAA+NgFuplleLIzCtJLcpLzFFi42IR4hRV1jWI4vM3WNGnbbFx2U9mixut3YwW\r
  52         12/OZHZg9vjVNpfZ49mqW8weWw69Zw5gjuKySUnNySxLLdK3S+DK2PO3galgI3vF/jcHWBoY\r
  53         n7B2MXJySAiYSOzf08UMYYtJXLi3nq2LkYtDSGAfo0T7mmVMIAkhgQ2MEi2dUhD2SSaJC1MD\r
  54         IYqWMErM61sGNolFQFVi2rVdYA1sAhoS2/YvZwSxRYDiV7dNZgOxmQXsJRbNnsQOYgsDbX69\r
  55         8SbYZl4BHYmrnd9YIIZuZJTo3bGVDSIhKHFy5hMWiGYtiRv/XgIt4ACypSWW/+MACXMKOEks\r
  56         v3ge7AZRARWJKSe3sU1gFJqFpHsWku5ZCN0LGJlXMcqm5Fbp5iZm5hSnJusWJyfm5aUW6Zrp\r
  57         5WaW6KWmlG5iBIU6u4vyDsY/B5UOMQpwMCrx8O7Yy+svxJpYVlyZe4hRkoNJSZT3RjifvxBf\r
  58         Un5KZUZicUZ8UWlOavEhRgkOZiURXqcaoHLelMTKqtSifJiUNAeLkjivhtY7PyGB9MSS1OzU\r
  59         1ILUIpisDAeHkgTvp0igoYJFqempFWmZOSUIaSYOTpDhPEDDH4HU8BYXJOYWZ6ZD5E8xKkqJ\r
  60         8x4ESQiAJDJK8+B6YanoFaM40CvCvHtAqniAaQyu+xXQYCagwVvW8YAMLklESEk1MHr93/Fp\r
  61         /fbXFtvqKiXjFleXnhdVLp0R6HGjXeXwAy/VrsotT1l6s769ELCY/D7wPteF9P4FD9WPWsT4\r
  62         qjRcdupZELmjx0P85PTuF73b9LqimDLkG87eKti+8EemG+ttgT8Mn/Le3PRnNj5tfkmp4ops\r
  63         eveNknOb5V/HdsfM+d/86dzV2OM5/kosxRmJhlrMRcWJAC+Vv7YgAwAA\r
  64 Cc: notmuch@notmuchmail.org, David Bremner <bremner@debian.org>\r
  65 X-BeenThere: notmuch@notmuchmail.org\r
  66 X-Mailman-Version: 2.1.13\r
  67 Precedence: list\r
  68 List-Id: "Use and development of the notmuch mail system."\r
  69         <notmuch.notmuchmail.org>\r
  70 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  71         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  72 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  73 List-Post: <mailto:notmuch@notmuchmail.org>\r
  74 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  75 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  76         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  77 X-List-Received-Date: Thu, 12 Jan 2012 03:57:38 -0000\r
  78 \r
  79 Quoth David Bremner on Jan 10 at  8:07 am:\r
  80 > From: David Bremner <bremner@debian.org>\r
  81 > \r
  82 > This patch shows the raw result of running uncrustify on notmuch-reply.c.\r
  83 > The re-indenting of "format_reply" would probably not be desirable.\r
  84 \r
  85 The good news is that that structure is on its way out.\r
  86 \r
  87 > @@ -625,6 +612,7 @@ notmuch_reply_command (void *ctx, int argc, char *argv[])\r
  88 >      notmuch_query_t *query;\r
  89 >      char *query_string;\r
  90 >      int opt_index, ret = 0;\r
  91 > +\r
  92 \r
  93 This one's a little weird.  Did it get confused by the function\r
  94 prototype?\r
  95 \r
  96 >      int (*reply_format_func)(void *ctx, notmuch_config_t *config, notmuch_query_t *query, notmuch_show_params_t *params);\r
  97 >      notmuch_show_params_t params = { .part = -1 };\r
  98 >      int format = FORMAT_DEFAULT;\r
  99 \r
 100 All of the other format fixes look very reasonable to me.  I think you\r
 101 managed to find one of the least canonical source files in the tree.\r
 102 Was that intentional?\r