1 Return-Path: <amdragon@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 60B72429E25
\r
6 for <notmuch@notmuchmail.org>; Wed, 22 Jun 2011 12:39:30 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,
\r
13 RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id qPXof-A78BRa for <notmuch@notmuchmail.org>;
\r
17 Wed, 22 Jun 2011 12:39:28 -0700 (PDT)
\r
18 Received: from mail-qw0-f53.google.com (mail-qw0-f53.google.com
\r
19 [209.85.216.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 5375B431FD0
\r
22 for <notmuch@notmuchmail.org>; Wed, 22 Jun 2011 12:39:28 -0700 (PDT)
\r
23 Received: by qwb7 with SMTP id 7so691002qwb.26
\r
24 for <notmuch@notmuchmail.org>; Wed, 22 Jun 2011 12:39:27 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=domainkey-signature:mime-version:sender:in-reply-to:references:date
\r
27 :x-google-sender-auth:message-id:subject:from:to:cc:content-type
\r
28 :content-transfer-encoding;
\r
29 bh=LXT+TmYt2A7lHUJ4mjKwmCyYb/bDcup92phrSeyCfew=;
\r
30 b=M14HQCKGIgdiMvt4VgnCpXtnM2cJ5BkG5IOz+pnbt4Q9nUG5O7hhd+NcojwnA7jyVy
\r
31 KZ6vBXUuJndSiCTyyq3JUIIiOF9Tlo2r82dpGMNMMe8cpKHefuqRh2fIeBcO5EKFIeW7
\r
32 Wc5xgyS5Aj8+HfrRVamDmAD9woCbwPQeIm1sU=
\r
33 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
\r
34 h=mime-version:sender:in-reply-to:references:date
\r
35 :x-google-sender-auth:message-id:subject:from:to:cc:content-type
\r
36 :content-transfer-encoding;
\r
37 b=jdMSvh8MH8xVZWZyl5m6aF+63Ee2LOf2OLHj73blbT4M1OgIN15mobB+QLjwcUMCYH
\r
38 rZFFVPgX5Dd+w2s0Kk81FGnX+hR38Z8kA4Y/WAntVwFa75IP/5QYILkkRmuuQOoyYfgi
\r
39 ZlZqAmNAOOdAE1I/z3sk+UwwcSG3WCZKFSr5c=
\r
41 Received: by 10.229.18.67 with SMTP id v3mr910996qca.100.1308771567264; Wed,
\r
42 22 Jun 2011 12:39:27 -0700 (PDT)
\r
43 Sender: amdragon@gmail.com
\r
44 Received: by 10.229.32.197 with HTTP; Wed, 22 Jun 2011 12:39:27 -0700 (PDT)
\r
45 In-Reply-To: <1307822683-848-1-git-send-email-amdragon@mit.edu>
\r
46 References: <87ei34rnc5.fsf@yoom.home.cworth.org>
\r
47 <1307822683-848-1-git-send-email-amdragon@mit.edu>
\r
48 Date: Wed, 22 Jun 2011 15:39:27 -0400
\r
49 X-Google-Sender-Auth: z0voCGdMArVH8JV52YgMg7CdD1s
\r
50 Message-ID: <BANLkTimeWnn5YtKjarFB8f8Fowvz0PxK2Q@mail.gmail.com>
\r
51 Subject: Re: [PATCH v6 00/17] Fix 'notmuch new' atomicity issues
\r
52 From: Austin Clements <amdragon@mit.edu>
\r
53 To: Carl Worth <cworth@cworth.org>
\r
54 Content-Type: text/plain; charset=ISO-8859-1
\r
55 Content-Transfer-Encoding: quoted-printable
\r
56 Cc: notmuch@notmuchmail.org
\r
57 X-BeenThere: notmuch@notmuchmail.org
\r
58 X-Mailman-Version: 2.1.13
\r
60 List-Id: "Use and development of the notmuch mail system."
\r
61 <notmuch.notmuchmail.org>
\r
62 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
64 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
65 List-Post: <mailto:notmuch@notmuchmail.org>
\r
66 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
67 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
68 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
69 X-List-Received-Date: Wed, 22 Jun 2011 19:39:30 -0000
\r
73 On Sat, Jun 11, 2011 at 4:04 PM, Austin Clements <amdragon@mit.edu> wrote:
\r
74 > Here's the reworked patch series that uses atomic sections more
\r
75 > heavily rather than changing the removal API. =A0This is atomic-new-v6
\r
76 > on http://awakening.csail.mit.edu/git/notmuch.git .
\r
78 > (I was planning to make this series on Monday while stuck on a plane,
\r
79 > but an opportunity presented itself when I needed something better to
\r
80 > do than fix the sink. =A0As a result, if you can look over this before
\r
81 > Monday, I can use that time to address any further comments.)
\r
83 > The beginning of the sequence---"test: Fix message when skipping
\r
84 > test_expect_equal* tests" through "new: Defer updating directory
\r
85 > mtimes until the end."---has not changed besides than the minor things
\r
86 > you pointed out earlier. =A0Here's a quick summary of the differences in
\r
87 > the rest of the sequence:
\r
89 > lib: Add notmuch_database_{begin,end}_atomic.
\r
90 > =A0Rebased but otherwise identical.
\r
92 > lib: Add support for nested atomic sections.
\r
95 > lib: Indicate if there are more filenames after removal.
\r
96 > =A0Rebased but otherwise identical.
\r
98 > lib: Remove message document directly after removing the last file
\r
100 > =A0New. =A0Supersedes the patches that rewrote
\r
101 > =A0notmuch_database_remove_message and made sync delete messages.
\r
103 > lib: Add an API to find a message by filename.
\r
104 > =A0Culled from "lib: Add API's to find by filename and ..." in the old
\r
105 > =A0series. =A0What I kept is identical.
\r
107 > lib: Wrap notmuch_database_add_message in an atomic section.
\r
110 > new: Cleanup. Put removed/renamed message count in add_files_state_t.
\r
111 > new: Cleanup. De-duplicate file name removal code.
\r
112 > =A0Both new, but closely related to previous remove_filename patch.
\r
114 > new: Synchronize maildir flags eagerly.
\r
115 > =A0New, but very closely related to previous patch of the same name.
\r
116 > =A0This patch is simpler now because of the previous two cleanups.
\r
118 > new: Wrap adding and removing messages in atomic sections.
\r
119 > =A0Rebased and added an atomic section around removal.
\r
121 > lib: Improve notmuch_database_{add,remove}_message documentation.
\r
124 > Ultimately, I still think the existing removal API is weird because it
\r
125 > forces you to do things like lookup a message by file name just in
\r
126 > case you need that message object after removal tells you that it
\r
127 > didn't actually remove the message. =A0But I don't know what to do about
\r
128 > it that isn't equally weird.
\r
130 > _______________________________________________
\r
131 > notmuch mailing list
\r
132 > notmuch@notmuchmail.org
\r
133 > http://notmuchmail.org/mailman/listinfo/notmuch
\r