1 Return-Path: <ethan.glasser.camp@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 0FCE0431FB6
\r
6 for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 20:12:59 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.799 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id LXM0nDgIEHcj for <notmuch@notmuchmail.org>;
\r
17 Mon, 15 Oct 2012 20:12:55 -0700 (PDT)
\r
18 Received: from mail-qc0-f181.google.com (mail-qc0-f181.google.com
\r
19 [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 639B2431FAE
\r
22 for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 20:12:55 -0700 (PDT)
\r
23 Received: by mail-qc0-f181.google.com with SMTP id x40so5296673qcp.26
\r
24 for <notmuch@notmuchmail.org>; Mon, 15 Oct 2012 20:12:54 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=from:to:cc:subject:in-reply-to:references:user-agent:date
\r
27 :message-id:mime-version:content-type;
\r
28 bh=TE0+Y5vnaQhISMV3QVY3YWrNJyEOR4nldJh5TfQg7l8=;
\r
29 b=jXMdJs924v1Rh21dqRsPs0jASVh9YlJdXVBEx+NY4IHdz4EBDLunPD/WpaHQP0sFPH
\r
30 4ilg+AXhu9Q4SBR04T9zu9pSihCjcK8a6Y4RTgri4EgGvUlz2k8McElGgHXk1AM8vWYI
\r
31 SbP2XixmtwiX3UGVGy/eKwJ3nb1pLwEHZnrY1ZYSWMSc4gkmJxdHDp+HqTB36KE6pk/m
\r
32 aAd7cH2Ti+yBs66/KUlfNZ4cuUciTKTpRuPE7wVUzK9Tiyno20yyhJsYD7/q7qhf9MwQ
\r
33 s/4n0bJ550Nv4KAZg7BvZDavvSLHUXe7Yf0MGbixWvjc6lZfUm31MkuCfsDQilo+BPTZ
\r
35 Received: by 10.229.136.81 with SMTP id q17mr6478714qct.115.1350357174872;
\r
36 Mon, 15 Oct 2012 20:12:54 -0700 (PDT)
\r
37 Received: from smtp.gmail.com (p70-80.acedsl.com. [66.114.70.80])
\r
38 by mx.google.com with ESMTPS id ch3sm17337002qab.9.2012.10.15.20.12.53
\r
39 (version=TLSv1/SSLv3 cipher=OTHER);
\r
40 Mon, 15 Oct 2012 20:12:54 -0700 (PDT)
\r
41 From: Ethan Glasser-Camp <ethan.glasser.camp@gmail.com>
\r
42 To: Mark Walters <markwalters1009@gmail.com>, Pieter Praet <pieter@praet.org>,
\r
43 David Bremner <david@tethera.net>,
\r
44 Dmitry Kurochkin <dmitry.kurochkin@gmail.com>
\r
45 Subject: Re: [PATCH v2 5/6] emacs: simplify `notmuch-show-get-messages-ids{,
\r
47 In-Reply-To: <87sjh2wx8z.fsf@qmul.ac.uk>
\r
48 References: <87wr7xqpuf.fsf@rocinante.cs.unb.ca>
\r
49 <1330122640-18895-1-git-send-email-pieter@praet.org>
\r
50 <1330122640-18895-6-git-send-email-pieter@praet.org>
\r
51 <87sjh2wx8z.fsf@qmul.ac.uk>
\r
52 User-Agent: Notmuch/0.14+45~g6ea9330 (http://notmuchmail.org) Emacs/23.3.1
\r
53 (x86_64-pc-linux-gnu)
\r
54 Date: Mon, 15 Oct 2012 23:12:51 -0400
\r
55 Message-ID: <87k3ur85zg.fsf@betacantrips.com>
\r
57 Content-Type: text/plain; charset=us-ascii
\r
58 Cc: Notmuch Mail <notmuch@notmuchmail.org>
\r
59 X-BeenThere: notmuch@notmuchmail.org
\r
60 X-Mailman-Version: 2.1.13
\r
62 List-Id: "Use and development of the notmuch mail system."
\r
63 <notmuch.notmuchmail.org>
\r
64 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
65 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
66 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
67 List-Post: <mailto:notmuch@notmuchmail.org>
\r
68 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
69 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
71 X-List-Received-Date: Tue, 16 Oct 2012 03:12:59 -0000
\r
73 Mark Walters <markwalters1009@gmail.com> writes:
\r
75 > I like the use of separator rather than hard-wiring " or ". My personal
\r
76 > preference would be to make that change but keep the two functions
\r
77 > separate (my "C"ness makes me like functions that have clear return
\r
78 > types!) But I am happy with the change too.
\r
80 I agree with this comment. Especially in dynamic languages, it's a good
\r
81 idea for each function to have only one return type.
\r
83 Also, it seems that the commit message has a TAB character in it (",<TAB>-search").
\r