1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 20CD3431FAF
\r
6 for <notmuch@notmuchmail.org>; Sat, 3 Mar 2012 13:37:04 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id lFNG5V4ePaj4 for <notmuch@notmuchmail.org>;
\r
16 Sat, 3 Mar 2012 13:37:02 -0800 (PST)
\r
17 Received: from mail-lpp01m010-f53.google.com (mail-lpp01m010-f53.google.com
\r
18 [209.85.215.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 2E446431FAE
\r
21 for <notmuch@notmuchmail.org>; Sat, 3 Mar 2012 13:37:02 -0800 (PST)
\r
22 Received: by lahc1 with SMTP id c1so3532774lah.26
\r
23 for <notmuch@notmuchmail.org>; Sat, 03 Mar 2012 13:36:59 -0800 (PST)
\r
24 Received-SPF: pass (google.com: domain of jani@nikula.org designates
\r
25 10.152.135.148 as permitted sender) client-ip=10.152.135.148;
\r
26 Authentication-Results: mr.google.com;
\r
27 spf=pass (google.com: domain of jani@nikula.org
\r
28 designates 10.152.135.148 as permitted sender)
\r
29 smtp.mail=jani@nikula.org
\r
30 Received: from mr.google.com ([10.152.135.148])
\r
31 by 10.152.135.148 with SMTP id ps20mr13370101lab.20.1330810619185
\r
32 (num_hops = 1); Sat, 03 Mar 2012 13:36:59 -0800 (PST)
\r
33 Received: by 10.152.135.148 with SMTP id ps20mr11005413lab.20.1330810619090;
\r
34 Sat, 03 Mar 2012 13:36:59 -0800 (PST)
\r
35 Received: from localhost (dsl-hkibrasgw4-fe50f800-253.dhcp.inet.fi.
\r
37 by mx.google.com with ESMTPS id hv2sm14791084lbb.9.2012.03.03.13.36.56
\r
38 (version=SSLv3 cipher=OTHER); Sat, 03 Mar 2012 13:36:57 -0800 (PST)
\r
39 From: Jani Nikula <jani@nikula.org>
\r
40 To: Daniel Schoepe <daniel@schoepe.org>, notmuch@notmuchmail.org
\r
41 Subject: Re: [PATCH v2] emacs: Pass a copy to
\r
42 notmuch-saved-search-sort-function
\r
43 In-Reply-To: <1330633478-1974-2-git-send-email-daniel@schoepe.org>
\r
44 References: <1330613059-5130-1-git-send-email-daniel@schoepe.org>
\r
45 <1330633478-1974-1-git-send-email-daniel@schoepe.org>
\r
46 <1330633478-1974-2-git-send-email-daniel@schoepe.org>
\r
47 User-Agent: Notmuch/0.11.1+289~ga123fab (http://notmuchmail.org) Emacs/23.3.1
\r
49 Date: Sat, 03 Mar 2012 23:36:54 +0200
\r
50 Message-ID: <87r4x9fjt5.fsf@nikula.org>
\r
52 Content-Type: text/plain; charset=us-ascii
\r
54 ALoCoQkujERZmGNEBk3YRc7u+awb/tsGPftGnTFQdjhmJor2/3aL9Q6BnFq1bP8KhRTSORzOQYNG
\r
55 X-BeenThere: notmuch@notmuchmail.org
\r
56 X-Mailman-Version: 2.1.13
\r
58 List-Id: "Use and development of the notmuch mail system."
\r
59 <notmuch.notmuchmail.org>
\r
60 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
62 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
63 List-Post: <mailto:notmuch@notmuchmail.org>
\r
64 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
65 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
67 X-List-Received-Date: Sat, 03 Mar 2012 21:37:04 -0000
\r
69 On Thu, 1 Mar 2012 21:24:38 +0100, Daniel Schoepe <daniel@schoepe.org> wrote:
\r
70 > notmuch-saved-search-sort-function might destructively modify its
\r
71 > input (`sort' does that, for instance), so it should not be given
\r
72 > notmuch-saved-searches directly.
\r
74 Hi Daniel, thanks for fixing this. Works for me.
\r
76 Full disclosure: I put the broken sort usage there in the first place...
\r
83 > emacs/notmuch-hello.el | 5 ++++-
\r
84 > 1 files changed, 4 insertions(+), 1 deletions(-)
\r
86 > diff --git a/emacs/notmuch-hello.el b/emacs/notmuch-hello.el
\r
87 > index aad373d..e089290 100644
\r
88 > --- a/emacs/notmuch-hello.el
\r
89 > +++ b/emacs/notmuch-hello.el
\r
90 > @@ -575,7 +575,10 @@ Complete list of currently available key bindings:
\r
91 > (let ((searches (notmuch-hello-query-counts
\r
92 > (if notmuch-saved-search-sort-function
\r
93 > (funcall notmuch-saved-search-sort-function
\r
94 > - notmuch-saved-searches)
\r
95 > + ;; Use a copy, since the sorting
\r
96 > + ;; function may have side effects,
\r
97 > + ;; e.g. if it just `sort's the input.
\r
98 > + (copy-sequence notmuch-saved-searches))
\r
99 > notmuch-saved-searches)
\r
100 > :show-empty-searches notmuch-show-empty-saved-searches))
\r
101 > found-target-pos)
\r
105 > _______________________________________________
\r
106 > notmuch mailing list
\r
107 > notmuch@notmuchmail.org
\r
108 > http://notmuchmail.org/mailman/listinfo/notmuch
\r