1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 29E93431FC2
\r
6 for <notmuch@notmuchmail.org>; Thu, 4 Feb 2010 12:54:22 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.866 tagged_above=-999 required=5
\r
12 tests=[ALL_TRUSTED=-1.8, AWL=-0.067, BAYES_50=0.001] autolearn=ham
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id q1e7nM4+SHyg; Thu, 4 Feb 2010 12:54:21 -0800 (PST)
\r
16 Received: from yoom.home.cworth.org (localhost [127.0.0.1])
\r
17 by olra.theworths.org (Postfix) with ESMTP id 21EEB431FAE;
\r
18 Thu, 4 Feb 2010 12:54:21 -0800 (PST)
\r
19 Received: by yoom.home.cworth.org (Postfix, from userid 1000)
\r
20 id CC2375500D4; Fri, 5 Feb 2010 09:54:20 +1300 (NZDT)
\r
21 From: Carl Worth <cworth@cworth.org>
\r
22 To: Jed Brown <jed@59A2.org>
\r
23 In-Reply-To: <1259450376-24523-2-git-send-email-jed@59A2.org>
\r
24 References: <87r5ripfy2.fsf@yoom.home.cworth.org>
\r
25 <1259450376-24523-1-git-send-email-jed@59A2.org>
\r
26 <1259450376-24523-2-git-send-email-jed@59A2.org>
\r
27 Date: Thu, 04 Feb 2010 12:54:20 -0800
\r
28 Message-ID: <87k4uspvr7.fsf@yoom.home.cworth.org>
\r
30 Content-Type: multipart/signed; boundary="=-=-=";
\r
31 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
32 Cc: notmuch@notmuchmail.org
\r
33 Subject: Re: [notmuch] [PATCH 2/2] notmuch-reply.c: Handle munged `Reply-To'
\r
35 X-BeenThere: notmuch@notmuchmail.org
\r
36 X-Mailman-Version: 2.1.13
\r
38 List-Id: "Use and development of the notmuch mail system."
\r
39 <notmuch.notmuchmail.org>
\r
40 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
41 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
42 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
43 List-Post: <mailto:notmuch@notmuchmail.org>
\r
44 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
45 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
47 X-List-Received-Date: Thu, 04 Feb 2010 20:54:22 -0000
\r
50 Content-Transfer-Encoding: quoted-printable
\r
52 On Sun, 29 Nov 2009 00:19:36 +0100, Jed Brown <jed@59A2.org> wrote:
\r
53 > Some mailing lists engage in the evil practice of changing the Reply-To
\r
54 > header so that replies from all mailers go to the list by default, at
\r
55 > the expense of not responding to the person who actually sent the
\r
56 > message. When this is detected, we reply to `From' and remove the
\r
57 > duplicate response to the mailing list. Consider a reply to the
\r
58 > following message.
\r
60 Thanks for the patch, Jed!
\r
62 I've gone ahead and pushed this out, (along with some cleanups/fixes).
\r
64 I augmented the notmuch test suite to actually test this case, (and the
\r
65 related case of honoring Reply-To for a non-munged message). And I'm
\r
66 glad I did because that turned up a bug in the patch, (using =3D=3D instead
\r
67 of !=3D for the return value of strcasestr resulted in *all* messages with
\r
68 a Reply-To header being considered as munged).
\r
70 Here's one cleanup I made which you might find interesting as a style
\r
71 issue (where I prefer naming a function based on what it *does* rather
\r
72 than on what it's being *used* for):
\r
74 commit d111c720bad53f98edba958aa605e857036a2bc8
\r
75 Author: Carl Worth <cworth@cworth.org>
\r
76 Date: Thu Feb 4 12:39:11 2010 -0800
\r
78 notmuch reply: Rename the mailing_list_munged_reply_to function
\r
80 This function detects whether the address in the Reply-To header
\r
81 already appears in either To or Cc. So give it a name that reflects
\r
82 what it does (reply_to_header_is_redundant) rather than the old name
\r
83 which described one possible use of the function, (as a simple
\r
84 heuristic for detecting whether a mailing list had applied reply-to
\r
90 Content-Type: application/pgp-signature
\r
92 -----BEGIN PGP SIGNATURE-----
\r
93 Version: GnuPG v1.4.10 (GNU/Linux)
\r
95 iD8DBQFLazP86JDdNq8qSWgRAi40AJ9A7iyLK9A2tCOgnkAgQohj/kyU8wCgpfX6
\r
96 IStxgD+IRQFVkLiQM6ETD8s=
\r
98 -----END PGP SIGNATURE-----
\r