34/bfa38768faa71fdd8d55960d63893ca3872a2c

   1 Return-Path: <dme@dme.org>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 1B99A431FBC\r
   6         for <notmuch@notmuchmail.org>; Wed, 28 Jan 2015 22:40:33 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: 1.739\r
  10 X-Spam-Level: *\r
  11 X-Spam-Status: No, score=1.739 tagged_above=-999 required=5\r
  12         tests=[DNS_FROM_AHBL_RHSBL=2.438, RCVD_IN_DNSWL_LOW=-0.7,\r
  13         UNPARSEABLE_RELAY=0.001] autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id G3OH2yBobrtn for <notmuch@notmuchmail.org>;\r
  17         Wed, 28 Jan 2015 22:40:28 -0800 (PST)\r
  18 Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com\r
  19         [209.85.212.178]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
  20         (No client certificate requested)\r
  21         by olra.theworths.org (Postfix) with ESMTPS id 9BF84431FAF\r
  22         for <notmuch@notmuchmail.org>; Wed, 28 Jan 2015 22:40:27 -0800 (PST)\r
  23 Received: by mail-wi0-f178.google.com with SMTP id bs8so11508419wib.5\r
  24         for <notmuch@notmuchmail.org>; Wed, 28 Jan 2015 22:40:25 -0800 (PST)\r
  25 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;\r
  26         d=1e100.net; s=20130820;\r
  27         h=x-gm-message-state:to:subject:in-reply-to:references:user-agent\r
  28         :from:date:message-id:mime-version:content-type;\r
  29         bh=Ffm+dfdb9FmRP51nsCfoDYIBhKq7qLbRdC2k7QOHrsg=;\r
  30         b=U3MXWikKW/NfQd/aZaCy2ik/YbQCTv6S2LrCm3Qu0ftLicpEGSPc3T0U4qGBSRwAHC\r
  31         artSej6E4bKLyqOduqcq8eQs6qvMMUQTYitOx5lzl6OfzyY/6QyZf3apPjSXDJLIqJfk\r
  32         I0Dpc+lXpwL0s2+f1raTQO5gBXNTGJ+QfA9L1Ir7fuc4ZmGIk6fxmVQbhyttHtaAIfKu\r
  33         tuNQ3xW71Qcd1nGD1JVvd7SwM93z6duPyCyx7h47uhUtiHthVHjHZC4abbVyML+Hj+TE\r
  34         jx3oPLYcP62W3bd3uESZSRoqG/xIQOVQKfW1n6xpMkegnJLZieOTi0di1vX1LLv754BJ\r
  35         rUnQ==\r
  36 X-Gm-Message-State:\r
  37  ALoCoQksHCa4OzY/9Co0b1QeX7wyXRToO8yE7o6dC+YGLqS4Quu/tt8lAAyONXCUSW/M4MOqPI5v\r
  38 X-Received: by 10.180.92.231 with SMTP id cp7mr1244255wib.24.1422513625066;\r
  39         Wed, 28 Jan 2015 22:40:25 -0800 (PST)\r
  40 Received: from disaster-area.hh.sledj.net\r
  41         ([2a01:348:1a2:1:ea39:35ff:fe2c:a227])\r
  42         by mx.google.com with ESMTPSA id be2sm9063980wjb.38.2015.01.28.22.40.23\r
  43         (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);\r
  44         Wed, 28 Jan 2015 22:40:24 -0800 (PST)\r
  45 Received: from localhost (30000@localhost [local]);\r
  46         by localhost (OpenSMTPD) with ESMTPA id 00f16893;\r
  47         Thu, 29 Jan 2015 06:40:22 +0000 (UTC)\r
  48 To: Jinwoo Lee <jinwoo68@gmail.com>, notmuch@notmuchmail.org\r
  49 Subject: Re: [PATCH] Add a defcustom for whether to block remote images by\r
  50         default.\r
  51 In-Reply-To: <1422495572-40384-1-git-send-email-jinwoo68@gmail.com>\r
  52 References: <1422495572-40384-1-git-send-email-jinwoo68@gmail.com>\r
  53 User-Agent: none\r
  54 From: David Edmondson <dme@dme.org>\r
  55 Date: Thu, 29 Jan 2015 06:40:22 +0000\r
  56 Message-ID: <cunlhkm2ip5.fsf@gargravarr.hh.sledj.net>\r
  57 MIME-Version: 1.0\r
  58 Content-Type: text/plain\r
  59 X-BeenThere: notmuch@notmuchmail.org\r
  60 X-Mailman-Version: 2.1.13\r
  61 Precedence: list\r
  62 List-Id: "Use and development of the notmuch mail system."\r
  63         <notmuch.notmuchmail.org>\r
  64 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  65         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  66 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  67 List-Post: <mailto:notmuch@notmuchmail.org>\r
  68 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  69 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  70         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  71 X-List-Received-Date: Thu, 29 Jan 2015 06:40:35 -0000\r
  72 \r
  73 A defcustom for `notmuch-show-text/html-blocked-images', which is used\r
  74 to set `shr-blocked-images', would be more usable. It can default to "."\r
  75 to achieve the same result.\r
  76 \r
  77 On Thu, Jan 29 2015, Jinwoo Lee wrote:\r
  78 > ---\r
  79 >  emacs/notmuch-show.el | 15 +++++++++++----\r
  80 >  1 file changed, 11 insertions(+), 4 deletions(-)\r
  81 >\r
  82 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el\r
  83 > index 66350d4..bc48922 100644\r
  84 > --- a/emacs/notmuch-show.el\r
  85 > +++ b/emacs/notmuch-show.el\r
  86 > @@ -136,6 +136,11 @@ indentation."\r
  87 >    :type 'boolean\r
  88 >    :group 'notmuch-show)\r
  89 >  \r
  90 > +(defcustom notmuch-show-block-remote-images t\r
  91 > +  "Block remote images by default."\r
  92 > +  :type 'boolean\r
  93 > +  :group 'notmuch-show)\r
  94 > +\r
  95 >  (defvar notmuch-show-thread-id nil)\r
  96 >  (make-variable-buffer-local 'notmuch-show-thread-id)\r
  97 >  (put 'notmuch-show-thread-id 'permanent-local t)\r
  98 > @@ -798,10 +803,12 @@ will return nil if the CID is unknown or cannot be retrieved."\r
  99 >          ;; URL-decode it (see RFC 2392).\r
 100 >          (let ((cid (url-unhex-string url)))\r
 101 >            (first (notmuch-show--get-cid-content cid)))))\r
 102 > -     ;; Block all external images to prevent privacy leaks and\r
 103 > -     ;; potential attacks.  FIXME: If we block an image, offer a\r
 104 > -     ;; button to load external images.\r
 105 > -     (shr-blocked-images "."))\r
 106 > +     ;; By default, block all external images to prevent privacy\r
 107 > +     ;; leaks and potential attacks.  FIXME: If we block an image,\r
 108 > +     ;; offer a button to load external images.\r
 109 > +     (shr-blocked-images (if notmuch-show-block-remote-images\r
 110 > +                             "."\r
 111 > +                           shr-blocked-images)))\r
 112 >      (shr-insert-document dom)\r
 113 >      t))\r
 114 >  \r
 115 > -- \r
 116 > 2.2.2\r
 117 >\r
 118 > _______________________________________________\r
 119 > notmuch mailing list\r
 120 > notmuch@notmuchmail.org\r
 121 > http://notmuchmail.org/mailman/listinfo/notmuch\r