1 Return-Path: <amdragon@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 659E2431FB6
\r
6 for <notmuch@notmuchmail.org>; Sun, 27 Feb 2011 00:15:45 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,
\r
13 RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id tQiWrq+J2DXv for <notmuch@notmuchmail.org>;
\r
17 Sun, 27 Feb 2011 00:15:44 -0800 (PST)
\r
18 Received: from mail-qw0-f53.google.com (mail-qw0-f53.google.com
\r
19 [209.85.216.53]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 5C4D3431FB5
\r
22 for <notmuch@notmuchmail.org>; Sun, 27 Feb 2011 00:15:44 -0800 (PST)
\r
23 Received: by qwc9 with SMTP id 9so2374802qwc.26
\r
24 for <notmuch@notmuchmail.org>; Sun, 27 Feb 2011 00:15:42 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=domainkey-signature:mime-version:sender:in-reply-to:references:date
\r
27 :x-google-sender-auth:message-id:subject:from:to:cc:content-type
\r
28 :content-transfer-encoding;
\r
29 bh=z2Xjgbcbjeydld4aHDovPZsKkspPY5CVO49kNRnv0JE=;
\r
30 b=UwpSjWmc29p9evWpz9jgB3H360VMJFh1BrFvDd6T7DLpW5OxmyPJ1d/EHCrVgo3Af8
\r
31 7gA3ofAqSfRC7EsBste9f5+dMHnqld8V0w32bpnepCEuQMVNj2z/6GkjbX3YhecL4GX7
\r
32 IcVLXVVRGjxnb1uMVFhx+YVhWImr9elcRGG2s=
\r
33 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;
\r
34 h=mime-version:sender:in-reply-to:references:date
\r
35 :x-google-sender-auth:message-id:subject:from:to:cc:content-type
\r
36 :content-transfer-encoding;
\r
37 b=cEkz7sfyG3Id5je3hiDur9QuTJ0KyXAk9Mmp51Gb5j4yyyhdC8UTaP7XRjiaQKYICe
\r
38 yHgQGwCvMoRdOV2fcfF3QRlvRunZFx9S06WYbLJj205TX6Hu88g1LMxeDPV43nMGc7F9
\r
39 uCeeysgpiPwH7zHxAZYwa2hMuoOU5qygyuUHc=
\r
41 Received: by 10.224.45.74 with SMTP id d10mr3514125qaf.304.1298794541563; Sun,
\r
42 27 Feb 2011 00:15:41 -0800 (PST)
\r
43 Sender: amdragon@gmail.com
\r
44 Received: by 10.229.105.68 with HTTP; Sun, 27 Feb 2011 00:15:41 -0800 (PST)
\r
45 In-Reply-To: <b526f37593c021805e62f1a061a49ea20f09df0f.1297749638.git.rlb@defaultvalue.org>
\r
46 References: <cover.1297749638.git.rlb@defaultvalue.org>
\r
47 <b526f37593c021805e62f1a061a49ea20f09df0f.1297749638.git.rlb@defaultvalue.org>
\r
48 Date: Sun, 27 Feb 2011 03:15:41 -0500
\r
49 X-Google-Sender-Auth: JBbqdFYBoNHM9x8XsabC5FMINxk
\r
50 Message-ID: <AANLkTi=-MJS1=O=Qpmhn6Tks5w_SOYvBtFM16N1+2oG1@mail.gmail.com>
\r
51 Subject: Re: [PATCH] Return error status from
\r
52 notmuch_message_tags_to_maildir_flags().
\r
53 From: Austin Clements <amdragon@mit.edu>
\r
54 To: Rob Browning <rlb@defaultvalue.org>
\r
55 Content-Type: text/plain; charset=ISO-8859-1
\r
56 Content-Transfer-Encoding: quoted-printable
\r
57 Cc: notmuch@notmuchmail.org
\r
58 X-BeenThere: notmuch@notmuchmail.org
\r
59 X-Mailman-Version: 2.1.13
\r
61 List-Id: "Use and development of the notmuch mail system."
\r
62 <notmuch.notmuchmail.org>
\r
63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
66 List-Post: <mailto:notmuch@notmuchmail.org>
\r
67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
70 X-List-Received-Date: Sun, 27 Feb 2011 08:15:45 -0000
\r
72 Looks good to me, but it appears that both callers of
\r
73 notmuch_message_tags_to_maildir_flags ignore the return value. Both
\r
74 callers synchronize maildir flags immediately after thawing the tag
\r
75 changes on a message. Perhaps they should instead synchronize
\r
76 *before* thawing and abort if the sync fails?
\r
78 On Tue, Feb 15, 2011 at 1:07 AM, Rob Browning <rlb@defaultvalue.org> wrote:
\r
79 > Signed-off-by: Rob Browning <rlb@defaultvalue.org>
\r
81 > =A0lib/message.cc | =A0 =A02 +-
\r
82 > =A01 files changed, 1 insertions(+), 1 deletions(-)
\r
84 > diff --git a/lib/message.cc b/lib/message.cc
\r
85 > index 0590f76..979fad5 100644
\r
86 > --- a/lib/message.cc
\r
87 > +++ b/lib/message.cc
\r
88 > @@ -1252,7 +1252,7 @@ notmuch_message_tags_to_maildir_flags (notmuch_mess=
\r
90 > =A0 =A0 talloc_free (to_set);
\r
91 > =A0 =A0 talloc_free (to_clear);
\r
93 > - =A0 =A0return NOTMUCH_STATUS_SUCCESS;
\r
94 > + =A0 =A0return status;
\r
97 > =A0notmuch_status_t
\r
101 > _______________________________________________
\r
102 > notmuch mailing list
\r
103 > notmuch@notmuchmail.org
\r
104 > http://notmuchmail.org/mailman/listinfo/notmuch
\r