33/b87a4892c059b8881b429db255b16d3045b368

   1 Return-Path: <tomi.ollila@iki.fi>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 0D002431FBD\r
   6         for <notmuch@notmuchmail.org>; Sun,  9 Feb 2014 01:34:52 -0800 (PST)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: 0\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]\r
  12         autolearn=disabled\r
  13 Received: from olra.theworths.org ([127.0.0.1])\r
  14         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  15         with ESMTP id FD6k5AfggLhm for <notmuch@notmuchmail.org>;\r
  16         Sun,  9 Feb 2014 01:34:48 -0800 (PST)\r
  17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])\r
  18         by olra.theworths.org (Postfix) with ESMTP id 8B95C431FBC\r
  19         for <notmuch@notmuchmail.org>; Sun,  9 Feb 2014 01:34:48 -0800 (PST)\r
  20 Received: from guru.guru-group.fi (localhost [IPv6:::1])\r
  21         by guru.guru-group.fi (Postfix) with ESMTP id 26E9F1000B2;\r
  22         Sun,  9 Feb 2014 11:34:40 +0200 (EET)\r
  23 From: Tomi Ollila <tomi.ollila@iki.fi>\r
  24 To: "W. Trevor King" <wking@tremily.us>, notmuch@notmuchmail.org\r
  25 Subject: Re: [PATCH 15/17] nmbug-status: Quote the title when using it as an\r
  26  id\r
  27 In-Reply-To: <20140208231804.GE17142@odin.tremily.us>\r
  28 References: <cover.1391424512.git.wking@tremily.us>\r
  29         <1e32bfd3b971aea8842fa29a3f7adc5a552a0f79.1391424512.git.wking@tremily.us>\r
  30         <20140208231804.GE17142@odin.tremily.us>\r
  31 User-Agent: Notmuch/0.17+69~g761b031 (http://notmuchmail.org) Emacs/24.3.1\r
  32         (x86_64-unknown-linux-gnu)\r
  33 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL\r
  34         $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F\r
  35         !)g;OY^,BjTbr)Np:%c_o'jj,Z\r
  36 Date: Sun, 09 Feb 2014 11:34:39 +0200\r
  37 Message-ID: <m2bnygzl1s.fsf@guru.guru-group.fi>\r
  38 MIME-Version: 1.0\r
  39 Content-Type: text/plain\r
  40 X-BeenThere: notmuch@notmuchmail.org\r
  41 X-Mailman-Version: 2.1.13\r
  42 Precedence: list\r
  43 List-Id: "Use and development of the notmuch mail system."\r
  44         <notmuch.notmuchmail.org>\r
  45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  46         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  48 List-Post: <mailto:notmuch@notmuchmail.org>\r
  49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  51         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  52 X-List-Received-Date: Sun, 09 Feb 2014 09:34:52 -0000\r
  53 \r
  54 On Sun, Feb 09 2014, "W. Trevor King" <wking@tremily.us> wrote:\r
  55 \r
  56 > On Mon, Feb 03, 2014 at 02:59:33AM -0800, W. Trevor King wrote:\r
  57 >> +            if 'id' not in view:\r
  58 >> +                view['id'] = quote(view['title'])\r
  59 >\r
  60 > Stuff like href="#Maybe%20Ready%20%28Core%20and%20Emacs%29" wasn't\r
  61 > working for me on Firefox 24.2.0, so I've tweaked this commit to slug\r
  62 > titles instead of quoting them.  Pushed to my nmbug-status-python3\r
  63 > branch and queued for my v2 submission.\r
  64 \r
  65 $ git checkout nmbug-status-python3\r
  66 $ git pull --rebase\r
  67 $ ./devel/nmbug/nmbug-status\r
  68 \r
  69 Looks pretty good to me. I am not sure whether the commit messages should\r
  70 be *that* verbose, though...\r
  71 \r
  72 >\r
  73 > Cheers,\r
  74 > Trevor\r
  75 \r
  76 Tomi\r