1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id CF95F431FAF
\r
6 for <notmuch@notmuchmail.org>; Thu, 9 Aug 2012 00:46:51 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id YKHq9obJZGh9 for <notmuch@notmuchmail.org>;
\r
16 Thu, 9 Aug 2012 00:46:48 -0700 (PDT)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 06AB7431FAE
\r
19 for <notmuch@notmuchmail.org>; Thu, 9 Aug 2012 00:46:48 -0700 (PDT)
\r
20 Received: by guru.guru-group.fi (Postfix, from userid 501)
\r
21 id 8DBEE1002A4; Thu, 9 Aug 2012 10:46:56 +0300 (EEST)
\r
22 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
23 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
24 Subject: Re: [PATCH] emacs: Fix "not defined at runtime" warning
\r
25 In-Reply-To: <1344462010-5349-1-git-send-email-amdragon@mit.edu>
\r
26 References: <1344462010-5349-1-git-send-email-amdragon@mit.edu>
\r
27 User-Agent: Notmuch/0.13.2+128~g07453d8 (http://notmuchmail.org) Emacs/23.1.1
\r
28 (x86_64-redhat-linux-gnu)
\r
29 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
30 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
31 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
32 Date: Thu, 09 Aug 2012 10:46:56 +0300
\r
33 Message-ID: <m2628scxsf.fsf@guru.guru-group.fi>
\r
35 Content-Type: text/plain; charset=us-ascii
\r
36 X-BeenThere: notmuch@notmuchmail.org
\r
37 X-Mailman-Version: 2.1.13
\r
39 List-Id: "Use and development of the notmuch mail system."
\r
40 <notmuch.notmuchmail.org>
\r
41 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
42 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
43 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
44 List-Post: <mailto:notmuch@notmuchmail.org>
\r
45 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
46 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
47 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
48 X-List-Received-Date: Thu, 09 Aug 2012 07:46:52 -0000
\r
50 On Thu, Aug 09 2012, Austin Clements <amdragon@MIT.EDU> wrote:
\r
52 > Previously, the Emacs byte compiler produced the warning
\r
54 > the function `remove-if-not' might not be defined at runtime.
\r
56 > because we only required cl at compile-time (not runtime). This fixes
\r
57 > this warning by requiring cl at runtime, ensuring that the definition
\r
58 > of remove-if-not is available.
\r
63 It took me a while to understand this. Now I just don't understand
\r
64 how did this work before. And why (require 'cl) is enough as
\r
65 remove-if-not is defined in cl-seq.el -- cl-seq.el requires cl
\r
66 but not vice-versa -- or at least I don't see that. Anyway
\r
67 (require 'cl) is the common way.
\r
71 > emacs/notmuch-lib.el | 2 +-
\r
72 > 1 file changed, 1 insertion(+), 1 deletion(-)
\r
74 > diff --git a/emacs/notmuch-lib.el b/emacs/notmuch-lib.el
\r
75 > index 30db58f..900235b 100644
\r
76 > --- a/emacs/notmuch-lib.el
\r
77 > +++ b/emacs/notmuch-lib.el
\r
79 > (require 'mm-view)
\r
80 > (require 'mm-decode)
\r
82 > -(eval-when-compile (require 'cl))
\r
85 > (defvar notmuch-command "notmuch"
\r
86 > "Command to run the notmuch binary.")
\r
90 > _______________________________________________
\r
91 > notmuch mailing list
\r
92 > notmuch@notmuchmail.org
\r
93 > http://notmuchmail.org/mailman/listinfo/notmuch
\r