1 Return-Path: <markwalters1009@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by arlo.cworth.org (Postfix) with ESMTP id 2F76F6DE171E
\r
6 for <notmuch@notmuchmail.org>; Sun, 7 Feb 2016 15:09:19 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at cworth.org
\r
11 X-Spam-Status: No, score=-0.201 tagged_above=-999 required=5 tests=[AWL=0.369,
\r
12 DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1,
\r
13 FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7,
\r
14 RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, SPF_PASS=-0.001]
\r
16 Received: from arlo.cworth.org ([127.0.0.1])
\r
17 by localhost (arlo.cworth.org [127.0.0.1]) (amavisd-new, port 10024)
\r
18 with ESMTP id 1OEaIyzhBbCg for <notmuch@notmuchmail.org>;
\r
19 Sun, 7 Feb 2016 15:09:16 -0800 (PST)
\r
20 Received: from mail-wm0-f68.google.com (mail-wm0-f68.google.com
\r
21 [74.125.82.68]) by arlo.cworth.org (Postfix) with ESMTPS id 82A296DE0C4A for
\r
22 <notmuch@notmuchmail.org>; Sun, 7 Feb 2016 15:09:16 -0800 (PST)
\r
23 Received: by mail-wm0-f68.google.com with SMTP id r129so12940603wmr.0
\r
24 for <notmuch@notmuchmail.org>; Sun, 07 Feb 2016 15:09:16 -0800 (PST)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
\r
26 h=from:to:subject:in-reply-to:references:user-agent:date:message-id
\r
27 :mime-version:content-type;
\r
28 bh=b4VOYGeKDoYYI/9tsZZOX5J2jNnnKBiCnxtboJq1nxc=;
\r
29 b=OFUziC/24AicE6FsxWciLdT6Yjh4qeg51K5zve+HNqJs3GlM2I0tr3EcHlPn+dnAuk
\r
30 PVQ1e5sqvBhnA8pZlbCC4BkTlie6sj4HiS57prceJycV3kDiezEfM0Jxa1oDspA367mt
\r
31 E+UW67j+fe/QjfLW2Pr0TO4NbjzERsSJHeFatxh9wtHk2tLv7TbuBUhhqf3J99gsd1hu
\r
32 yM6wjmYHh5C/EMssutR/VCt7tr6RPwUKZ9pPQ9qMOfu58OOgmAeQn//AMvbLnIkLiSWL
\r
33 boA2D0R32w1GwGZQV5GVP2mp3N2FPo9PzUho7aD/4HdRfhk6uN9mT518H5c021scSdIR
\r
35 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
36 d=1e100.net; s=20130820;
\r
37 h=x-gm-message-state:from:to:subject:in-reply-to:references
\r
38 :user-agent:date:message-id:mime-version:content-type;
\r
39 bh=b4VOYGeKDoYYI/9tsZZOX5J2jNnnKBiCnxtboJq1nxc=;
\r
40 b=cdCkQkPOmhMGSQY3X1nL4HWJhrT5hgWKM6dZg1PhZbCYB8KBvE7f0ygpIKcH8H9YDG
\r
41 CsJXAzU10R5zdLEcE02zEipfaEcTAg+9dV2IraWrrGvKEs2eJaF9JHggroMQhMZQmI5V
\r
42 J1wYkbhrFZrS1GG58Hi0xh/R+0maLyG/QpaU6n+JTyxEMmhtCjNaDI7ViPi9HXKjFxLP
\r
43 eWcQ0SIT1f2Y6He45ppt3pZysrUd8Ad+4mz/hISq3y+SKrIxHEyag+ebbfU+1W2WMb7K
\r
44 YJaKseKpDU2dj8JioL9FArLTGnD7itsWjpwGWt7udNIkMFBsMaGtm9orxooWrh7mQm9m
\r
47 AG10YOSC7IT+gBOa7M3Ec+m0O8dB0Z2KYD93oPB7bgY9I7K0xDOiZ1VHYX+dQgBjcUDoaA==
\r
48 X-Received: by 10.194.7.67 with SMTP id h3mr24080087wja.44.1454886554513;
\r
49 Sun, 07 Feb 2016 15:09:14 -0800 (PST)
\r
50 Received: from localhost (5751dfa2.skybroadband.com. [87.81.223.162])
\r
51 by smtp.gmail.com with ESMTPSA id kb5sm27012417wjc.22.2016.02.07.15.09.13
\r
52 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128);
\r
53 Sun, 07 Feb 2016 15:09:13 -0800 (PST)
\r
54 From: Mark Walters <markwalters1009@gmail.com>
\r
55 To: David Edmondson <dme@dme.org>, notmuch@notmuchmail.org
\r
56 Subject: Re: [PATCH v1] emacs: Report a lack of matches when calling
\r
58 In-Reply-To: <1454782892-1690-2-git-send-email-dme@dme.org>
\r
59 References: <1454782892-1690-1-git-send-email-dme@dme.org>
\r
60 <1454782892-1690-2-git-send-email-dme@dme.org>
\r
61 User-Agent: Notmuch/0.18.1+485~gca076ce (http://notmuchmail.org) Emacs/24.4.1
\r
62 (x86_64-pc-linux-gnu)
\r
63 Date: Sun, 07 Feb 2016 23:09:12 +0000
\r
64 Message-ID: <871t8onmnb.fsf@qmul.ac.uk>
\r
66 Content-Type: text/plain
\r
67 X-BeenThere: notmuch@notmuchmail.org
\r
68 X-Mailman-Version: 2.1.20
\r
70 List-Id: "Use and development of the notmuch mail system."
\r
71 <notmuch.notmuchmail.org>
\r
72 List-Unsubscribe: <https://notmuchmail.org/mailman/options/notmuch>,
\r
73 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
74 List-Archive: <http://notmuchmail.org/pipermail/notmuch/>
\r
75 List-Post: <mailto:notmuch@notmuchmail.org>
\r
76 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
77 List-Subscribe: <https://notmuchmail.org/mailman/listinfo/notmuch>,
\r
78 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
79 X-List-Received-Date: Sun, 07 Feb 2016 23:09:19 -0000
\r
81 On Sat, 06 Feb 2016, David Edmondson <dme@dme.org> wrote:
\r
82 > If the basic query passed to `notmuch-show' generates no results,
\r
83 > throw an error and inform the user that no messages matched the query
\r
84 > rather than displaying an empty buffer and showing an obscure error.
\r
88 First this is a clear improvement on the current behaviour, an I am
\r
89 happy with it as is.
\r
91 However, I wonder if we actually want an error at all in this case,
\r
92 rather than just a "message". I think some people run with
\r
93 debug-on-error enabled and it might be annoying in that case (though
\r
94 clearly less annoying than the current situation).
\r
96 [If anyone cares the current error comes from the marking read code in
\r
97 the post-command hook which assumes the buffer has a message]
\r
105 > emacs/notmuch-show.el | 8 +++++++-
\r
106 > 1 file changed, 7 insertions(+), 1 deletion(-)
\r
108 > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
109 > index 3345878..335992e 100644
\r
110 > --- a/emacs/notmuch-show.el
\r
111 > +++ b/emacs/notmuch-show.el
\r
112 > @@ -1248,7 +1248,13 @@ function is used."
\r
113 > (when (and (eq (buffer-size) 0)
\r
114 > notmuch-show-query-context)
\r
115 > (notmuch-show-insert-forest
\r
116 > - (notmuch-query-get-threads (append cli-args basic-args)))))
\r
117 > + (notmuch-query-get-threads (append cli-args basic-args))))
\r
119 > + ;; If there are still no results, kill the buffer and throw an
\r
121 > + (when (eq (buffer-size) 0)
\r
122 > + (kill-buffer (current-buffer))
\r
123 > + (error "No messages matched the query.")))
\r
125 > (jit-lock-register #'notmuch-show-buttonise-links)
\r
130 > _______________________________________________
\r
131 > notmuch mailing list
\r
132 > notmuch@notmuchmail.org
\r
133 > https://notmuchmail.org/mailman/listinfo/notmuch
\r