31/9d75b3321d837ca6b6e7a0651b160f6ec2633a

   1 Return-Path: <amdragon@gmail.com>\r
   2 X-Original-To: notmuch@notmuchmail.org\r
   3 Delivered-To: notmuch@notmuchmail.org\r
   4 Received: from localhost (localhost [127.0.0.1])\r
   5         by olra.theworths.org (Postfix) with ESMTP id 1313A431FD0\r
   6         for <notmuch@notmuchmail.org>; Thu, 12 May 2011 06:18:52 -0700 (PDT)\r
   7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org\r
   8 X-Spam-Flag: NO\r
   9 X-Spam-Score: -0.699\r
  10 X-Spam-Level: \r
  11 X-Spam-Status: No, score=-0.699 tagged_above=-999 required=5\r
  12         tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,\r
  13         RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled\r
  14 Received: from olra.theworths.org ([127.0.0.1])\r
  15         by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)\r
  16         with ESMTP id UqGID24TYwC0 for <notmuch@notmuchmail.org>;\r
  17         Thu, 12 May 2011 06:18:50 -0700 (PDT)\r
  18 Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com\r
  19         [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))\r
  20         (No client certificate requested)\r
  21         by olra.theworths.org (Postfix) with ESMTPS id ECE8E431FB6\r
  22         for <notmuch@notmuchmail.org>; Thu, 12 May 2011 06:18:49 -0700 (PDT)\r
  23 Received: by qyg14 with SMTP id 14so995426qyg.5\r
  24         for <notmuch@notmuchmail.org>; Thu, 12 May 2011 06:18:49 -0700 (PDT)\r
  25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;\r
  26         h=domainkey-signature:mime-version:sender:in-reply-to:references:date\r
  27         :x-google-sender-auth:message-id:subject:from:to:cc:content-type;\r
  28         bh=kPHUOeOqbJoV3GvRXYh0ycdfU0JZx78YjCt5yfKsqoc=;\r
  29         b=tS3d+153BN1o0+0w/HAyONArx+1xSMe+CQl76Ar5N2cDj/Y+cXQNygLtW1LDxXCl/i\r
  30         nfFCISXKCWTVveVz0TVEmvRTbfhvalWIv/5lPfsKjIuDtz0nt4XdI23CRH9xkYP+0z4P\r
  31         7swoSHPMmHCHTzGsL8UM4c/dhoFL6OHT8qgR4=\r
  32 DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma;\r
  33         h=mime-version:sender:in-reply-to:references:date\r
  34         :x-google-sender-auth:message-id:subject:from:to:cc:content-type;\r
  35         b=fPkrPlzuvvIoZGIDgbQCxFDJnIzPAN7V4DyE8i6mPG7cw6peWCkQACIBE/1AaXdVsc\r
  36         iKOUT8+0B4QzHb/Z+e3SRomK6Nk6WcY3QsbFIwVDDhhtJq1IYXp5KQZuPADpyi1fSz5f\r
  37         CltYbVbjD88gwyHeIvvygmjSroAi89+1Hyn/U=\r
  38 MIME-Version: 1.0\r
  39 Received: by 10.229.114.194 with SMTP id f2mr144507qcq.112.1305206329038; Thu,\r
  40         12 May 2011 06:18:49 -0700 (PDT)\r
  41 Sender: amdragon@gmail.com\r
  42 Received: by 10.229.233.17 with HTTP; Thu, 12 May 2011 06:18:48 -0700 (PDT)\r
  43 In-Reply-To: <87wrhw2jmm.fsf@praet.org>\r
  44 References: <8762pn7gth.fsf@servo.factory.finestructure.net>\r
  45         <87iptkfzwx.fsf@servo.factory.finestructure.net>\r
  46         <877h9zokod.fsf@servo.factory.finestructure.net>\r
  47         <878vuencm5.fsf@servo.factory.finestructure.net>\r
  48         <878vuejym8.fsf@servo.factory.finestructure.net>\r
  49         <87wrhw2jmm.fsf@praet.org>\r
  50 Date: Thu, 12 May 2011 09:18:48 -0400\r
  51 X-Google-Sender-Auth: 1-xpfNg_vp0-Vqj7i3fJV1h0IPs\r
  52 Message-ID: <BANLkTi=iz6F+1-WQ5KDno6N-MF=dQeTbEA@mail.gmail.com>\r
  53 Subject: Re: release-candidate/0.6\r
  54 From: Austin Clements <amdragon@mit.edu>\r
  55 To: Pieter Praet <pieter@praet.org>\r
  56 Content-Type: text/plain; charset=ISO-8859-1\r
  57 Cc: Notmuch Mail <notmuch@notmuchmail.org>\r
  58 X-BeenThere: notmuch@notmuchmail.org\r
  59 X-Mailman-Version: 2.1.13\r
  60 Precedence: list\r
  61 List-Id: "Use and development of the notmuch mail system."\r
  62         <notmuch.notmuchmail.org>\r
  63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,\r
  64         <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>\r
  65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>\r
  66 List-Post: <mailto:notmuch@notmuchmail.org>\r
  67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>\r
  68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,\r
  69         <mailto:notmuch-request@notmuchmail.org?subject=subscribe>\r
  70 X-List-Received-Date: Thu, 12 May 2011 13:18:52 -0000\r
  71 \r
  72 On Thu, May 12, 2011 at 8:22 AM, Pieter Praet <pieter@praet.org> wrote:\r
  73 > The atomicity tests were failing here because I didn't have GDB\r
  74 > installed, so I've added it as a prereq.\r
  75 \r
  76 Sorry, I've had a patch to address that sitting around, but hadn't\r
  77 sent it out (and I only fixed that one test).  I would suggest a\r
  78 somewhat gentler approach than "error", though:\r
  79 \r
  80 if test_expect_success "prereq: gdb is present" "which gdb"; then\r
  81     test_set_prereq GDB\r
  82 fi\r
  83 \r
  84 (Plus the two test-lib patches I just sent:\r
  85 id:1305206080-17461-1-git-send-email-amdragon@mit.edu and\r
  86 id:1305206110-17511-1-git-send-email-amdragon@mit.edu).\r
  87 \r
  88 "error" has the disadvantage that it doesn't get counted as a failed\r
  89 test in the final tally (because, indeed, it's not a failed test) and\r
  90 also that it immediately terminates the test script so it's not\r
  91 actually using the prereq system (which is fine for the atomicity test\r
  92 since all of the test cases depend on GDB, but the pattern I'm\r
  93 proposing works for finer-grained prerequisites).  Plus, with the\r
  94 above approach, if you don't have a prerequisite, the final tally\r
  95 shows one failed test plus some number of skipped tests (and the total\r
  96 number of tests never changes), which I would argue is cleaner.\r