1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id A0573431FAE
\r
6 for <notmuch@notmuchmail.org>; Mon, 7 Jan 2013 14:12:55 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id aOhyYbizu7HT for <notmuch@notmuchmail.org>;
\r
16 Mon, 7 Jan 2013 14:12:51 -0800 (PST)
\r
17 Received: from mail-la0-f48.google.com (mail-la0-f48.google.com
\r
18 [209.85.215.48]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id 0C4C2431FAF
\r
21 for <notmuch@notmuchmail.org>; Mon, 7 Jan 2013 14:12:50 -0800 (PST)
\r
22 Received: by mail-la0-f48.google.com with SMTP id ej20so17094892lab.21
\r
23 for <notmuch@notmuchmail.org>; Mon, 07 Jan 2013 14:12:48 -0800 (PST)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=x-received:from:to:cc:subject:in-reply-to:references:user-agent
\r
27 :date:message-id:mime-version:content-type:x-gm-message-state;
\r
28 bh=W67jVbpVazWg8zbuuNYvfqsu4yjM6pOWZBhQfb/bqiQ=;
\r
29 b=D08cDpdhSg8UlPZ+bQ8vjzLI6kUe6MlCHnwqVQdCZ+g84Q9iHYMP8gGAOfnz4qiC2l
\r
30 h/+cs8ns4TN+BqOMYHnDpnmQ8dQTtZQ3bOpfdlN3SRDkauuW0Vtckr/qFWSXy0is0XFf
\r
31 WHHAwIyoH4KQpGK6AxB4S0158ZrgD7pby2vPEXHu/rRMOCinQgvaTqJ3uiVWM9VHIQ98
\r
32 jTuHKP3yYZoVEtEP8nlvuPhjljWidiHQNXX/pc6H5vZymgxmwXz7OA0Dgr3Ftdn/J8Ko
\r
33 c88ypkuDpX4d1jqPL+vtHIx+is7NlhDXviTYHOSDVKKUK9ZNFNIC1AxvN1XqeORBV55B
\r
35 X-Received: by 10.152.125.136 with SMTP id mq8mr59789967lab.41.1357596766759;
\r
36 Mon, 07 Jan 2013 14:12:46 -0800 (PST)
\r
37 Received: from localhost (dsl-hkibrasgw4-50df51-27.dhcp.inet.fi.
\r
39 by mx.google.com with ESMTPS id ee5sm21849707lbb.14.2013.01.07.14.12.44
\r
40 (version=SSLv3 cipher=OTHER); Mon, 07 Jan 2013 14:12:45 -0800 (PST)
\r
41 From: Jani Nikula <jani@nikula.org>
\r
42 To: Austin Clements <amdragon@MIT.EDU>, notmuch@notmuchmail.org
\r
43 Subject: Re: [PATCH] string-util: Disallow empty prefixes in
\r
45 In-Reply-To: <1357593640-32122-1-git-send-email-amdragon@mit.edu>
\r
46 References: <1357593640-32122-1-git-send-email-amdragon@mit.edu>
\r
47 User-Agent: Notmuch/0.14+211~gc8d6546 (http://notmuchmail.org) Emacs/24.2.1
\r
48 (x86_64-pc-linux-gnu)
\r
49 Date: Tue, 08 Jan 2013 00:12:43 +0200
\r
50 Message-ID: <87ip78ej6s.fsf@nikula.org>
\r
52 Content-Type: text/plain
\r
54 ALoCoQlfmd4MXYahAi+gd7FV3R0WRMJw99BvQHl4taF6MjAAXSH5nOP5zrihxzQ+bQL5ktTfa3Mr
\r
55 X-BeenThere: notmuch@notmuchmail.org
\r
56 X-Mailman-Version: 2.1.13
\r
58 List-Id: "Use and development of the notmuch mail system."
\r
59 <notmuch.notmuchmail.org>
\r
60 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
61 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
62 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
63 List-Post: <mailto:notmuch@notmuchmail.org>
\r
64 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
65 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
66 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
67 X-List-Received-Date: Mon, 07 Jan 2013 22:12:55 -0000
\r
69 On Mon, 07 Jan 2013, Austin Clements <amdragon@MIT.EDU> wrote:
\r
70 > Xapian doesn't consider ":abc" to be a prefixed term. This makes
\r
71 > parse_boolean_term similarly reject queries with an empty prefix.
\r
77 > util/string-util.c | 2 +-
\r
78 > 1 file changed, 1 insertion(+), 1 deletion(-)
\r
80 > diff --git a/util/string-util.c b/util/string-util.c
\r
81 > index aba9aa8..a5622d7 100644
\r
82 > --- a/util/string-util.c
\r
83 > +++ b/util/string-util.c
\r
84 > @@ -127,7 +127,7 @@ parse_boolean_term (void *ctx, const char *str,
\r
85 > /* Parse prefix */
\r
86 > str = skip_space (str);
\r
87 > const char *pos = strchr (str, ':');
\r
89 > + if (! pos || pos == str)
\r
91 > *prefix_out = talloc_strndup (ctx, str, pos - str);
\r
92 > if (! *prefix_out) {
\r