1 Return-Path: <m.walters@qmul.ac.uk>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 3D619431FBF
\r
6 for <notmuch@notmuchmail.org>; Sun, 9 Feb 2014 02:17:34 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-1.098 tagged_above=-999 required=5
\r
12 tests=[DKIM_ADSP_CUSTOM_MED=0.001, FREEMAIL_FROM=0.001,
\r
13 NML_ADSP_CUSTOM_MED=1.2, RCVD_IN_DNSWL_MED=-2.3] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id q6CHW+JpeGBV for <notmuch@notmuchmail.org>;
\r
17 Sun, 9 Feb 2014 02:17:28 -0800 (PST)
\r
18 Received: from mail1.qmul.ac.uk (mail1.qmul.ac.uk [138.37.6.7])
\r
19 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id 0CA1D431FBD
\r
22 for <notmuch@notmuchmail.org>; Sun, 9 Feb 2014 02:17:28 -0800 (PST)
\r
23 Received: from smtp.qmul.ac.uk ([138.37.6.40])
\r
24 by mail1.qmul.ac.uk with esmtp (Exim 4.71)
\r
25 (envelope-from <m.walters@qmul.ac.uk>)
\r
26 id 1WCRRr-0002IS-U1; Sun, 09 Feb 2014 10:17:21 +0000
\r
27 Received: from 93-97-24-31.zone5.bethere.co.uk ([93.97.24.31] helo=localhost)
\r
28 by smtp.qmul.ac.uk with esmtpsa (TLSv1:AES128-SHA:128) (Exim 4.71)
\r
29 (envelope-from <m.walters@qmul.ac.uk>)
\r
30 id 1WCRRr-0000CT-Jr; Sun, 09 Feb 2014 10:17:15 +0000
\r
31 From: Mark Walters <markwalters1009@gmail.com>
\r
32 To: "W. Trevor King" <wking@tremily.us>
\r
33 Subject: Re: [PATCH 2/2] emacs: Prefer Content-Description over filename for
\r
35 In-Reply-To: <20140208173333.GC17142@odin.tremily.us>
\r
36 References: <877g9chbay.fsf@qmul.ac.uk>
\r
37 <cover.1391423201.git.wking@tremily.us>
\r
38 <27be295875a7df782a83c9a2c09d06f9d321fe9e.1391423201.git.wking@tremily.us>
\r
39 <87vbwwosuw.fsf@qmul.ac.uk> <20140203203418.GO14197@odin.tremily.us>
\r
40 <20140208173333.GC17142@odin.tremily.us>
\r
41 User-Agent: Notmuch/0.15.2+484~gfb59956 (http://notmuchmail.org) Emacs/23.4.1
\r
42 (x86_64-pc-linux-gnu)
\r
43 Date: Sun, 09 Feb 2014 10:17:14 +0000
\r
44 Message-ID: <8761ood1zp.fsf@qmul.ac.uk>
\r
46 Content-Type: text/plain; charset=utf-8
\r
47 Content-Transfer-Encoding: quoted-printable
\r
48 X-Sender-Host-Address: 93.97.24.31
\r
49 X-QM-Geographic: According to ripencc,
\r
50 this message was delivered by a machine in Britain (UK) (GB).
\r
51 X-QM-SPAM-Info: Sender has good ham record. :)
\r
52 X-QM-Body-MD5: 93d7d7ccd5b3b0b9f479085e3c370da9 (of first 20000 bytes)
\r
53 X-SpamAssassin-Score: 0.0
\r
54 X-SpamAssassin-SpamBar: /
\r
55 X-SpamAssassin-Report: The QM spam filters have analysed this message to
\r
57 spam. We require at least 5.0 points to mark a message as spam.
\r
58 This message scored 0.0 points. Summary of the scoring:
\r
59 * 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail
\r
60 provider * (markwalters1009[at]gmail.com)
\r
61 * 0.0 AWL AWL: From: address is in the auto white-list
\r
62 X-QM-Scan-Virus: ClamAV says the message is clean
\r
63 Cc: notmuch@notmuchmail.org
\r
64 X-BeenThere: notmuch@notmuchmail.org
\r
65 X-Mailman-Version: 2.1.13
\r
67 List-Id: "Use and development of the notmuch mail system."
\r
68 <notmuch.notmuchmail.org>
\r
69 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
70 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
71 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
72 List-Post: <mailto:notmuch@notmuchmail.org>
\r
73 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
74 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
75 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
76 X-List-Received-Date: Sun, 09 Feb 2014 10:17:34 -0000
\r
78 On Sat, 08 Feb 2014, "W. Trevor King" <wking@tremily.us> wrote:
\r
80 > On Mon, Feb 03, 2014 at 12:34:18PM -0800, W. Trevor King wrote:
\r
81 >> On Mon, Feb 03, 2014 at 08:15:35PM +0000, Mark Walters wrote:
\r
82 >> > My only other comment on the series is that you should update
\r
83 >> > devel/schemata in the first patch to reflect this addition.
\r
85 >> Ah, I didn't realize that file existed :p.
\r
87 > Looking at this more, I'm unsure about whether or not I should bump
\r
88 > the version. b96ba63 (show: indicate length, encoding of omitted body
\r
89 > content, 2012-12-16) added part.content-length? and
\r
90 > part.content-transfer-encoding? and doesn't bump the version, while
\r
91 > abeac48 (search: Add stable queries to thread search results,
\r
92 > 2013-10-24) adds thread_summary.query and does bump the version. From
\r
95 > Backwards-incompatible changes such as removing map fields, changing
\r
96 > the meaning of map fields, or changing the meanings of list elements
\r
97 > should increase this. New (required) map fields can be added without
\r
100 > I think that the addition of part.content-description? should not bump
\r
101 > the version, but then I'm not sure how to document the change in
\r
102 > devel/schemata. I'm leaning towards something like:
\r
104 I think you just add the new field to the list of fields in the schemata
\r
105 in the appropriate place in the part section as
\r
107 content-description?: string,
\r
109 and you don't need to bump the version. I think this is because a client
\r
110 can safely ask for this field regardless of the notmuch version and
\r
111 won't get confused.=20
\r
121 > diff --git a/devel/schemata b/devel/schemata
\r
122 > index 41dc4a6..63d8aa4 100644
\r
123 > --- a/devel/schemata
\r
124 > +++ b/devel/schemata
\r
125 > @@ -26,6 +26,9 @@ v1
\r
127 > - Added the thread_summary.query field.
\r
130 > +- Added the part.content-descrition? field.
\r
132 > Common non-terminals
\r
133 > --------------------
\r
136 > Alternatively, there could be a minor version that gets bumped on each
\r
137 > tweak, however insignificant.
\r
144 > This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
\r
145 > For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy
\r