1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id E1DDC431FBD
\r
6 for <notmuch@notmuchmail.org>; Mon, 27 Jan 2014 11:07:16 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id aCWuVDpFgUEV for <notmuch@notmuchmail.org>;
\r
16 Mon, 27 Jan 2014 11:07:09 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 9858E431FBC
\r
19 for <notmuch@notmuchmail.org>; Mon, 27 Jan 2014 11:07:09 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 9ABF1100051;
\r
22 Mon, 27 Jan 2014 21:07:03 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: David Bremner <david@tethera.net>, notmuch@notmuchmail.org
\r
25 Subject: Re: [PATCH] compat: add canonicalize_file_name
\r
26 In-Reply-To: <1390831932-7865-1-git-send-email-david@tethera.net>
\r
27 References: <8761p6n0wc.fsf@zancas.localnet>
\r
28 <1390831932-7865-1-git-send-email-david@tethera.net>
\r
29 User-Agent: Notmuch/0.17+55~g4397960 (http://notmuchmail.org) Emacs/24.3.1
\r
30 (x86_64-unknown-linux-gnu)
\r
31 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
32 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
33 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
34 Date: Mon, 27 Jan 2014 21:07:03 +0200
\r
35 Message-ID: <m2ppndnt0o.fsf@guru.guru-group.fi>
\r
37 Content-Type: text/plain
\r
38 X-BeenThere: notmuch@notmuchmail.org
\r
39 X-Mailman-Version: 2.1.13
\r
41 List-Id: "Use and development of the notmuch mail system."
\r
42 <notmuch.notmuchmail.org>
\r
43 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
44 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
45 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
46 List-Post: <mailto:notmuch@notmuchmail.org>
\r
47 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
48 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
49 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
50 X-List-Received-Date: Mon, 27 Jan 2014 19:07:17 -0000
\r
52 On Mon, Jan 27 2014, David Bremner <david@tethera.net> wrote:
\r
54 > the POSIX 2008 behaviour of realpath is not available everywhere so we
\r
55 > provide a simple wrapper function. We use (and provide) the gnu
\r
56 > extension canonicalize_file_name to make it cleaner to test for the
\r
57 > feature we need; otherwise we have to rely on realpath segfaulting if
\r
58 > the second argument is null.
\r
61 I think this patch is tolerable. I first thought we should check the
\r
62 combination of not having canonicalize_file_name() and having POSIX 2008
\r
63 behaviour of realpath()...
\r
65 ... but the compat code is simple enough and basically done the same way
\r
68 http://svnweb.freebsd.org/base/release/9.2.0/lib/libc/stdlib/realpath.c?revision=255898&view=markup
\r
70 qualifying the implementation. So +1 from me.
\r
74 > compat/Makefile.local | 4 ++++
\r
75 > compat/canonicalize_file_name.c | 18 ++++++++++++++++++
\r
76 > compat/compat.h | 8 ++++++++
\r
77 > compat/have_canonicalize_file_name.c | 10 ++++++++++
\r
78 > configure | 16 ++++++++++++++++
\r
79 > notmuch-config.c | 2 +-
\r
80 > 6 files changed, 57 insertions(+), 1 deletion(-)
\r
81 > create mode 100644 compat/canonicalize_file_name.c
\r
82 > create mode 100644 compat/have_canonicalize_file_name.c
\r