1 Return-Path: <jani@nikula.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 8CB27431FB6
\r
6 for <notmuch@notmuchmail.org>; Wed, 6 Feb 2013 23:43:50 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id OZ0JZahKDuIA for <notmuch@notmuchmail.org>;
\r
16 Wed, 6 Feb 2013 23:43:48 -0800 (PST)
\r
17 Received: from mail-bk0-f44.google.com (mail-bk0-f44.google.com
\r
18 [209.85.214.44]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
19 (No client certificate requested)
\r
20 by olra.theworths.org (Postfix) with ESMTPS id A5D97431FAF
\r
21 for <notmuch@notmuchmail.org>; Wed, 6 Feb 2013 23:43:48 -0800 (PST)
\r
22 Received: by mail-bk0-f44.google.com with SMTP id j4so1023213bkw.3
\r
23 for <notmuch@notmuchmail.org>; Wed, 06 Feb 2013 23:43:47 -0800 (PST)
\r
24 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
\r
25 d=google.com; s=20120113;
\r
26 h=x-received:from:to:subject:in-reply-to:references:user-agent:date
\r
27 :message-id:mime-version:content-type:x-gm-message-state;
\r
28 bh=tOsrWtKxsy9uojNq1+QJ7/HMf5MpkA19A4c/fGppRS8=;
\r
29 b=KWZE7tJr1tGwKgvMQxAeYnXSLJ3FeKNGWBfyhe8Q2ZMhCX2x4J+zA3s9gQO5cEsDb4
\r
30 XWuvx/OryJ+2pPMWzJycaht7JNdv5vo8vAR0FUceblHOdR1kb8XJxh+v3E5a0APZpuDE
\r
31 oJgwF8D3DrffGqPnqa/JHlSqiULYhD4f4HgisTj9OPpL1fJeuprmPlO+aJ+jWrldvpGC
\r
32 XZfY9bMJ/BDK+Iu9kRuKE0dMz4aOk47/9Z1VGTko1z5aQP6BzN7FbNIfd5/Neg8ruIBf
\r
33 xEb442tXDcjZVuCYZ70jSuUITkW/0z2U35mbmev6c0lhxvD5XHK/zfG/ZBmHIB0hJAOq
\r
35 X-Received: by 10.204.129.16 with SMTP id m16mr80625bks.103.1360223025419;
\r
36 Wed, 06 Feb 2013 23:43:45 -0800 (PST)
\r
37 Received: from localhost ([2001:4b98:dc0:43:216:3eff:fe1b:25f3])
\r
38 by mx.google.com with ESMTPS id x10sm8735663bkv.13.2013.02.06.23.43.41
\r
39 (version=TLSv1.1 cipher=RC4-SHA bits=128/128);
\r
40 Wed, 06 Feb 2013 23:43:43 -0800 (PST)
\r
41 From: Jani Nikula <jani@nikula.org>
\r
42 To: Jameson Graef Rollins <jrollins@finestructure.net>,
\r
43 notmuch@notmuchmail.org
\r
44 Subject: Re: [PATCH 0/6] notmuch cli config changes
\r
45 In-Reply-To: <871ucts54t.fsf@servo.finestructure.net>
\r
46 References: <cover.1359495450.git.jani@nikula.org>
\r
47 <871ucts54t.fsf@servo.finestructure.net>
\r
48 User-Agent: Notmuch/0.14+259~gdee88db (http://notmuchmail.org) Emacs/23.2.1
\r
49 (x86_64-pc-linux-gnu)
\r
50 Date: Thu, 07 Feb 2013 08:43:34 +0100
\r
51 Message-ID: <878v70lgbd.fsf@nikula.org>
\r
53 Content-Type: text/plain; charset=us-ascii
\r
55 ALoCoQkqQhUolnBCy5Oe1AaoYAx/mwpdMSKb6jTjf0Cs4FzZ3yICGElry404ww+1Wjge7g2kWong
\r
56 X-BeenThere: notmuch@notmuchmail.org
\r
57 X-Mailman-Version: 2.1.13
\r
59 List-Id: "Use and development of the notmuch mail system."
\r
60 <notmuch.notmuchmail.org>
\r
61 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
62 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
63 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
64 List-Post: <mailto:notmuch@notmuchmail.org>
\r
65 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
66 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
67 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
68 X-List-Received-Date: Thu, 07 Feb 2013 07:43:50 -0000
\r
70 On Wed, 06 Feb 2013, Jameson Graef Rollins <jrollins@finestructure.net> wrote:
\r
71 > On Tue, Jan 29 2013, Jani Nikula <jani@nikula.org> wrote:
\r
72 >> Hi all, the goal here is to add support for --config=FILE option at the
\r
73 >> notmuch top level (e.g. 'notmuch --config=FILE search foo'). In order to
\r
74 >> achieve this neatly, I ended up moving config open/close to main() from
\r
75 >> subcommands. This isn't a bad thing, because all notmuch commands opened
\r
76 >> the config file anyway.
\r
78 > Hi, Jani. I appreciate you've put a lot of work into this series, but
\r
79 > I'll be the same devil's advocate that I was to David previously. Why
\r
80 > do we need a command line option here when we already have an
\r
81 > environment variable that handles just this? Is there some benefit to
\r
82 > having a command line option for this that I don't see? I see this as
\r
83 > another instance of an option that regular users will rarely use, if
\r
88 In any case I see patches 1-4, and to an extent also patch 5, as useful
\r
89 refactoring and cleanup. Also, if we ever end up having any top level
\r
90 arguments that need to be passed to subcommands, I think patches 1-5 are
\r
91 good prep work. The config struct could be extended to include both
\r
92 settings from the config file and settings from the top level
\r
93 arguments. But this is just a bonus in addition to the refactoring part.
\r
95 > In general, I am a strong advocate of keeping the CLI slim. IMHO,
\r
96 > adding more options makes the interface clunkier, and the manual harder
\r
97 > to parse, and I'm against adding things that a normal user would likely
\r
98 > never use. In retrospect, I should have had the same objection to the
\r
99 > --format-version option, which I think could have just been an env var
\r
102 What is a "normal user"? I'm a user too.
\r
projects / notmuch-archives.git / blob