1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 73B46431FBC;
\r
6 Fri, 27 Nov 2009 06:03:00 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
8 Received: from olra.theworths.org ([127.0.0.1])
\r
9 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
10 with ESMTP id Y89AuXT6jyOw; Fri, 27 Nov 2009 06:02:59 -0800 (PST)
\r
11 Received: from cworth.org (localhost [127.0.0.1])
\r
12 by olra.theworths.org (Postfix) with ESMTP id 87E44431FAE;
\r
13 Fri, 27 Nov 2009 06:02:59 -0800 (PST)
\r
14 From: Carl Worth <cworth@cworth.org>
\r
15 To: Jed Brown <jed@59A2.org>
\r
16 In-Reply-To: <1259271410-15336-1-git-send-email-jed@59A2.org>
\r
17 References: <87pr75q9va.fsf@yoom.home.cworth.org>
\r
18 <1259271410-15336-1-git-send-email-jed@59A2.org>
\r
19 Date: Fri, 27 Nov 2009 06:02:45 -0800
\r
20 Message-ID: <87fx80m5fe.fsf@yoom.home.cworth.org>
\r
22 Content-Type: text/plain; charset=us-ascii
\r
23 Cc: notmuch@notmuchmail.org
\r
24 Subject: Re: [notmuch] [PATCH 1/2] New function notmuch-search-operate-all:
\r
25 operate on all messages in the current query.
\r
26 X-BeenThere: notmuch@notmuchmail.org
\r
27 X-Mailman-Version: 2.1.12
\r
29 List-Id: "Use and development of the notmuch mail system."
\r
30 <notmuch.notmuchmail.org>
\r
31 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
32 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
33 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
34 List-Post: <mailto:notmuch@notmuchmail.org>
\r
35 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
36 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
37 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
38 X-List-Received-Date: Fri, 27 Nov 2009 14:03:00 -0000
\r
40 On Thu, 26 Nov 2009 22:36:49 +0100, Jed Brown <jed@59A2.org> wrote:
\r
41 > It is often convenient to change tags on several messages at once. This
\r
42 > function applies any number of tag whitespace-delimited tag
\r
43 > modifications to all messages matching the current query.
\r
47 I've applied both this and the following patch, (giving the consistent
\r
48 treatment to '+, '-', and 'a'). One or two minor comments:
\r
50 > + +tagname Add the tag `tagname'
\r
51 > + -tagname Remove the tag `tagname'
\r
53 > +Each character of the tag name may consist of alphanumeric
\r
54 > +characters as well as `_.+-'.
\r
56 Since this operates via a single call to "notmuch tag" you might mention
\r
57 here that all tag removals occur before any tag additions.
\r
59 > + (unless (string-match-p "^[\+\-][_\+\-\\w]+$" (car words))
\r
60 > + (error "Action must be of the form `+thistag -that_tag'"))
\r
62 The error message has inconsistent "thistag" and "that_tag".
\r
64 But niether nit was worth blocking the commit on.
\r