1 Return-Path: <amdragon@mit.edu>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 074C5431FAE
\r
6 for <notmuch@notmuchmail.org>; Mon, 12 Aug 2013 11:41:04 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id k1cv8ope-+04 for <notmuch@notmuchmail.org>;
\r
16 Mon, 12 Aug 2013 11:40:59 -0700 (PDT)
\r
17 Received: from dmz-mailsec-scanner-7.mit.edu (dmz-mailsec-scanner-7.mit.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id 7D36A431FBD
\r
20 for <notmuch@notmuchmail.org>; Mon, 12 Aug 2013 11:40:53 -0700 (PDT)
\r
21 X-AuditID: 12074424-b7f228e00000096b-3b-52092c351ae2
\r
22 Received: from mailhub-auth-2.mit.edu ( [18.7.62.36])
\r
23 by dmz-mailsec-scanner-7.mit.edu (Symantec Messaging Gateway) with SMTP
\r
24 id DD.56.02411.53C29025; Mon, 12 Aug 2013 14:40:53 -0400 (EDT)
\r
25 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11])
\r
26 by mailhub-auth-2.mit.edu (8.13.8/8.9.2) with ESMTP id r7CIeotm011668;
\r
27 Mon, 12 Aug 2013 14:40:51 -0400
\r
28 Received: from drake.dyndns.org (26-4-172.dynamic.csail.mit.edu [18.26.4.172])
\r
29 (authenticated bits=0)
\r
30 (User authenticated as amdragon@ATHENA.MIT.EDU)
\r
31 by outgoing.mit.edu (8.13.8/8.12.4) with ESMTP id r7CIemX8003746
\r
32 (version=TLSv1/SSLv3 cipher=AES256-SHA bits=256 verify=NOT);
\r
33 Mon, 12 Aug 2013 14:40:50 -0400
\r
34 Received: from amthrax by drake.dyndns.org with local (Exim 4.77)
\r
35 (envelope-from <amdragon@mit.edu>)
\r
36 id 1V8x2u-0005ya-Ll; Mon, 12 Aug 2013 14:40:48 -0400
\r
37 From: Austin Clements <amdragon@MIT.EDU>
\r
38 To: notmuch@notmuchmail.org
\r
39 Subject: [PATCH 3/6] reply: Document the reason for g_mime_filter_headers
\r
40 Date: Mon, 12 Aug 2013 14:40:36 -0400
\r
41 Message-Id: <1376332839-22825-4-git-send-email-amdragon@mit.edu>
\r
42 X-Mailer: git-send-email 1.7.10.4
\r
43 In-Reply-To: <1376332839-22825-1-git-send-email-amdragon@mit.edu>
\r
44 References: <1376332839-22825-1-git-send-email-amdragon@mit.edu>
\r
45 X-Brightmail-Tracker:
\r
46 H4sIAAAAAAAAA+NgFtrIIsWRmVeSWpSXmKPExsUixG6nomuqwxlk8O4Qh8X1mzOZHRg9nq26
\r
47 xRzAGMVlk5Kak1mWWqRvl8CVsXyZVsEu9orfdx4xNjAuYOti5OSQEDCRaJi9nxXCFpO4cG89
\r
48 UJyLQ0hgH6PEieW/WCGcjYwSz0/Pg8ocYZL4sm4HC4Qzl1HibuNUdpB+NgENiW37lzOC2CIC
\r
49 0hI7784GaufgYBZQk/jTpQJiCgt4SkztUAKpYBFQldi9/zcLiM0r4CDxeCZEp4SAokT3swlg
\r
50 13EKOErcX34OrEYIqGbjrh7GCYz8CxgZVjHKpuRW6eYmZuYUpybrFicn5uWlFuma6+Vmluil
\r
51 ppRuYgSHjIvKDsbmQ0qHGAU4GJV4eDM/cgQJsSaWFVfmHmKU5GBSEuWdpMkZJMSXlJ9SmZFY
\r
52 nBFfVJqTWnyIUYKDWUmEdwsrUI43JbGyKrUoHyYlzcGiJM777OnZQCGB9MSS1OzU1ILUIpis
\r
53 DAeHkgRvqDZQo2BRanpqRVpmTglCmomDE2Q4D9DwZpAa3uKCxNzizHSI/ClGRSlx3hSQhABI
\r
54 IqM0D64XFtOvGMWBXhHm7QSp4gGmA7juV0CDmYAGGzVzgAwuSURISTUwVtklLdio/qKuNuC2
\r
55 4p7CqB+POjS89zDtaYnirwo+NfOazUNZr6qKHX9klCK2TPwuyMXKPMPv44YEtcnqf2d1m22u
\r
56 lGp/eXeh2ORYVd0LddkT7s0+9XHe5gSp1xmSWa4FCvZdt36tMYzSe/S+wGValMe555rlUd2F
\r
57 RnM3BEltqWf6X3JKwX+OEktxRqKhFnNRcSIAQmwdtMQCAAA=
\r
58 X-BeenThere: notmuch@notmuchmail.org
\r
59 X-Mailman-Version: 2.1.13
\r
61 List-Id: "Use and development of the notmuch mail system."
\r
62 <notmuch.notmuchmail.org>
\r
63 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
64 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
65 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
66 List-Post: <mailto:notmuch@notmuchmail.org>
\r
67 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
68 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
69 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
70 X-List-Received-Date: Mon, 12 Aug 2013 18:41:04 -0000
\r
72 Given how long it took me to figure out why we pass the reply headers
\r
73 through g_mime_filter_headers, it's worth a comment.
\r
75 notmuch-reply.c | 4 ++++
\r
76 1 file changed, 4 insertions(+)
\r
78 diff --git a/notmuch-reply.c b/notmuch-reply.c
\r
79 index e151f78..3b2b58d 100644
\r
80 --- a/notmuch-reply.c
\r
81 +++ b/notmuch-reply.c
\r
82 @@ -34,6 +34,10 @@ show_reply_headers (GMimeMessage *message)
\r
83 g_mime_stream_file_set_owner (GMIME_STREAM_FILE (stream_stdout), FALSE);
\r
84 stream_filter = g_mime_stream_filter_new(stream_stdout);
\r
85 if (stream_filter) {
\r
86 + // g_mime_object_write_to_stream will produce
\r
87 + // RFC2047-encoded headers, but we want to present the
\r
88 + // user with decoded headers and let whatever
\r
89 + // ultimately sends the mail do the RFC2047 encoding.
\r
90 g_mime_stream_filter_add(GMIME_STREAM_FILTER(stream_filter),
\r
91 g_mime_filter_headers_new());
\r
92 g_mime_object_write_to_stream(GMIME_OBJECT(message), stream_filter);
\r