1 Return-Path: <tomi.ollila@iki.fi>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 10FE6431FBD
\r
6 for <notmuch@notmuchmail.org>; Wed, 12 Feb 2014 23:26:53 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=0 tagged_above=-999 required=5 tests=[none]
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id fe4ybxcIE80P for <notmuch@notmuchmail.org>;
\r
16 Wed, 12 Feb 2014 23:26:49 -0800 (PST)
\r
17 Received: from guru.guru-group.fi (guru.guru-group.fi [46.183.73.34])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 6F377431FAE
\r
19 for <notmuch@notmuchmail.org>; Wed, 12 Feb 2014 23:26:49 -0800 (PST)
\r
20 Received: from guru.guru-group.fi (localhost [IPv6:::1])
\r
21 by guru.guru-group.fi (Postfix) with ESMTP id 5769A1000FA;
\r
22 Thu, 13 Feb 2014 09:26:43 +0200 (EET)
\r
23 From: Tomi Ollila <tomi.ollila@iki.fi>
\r
24 To: Austin Clements <amdragon@MIT.EDU>
\r
25 Subject: Re: [PATCH 1/1] emacs: always write emacs/.eldeps when the target is
\r
27 In-Reply-To: <20140213071026.GX4375@mit.edu>
\r
28 References: <1390645309-2326-1-git-send-email-tomi.ollila@iki.fi>
\r
29 <20140213071026.GX4375@mit.edu>
\r
30 User-Agent: Notmuch/0.17+69~g761b031 (http://notmuchmail.org) Emacs/24.3.1
\r
31 (x86_64-unknown-linux-gnu)
\r
32 X-Face: HhBM'cA~<r"^Xv\KRN0P{vn'Y"Kd;zg_y3S[4)KSN~s?O\"QPoL
\r
33 $[Xv_BD:i/F$WiEWax}R(MPS`^UaptOGD`*/=@\1lKoVa9tnrg0TW?"r7aRtgk[F
\r
34 !)g;OY^,BjTbr)Np:%c_o'jj,Z
\r
35 Date: Thu, 13 Feb 2014 09:26:43 +0200
\r
36 Message-ID: <m2sirn1nik.fsf@guru.guru-group.fi>
\r
38 Content-Type: text/plain
\r
39 Cc: notmuch@notmuchmail.org
\r
40 X-BeenThere: notmuch@notmuchmail.org
\r
41 X-Mailman-Version: 2.1.13
\r
43 List-Id: "Use and development of the notmuch mail system."
\r
44 <notmuch.notmuchmail.org>
\r
45 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
47 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
48 List-Post: <mailto:notmuch@notmuchmail.org>
\r
49 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
50 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
51 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
52 X-List-Received-Date: Thu, 13 Feb 2014 07:26:53 -0000
\r
54 On Thu, Feb 13 2014, Austin Clements <amdragon@MIT.EDU> wrote:
\r
56 > Quoth Tomi Ollila on Jan 25 at 12:21 pm:
\r
57 >> So that the target is newer than its prerequisites.
\r
59 >> emacs/Makefile.local | 3 +--
\r
60 >> 1 file changed, 1 insertion(+), 2 deletions(-)
\r
62 >> diff --git a/emacs/Makefile.local b/emacs/Makefile.local
\r
63 >> index 42bfbd9..d5d402e 100644
\r
64 >> --- a/emacs/Makefile.local
\r
65 >> +++ b/emacs/Makefile.local
\r
66 >> @@ -32,8 +32,7 @@ emacs_bytecode = $(emacs_sources:.el=.elc)
\r
67 >> ifeq ($(HAVE_EMACS),1)
\r
68 >> $(dir)/.eldeps: $(dir)/Makefile.local $(dir)/make-deps.el $(emacs_sources)
\r
69 >> $(call quiet,EMACS) --directory emacs -batch -l make-deps.el \
\r
70 >> - -f batch-make-deps $(emacs_sources) > $@.tmp && \
\r
71 >> - (cmp -s $@.tmp $@ || mv $@.tmp $@)
\r
72 >> + -f batch-make-deps $(emacs_sources) > $@.tmp && mv $@.tmp $@
\r
73 >> -include $(dir)/.eldeps
\r
75 >> CLEAN+=$(dir)/.eldeps $(dir)/.eldeps.tmp
\r
77 > Is this just so the rule doesn't get run again on the next make
\r
78 > invocation (unless, of course, a dependent changed)?
\r
80 Basically yes. I did multiple builds in rapid succession when developing
\r
81 something and this thing confused me quite a lot in the beginning...
\r
83 > Interestingly, if any of the dependents have changed, but in ways that
\r
84 > don't affect .eldeps, this change will make the build more expensive
\r
85 > because it will trigger a make restart after .eldeps is updated.
\r
87 I wondered what was the reason for the recipe you've chosen here, has
\r
88 it something to do with inodes or something ;) (and were going to ask
\r
89 an alternative to touch (or even : > $@) the target...
\r
91 ... but now I understand. E.g. change in notmuch-lib.el will cause *all*
\r
92 .el files to be re-bytecompiled after this change.
\r
94 An alternative to this patch would be adding a message to the rule
\r
95 which informs user to touch .eldeps to avoid re-doing .eldeps if
\r
96 that irritates one :D
\r
100 (cmp -s $@.tmp $@ && \
\r
101 echo "touch $@ to avoid redoing this target" || mv $@.tmp $@)
\r