1 Return-Path: <amdragon@gmail.com>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 786E7431FD0
\r
6 for <notmuch@notmuchmail.org>; Fri, 9 Sep 2011 09:13:10 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.698 tagged_above=-999 required=5
\r
12 tests=[DKIM_SIGNED=0.1, DKIM_VALID=-0.1, FREEMAIL_FROM=0.001,
\r
13 HTML_MESSAGE=0.001, RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id proMFs+P+k-T for <notmuch@notmuchmail.org>;
\r
17 Fri, 9 Sep 2011 09:13:10 -0700 (PDT)
\r
18 Received: from mail-qy0-f181.google.com (mail-qy0-f181.google.com
\r
19 [209.85.216.181]) (using TLSv1 with cipher RC4-SHA (128/128 bits))
\r
20 (No client certificate requested)
\r
21 by olra.theworths.org (Postfix) with ESMTPS id D1A6B431FB6
\r
22 for <notmuch@notmuchmail.org>; Fri, 9 Sep 2011 09:13:09 -0700 (PDT)
\r
23 Received: by qyk7 with SMTP id 7so269080qyk.5
\r
24 for <notmuch@notmuchmail.org>; Fri, 09 Sep 2011 09:13:07 -0700 (PDT)
\r
25 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma;
\r
26 h=mime-version:sender:in-reply-to:references:date
\r
27 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
\r
28 bh=eHj+kS7hK8Tm2eBZBOwSJ/X9b2X4o6iEZpuhqA4mrgs=;
\r
29 b=Od8BcF+n98/U0S71Ubv3xrr94b/nsp2j52o42cFDCqhBAozF3yqkJTa05NqUHt1QJD
\r
30 lRZbfm5OxEShJEX/TUbC8SKTV1eWnVJ5IkEaJvo63LF/lX+yvc2k6g2S6Xz0XGZ30NT5
\r
31 +Bo+c8YKa9t3QrHzufHgdeqTbBPMTsATywwrs=
\r
33 Received: by 10.229.43.143 with SMTP id w15mr409448qce.140.1315584787098; Fri,
\r
34 09 Sep 2011 09:13:07 -0700 (PDT)
\r
35 Sender: amdragon@gmail.com
\r
36 Received: by 10.229.2.201 with HTTP; Fri, 9 Sep 2011 09:13:06 -0700 (PDT)
\r
37 Received: by 10.229.2.201 with HTTP; Fri, 9 Sep 2011 09:13:06 -0700 (PDT)
\r
38 In-Reply-To: <87fwk63v86.fsf@kepler.schwinge.homeip.net>
\r
39 References: <1315249637-20179-1-git-send-email-thomas@schwinge.name>
\r
40 <87liu2kcq6.fsf@servo.factory.finestructure.net>
\r
41 <20110909090633.GA3178@localdomain>
\r
42 <87fwk63v86.fsf@kepler.schwinge.homeip.net>
\r
43 Date: Fri, 9 Sep 2011 12:13:06 -0400
\r
44 X-Google-Sender-Auth: 7NkvJYnrZjluXlvOjCxParK5miU
\r
46 <CAH-f9WutmDs2=UELduO66YPPFhy1g8D4_xNhnEjOiWaJMv7m5Q@mail.gmail.com>
\r
47 Subject: Re: [PATCH] notmuch restore --accumulate
\r
48 From: Austin Clements <amdragon@mit.edu>
\r
49 To: Thomas Schwinge <thomas@schwinge.name>
\r
50 Content-Type: multipart/alternative; boundary=00148539240ae82be004ac847386
\r
51 Cc: notmuch@notmuchmail.org
\r
52 X-BeenThere: notmuch@notmuchmail.org
\r
53 X-Mailman-Version: 2.1.13
\r
55 List-Id: "Use and development of the notmuch mail system."
\r
56 <notmuch.notmuchmail.org>
\r
57 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
58 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
59 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
60 List-Post: <mailto:notmuch@notmuchmail.org>
\r
61 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
62 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
63 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
64 X-List-Received-Date: Fri, 09 Sep 2011 16:13:10 -0000
\r
66 --00148539240ae82be004ac847386
\r
67 Content-Type: text/plain; charset=ISO-8859-1
\r
68 Content-Transfer-Encoding: quoted-printable
\r
70 The idea behind sending the test first is that people can see that it fails
\r
71 and that the subsequent patch indeed fixes it. What I find works well is t=
\r
73 submit the test case with the test marked as broken and then the main patch=
\r
75 including the change to un-mark it as broken.
\r
76 On Sep 9, 2011 5:45 AM, "Thomas Schwinge" <thomas@schwinge.name> wrote:
\r
79 > On Fri, 9 Sep 2011 11:06:34 +0200, Louis Rilling <l.rilling@av7.net>
\r
81 >> On 05/09/11 12:31 -0700, Jameson Graef Rollins wrote:
\r
82 >> > Also, we generally prefer to have modifications to the test suite in
\r
83 >> > separate patches that precede the patches that add the features/fix th=
\r
88 >> For new features, this does not look like 'git bisect'-safe.
\r
90 > Exactly my thoughts. I can perhaps see the usefulness (for first
\r
91 > separately committing the testcase) for bugfixes, but why for new
\r
95 >> the testsuite patch should follow the new feature patch, don't you?
\r
97 > I would keep them together; why separate them?
\r
103 --00148539240ae82be004ac847386
\r
104 Content-Type: text/html; charset=ISO-8859-1
\r
105 Content-Transfer-Encoding: quoted-printable
\r
107 <p>The idea behind sending the test first is that people can see that it fa=
\r
108 ils and that the subsequent patch indeed fixes it.=A0 What I find works wel=
\r
109 l is to submit the test case with the test marked as broken and then the ma=
\r
110 in patch, including the change to un-mark it as broken.</p>
\r
112 <div class=3D"gmail_quote">On Sep 9, 2011 5:45 AM, "Thomas Schwinge&qu=
\r
113 ot; <<a href=3D"mailto:thomas@schwinge.name">thomas@schwinge.name</a>>=
\r
114 ; wrote:<br type=3D"attribution">> Hi!<br>> <br>> On Fri, 9 Sep 20=
\r
115 11 11:06:34 +0200, Louis Rilling <<a href=3D"mailto:l.rilling@av7.net">l=
\r
116 .rilling@av7.net</a>> wrote:<br>
\r
117 >> On 05/09/11 12:31 -0700, Jameson Graef Rollins wrote:<br>>> =
\r
118 > Also, we generally prefer to have modifications to the test suite in<b=
\r
119 r>>> > separate patches that precede the patches that add the feat=
\r
121 >> > bugs.<br>>> > <br>>> <br>>> For new feat=
\r
122 ures, this does not look like 'git bisect'-safe.<br>> <br>> E=
\r
123 xactly my thoughts. I can perhaps see the usefulness (for first<br>> se=
\r
124 parately committing the testcase) for bugfixes, but why for new<br>
\r
125 > features?<br>> <br>>> I would say that<br>>> the testsu=
\r
126 ite patch should follow the new feature patch, don't you?<br>> <br>&=
\r
127 gt; I would keep them together; why separate them?<br>> <br>> <br>
\r
128 > Gr=FC=DFe,<br>> Thomas<br></div>
\r
130 --00148539240ae82be004ac847386--
\r