1 Return-Path: <jrollins@finestructure.net>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 04016431FD0
\r
6 for <notmuch@notmuchmail.org>; Fri, 9 Sep 2011 11:58:24 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.29 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_MED=-2.3, T_MIME_NO_TEXT=0.01] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id VnR7w9D1yAxD for <notmuch@notmuchmail.org>;
\r
16 Fri, 9 Sep 2011 11:58:23 -0700 (PDT)
\r
17 Received: from outgoing-mail.its.caltech.edu (outgoing-mail.its.caltech.edu
\r
19 by olra.theworths.org (Postfix) with ESMTP id 27696431FB6
\r
20 for <notmuch@notmuchmail.org>; Fri, 9 Sep 2011 11:58:23 -0700 (PDT)
\r
21 Received: from fire-doxen.imss.caltech.edu (localhost [127.0.0.1])
\r
22 by fire-doxen-postvirus (Postfix) with ESMTP id 6A4613281CC;
\r
23 Fri, 9 Sep 2011 11:58:22 -0700 (PDT)
\r
24 X-Spam-Scanned: at Caltech-IMSS on fire-doxen by amavisd-new
\r
25 Received: from finestructure.net (gwave-120.ligo.caltech.edu
\r
26 [131.215.114.120]) (Authenticated sender: jrollins) by fire-doxen-submit
\r
27 (Postfix) with ESMTP id 71183328143; Fri, 9 Sep 2011 11:58:17 -0700 (PDT)
\r
28 Received: by finestructure.net (Postfix, from userid 1000)
\r
29 id B97A11A0; Fri, 9 Sep 2011 11:58:16 -0700 (PDT)
\r
30 From: Jameson Graef Rollins <jrollins@finestructure.net>
\r
31 To: Thomas Schwinge <thomas@schwinge.name>, Austin Clements <amdragon@mit.edu>
\r
32 Subject: Re: [PATCH] notmuch restore --accumulate
\r
33 In-Reply-To: <87fwk53a1i.fsf@kepler.schwinge.homeip.net>
\r
34 References: <1315249637-20179-1-git-send-email-thomas@schwinge.name>
\r
35 <87liu2kcq6.fsf@servo.factory.finestructure.net>
\r
36 <20110909090633.GA3178@localdomain>
\r
37 <87fwk63v86.fsf@kepler.schwinge.homeip.net>
\r
38 <CAH-f9WutmDs2=UELduO66YPPFhy1g8D4_xNhnEjOiWaJMv7m5Q@mail.gmail.com>
\r
39 <87fwk53a1i.fsf@kepler.schwinge.homeip.net>
\r
40 User-Agent: Notmuch/0.7-41-g7dce23e (http://notmuchmail.org) Emacs/23.3.1
\r
41 (x86_64-pc-linux-gnu)
\r
42 Date: Fri, 09 Sep 2011 11:58:14 -0700
\r
43 Message-ID: <87boutee61.fsf@servo.factory.finestructure.net>
\r
45 Content-Type: multipart/signed; boundary="=-=-=";
\r
46 micalg=pgp-sha256; protocol="application/pgp-signature"
\r
47 Cc: notmuch@notmuchmail.org
\r
48 X-BeenThere: notmuch@notmuchmail.org
\r
49 X-Mailman-Version: 2.1.13
\r
51 List-Id: "Use and development of the notmuch mail system."
\r
52 <notmuch.notmuchmail.org>
\r
53 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
55 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
56 List-Post: <mailto:notmuch@notmuchmail.org>
\r
57 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
58 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
60 X-List-Received-Date: Fri, 09 Sep 2011 18:58:24 -0000
\r
64 On Fri, 09 Sep 2011 19:22:49 +0200, Thomas Schwinge <thomas@schwinge.name> wrote:
\r
65 > Ah, that's indeed a good approach for bug fixes (and it also preserves
\r
66 > git bisect compatibility), but still: why separate patches for new
\r
67 > functionality? (I'm not trying to be a pain here, but would like to
\r
68 > understand your rationale behind this.)
\r
70 I tend to think of the test as an actual spec of the behavior I'm trying
\r
71 to implement. By defining before hand exactly what I expect to happen I
\r
72 can confirm that my patch achieves what I want it to.
\r
74 As an example, you might look at my patch that adds better rfc822 part
\r
75 handling [0]. I tried to fully flesh out what I wanted to happen in the
\r
76 test first, and then modified the code to achieve that result.
\r
80 [0] id:"1307320169-29905-4-git-send-email-jrollins@finestructure.net"
\r
83 Content-Type: application/pgp-signature
\r
85 -----BEGIN PGP SIGNATURE-----
\r
86 Version: GnuPG v1.4.11 (GNU/Linux)
\r
88 iQIcBAEBCAAGBQJOamHGAAoJEO00zqvie6q8T40P+wbMuGVZx1lcxvrp7u1bTnNf
\r
89 XKSBVYOe9PJgU5z/cBjLAsy9vcnYKXgT8wTrZ4RRqYsOsKrvo1ECBdtzKppp5nDr
\r
90 mEgsV6V8ZvWVn8rPyOFUBLBXyyVmfnndr4g+xUT8OwouEIya0ntaixOI/RHkIO+2
\r
91 +9yAcvKMBGEZozupIqXKlvoYIWuyEhJlSKoS4Zzc4k1k+ihk3lFiDALWX2UVVtc7
\r
92 FXdTuqLAq/J53+BqCUbhPgsGoPSrZjcuzQDZ/1ZcKdQjfDcbMH+4iIBRlqQ4KOkL
\r
93 m6WsS2H4cZrCMu0DSQEPfvTMKsbYnTQmNj+r8D46sZTjYtOYcora/U5wErr/PQzl
\r
94 D4UExNkJcu1Oy/VJjVq9sG4j9LGkznPRl0bu+11CUzicot5+Z1lXZbNT48UyON7E
\r
95 1SSod/80HNS1qzrO49FpPnNug8nIROwQNjBAoLDzZNd8MeD8+w32t1vchXLwyM33
\r
96 fEOnvEw7FBKyJp9QgGaiiBx4u18y74VT4GBG1tPVWEPJJpJDb0cK24cwD1vXg8nC
\r
97 w4yJhxUZZTWkxYZwO4B8pxebMGpSZeMHc/eflaWPnpU38dYsDsJdNBJLIypYyUgR
\r
98 pucV8uTedBw+7+SkXfS5DwuqBjZZQbeRaTypptubLbCbz7DdQ3kUyMBjlwhBI3ds
\r
99 XDxqRMwkiBkBvR4O0x+m
\r
101 -----END PGP SIGNATURE-----
\r