1 Return-Path: <dme@dme.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 1B30F431FBC
\r
6 for <notmuch@notmuchmail.org>; Fri, 27 Jan 2012 02:29:07 -0800 (PST)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-0.7 tagged_above=-999 required=5
\r
12 tests=[RCVD_IN_DNSWL_LOW=-0.7] autolearn=disabled
\r
13 Received: from olra.theworths.org ([127.0.0.1])
\r
14 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
15 with ESMTP id GHzEG2VsVOPO for <notmuch@notmuchmail.org>;
\r
16 Fri, 27 Jan 2012 02:29:06 -0800 (PST)
\r
17 Received: from mail-ww0-f45.google.com (mail-ww0-f45.google.com
\r
18 [74.125.82.45]) (using TLSv1 with cipher RC4-SHA (128/128 bits)) (No client
\r
19 certificate requested) by olra.theworths.org (Postfix) with ESMTPS id
\r
20 639DF431FB6 for <notmuch@notmuchmail.org>; Fri, 27 Jan 2012 02:29:06 -0800
\r
22 Received: by wgbdt12 with SMTP id dt12so1426306wgb.2
\r
23 for <notmuch@notmuchmail.org>; Fri, 27 Jan 2012 02:29:05 -0800 (PST)
\r
24 Received: by 10.180.78.233 with SMTP id e9mr9164490wix.0.1327660145147;
\r
25 Fri, 27 Jan 2012 02:29:05 -0800 (PST)
\r
26 Received: from hotblack-desiato.hh.sledj.net
\r
27 (host81-149-164-25.in-addr.btopenworld.com. [81.149.164.25])
\r
28 by mx.google.com with ESMTPS id di5sm21854237wib.3.2012.01.27.02.29.02
\r
29 (version=TLSv1/SSLv3 cipher=OTHER);
\r
30 Fri, 27 Jan 2012 02:29:03 -0800 (PST)
\r
31 Received: by hotblack-desiato.hh.sledj.net (Postfix, from userid 30000)
\r
32 id 72F74A0363; Fri, 27 Jan 2012 10:29:01 +0000 (GMT)
\r
33 To: Mark Walters <m.walters@qmul.ac.uk>, notmuch@notmuchmail.org
\r
34 Subject: Re: [PATCH 3/3] emacs: Prefer '[No Subject]' to blank subjects.
\r
35 In-Reply-To: <874nvh5tro.fsf@qmul.ac.uk>
\r
36 References: <1327496913-4946-1-git-send-email-dme@dme.org>
\r
37 <1327499314-7887-1-git-send-email-dme@dme.org>
\r
38 <1327499314-7887-4-git-send-email-dme@dme.org>
\r
39 <874nvh5tro.fsf@qmul.ac.uk>
\r
40 User-Agent: Notmuch/0.11+122~g97bdcf6 (http://notmuchmail.org) Emacs/24.0.92.1
\r
41 (x86_64-pc-linux-gnu)
\r
42 From: David Edmondson <dme@dme.org>
\r
43 Date: Fri, 27 Jan 2012 10:28:56 +0000
\r
44 Message-ID: <cunk44djv6f.fsf@hotblack-desiato.hh.sledj.net>
\r
46 Content-Type: multipart/signed; boundary="=-=-=";
\r
47 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
48 X-BeenThere: notmuch@notmuchmail.org
\r
49 X-Mailman-Version: 2.1.13
\r
51 List-Id: "Use and development of the notmuch mail system."
\r
52 <notmuch.notmuchmail.org>
\r
53 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
54 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
55 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
56 List-Post: <mailto:notmuch@notmuchmail.org>
\r
57 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
58 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
59 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
60 X-List-Received-Date: Fri, 27 Jan 2012 10:29:07 -0000
\r
63 Content-Type: text/plain
\r
64 Content-Transfer-Encoding: quoted-printable
\r
66 On Fri, 27 Jan 2012 10:23:07 +0000, Mark Walters <m.walters@qmul.ac.uk> wro=
\r
68 > I am very much not a lisp expert
\r
70 Me neither, so please do continue to review stuff.
\r
72 > The patch 1/3 seems to set the show buffer line to *[No Subject]* where
\r
73 > it used to be just [No Subject]. (I have no preference: I just wasn't
\r
74 > sure if that was intentional.
\r
76 There was inconsistency before, now the buffer name always has the
\r
80 > > diff --git a/emacs/notmuch-show.el b/emacs/notmuch-show.el
\r
81 > > index e6a5b31..c602b3e 100644
\r
82 > > --- a/emacs/notmuch-show.el
\r
83 > > +++ b/emacs/notmuch-show.el
\r
84 > > @@ -985,7 +985,7 @@ buffer."
\r
85 > > (notmuch-show-next-open-message))
\r
87 > > ;; Set the header line to the subject of the first open message.
\r
88 > > - (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-=
\r
90 > > + (setq header-line-format (notmuch-show-strip-re (notmuch-show-get-=
\r
93 > > (notmuch-show-mark-read)))
\r
95 > > @@ -1216,6 +1216,9 @@ Some useful entries are:
\r
96 > > (defun notmuch-show-get-depth ()
\r
97 > > (notmuch-show-get-prop :depth))
\r
99 > > +(defun notmuch-show-get-pretty-subject ()
\r
100 > > + (notmuch-prettify-subject (notmuch-show-get-subject)))
\r
102 > > (defun notmuch-show-set-tags (tags)
\r
103 > > "Set the tags of the current message."
\r
104 > > (notmuch-show-set-prop :tags tags)
\r
106 > As far as I can see notmuch-show-get-pretty-subject is only called once
\r
107 > so I wondered why you bothered with a new function. But as I say I have
\r
108 > almost zero lisp experience so no feel for lisp style.
\r
110 Just mirroring the existing structure really.
\r
111 `notmuch-show-get-<something>' to access details of the message. I've no
\r
115 Content-Type: application/pgp-signature
\r
117 -----BEGIN PGP SIGNATURE-----
\r
118 Version: GnuPG v1.4.11 (GNU/Linux)
\r
120 iEYEARECAAYFAk8ifGgACgkQaezQq/BJZRYw6QCePHN9bKWfow9xhUJf2uV28e3P
\r
121 QSYAn3h7fgZsneL1bMrZaClnd7maxmUR
\r
123 -----END PGP SIGNATURE-----
\r