1 Return-Path: <cworth@cworth.org>
\r
2 X-Original-To: notmuch@notmuchmail.org
\r
3 Delivered-To: notmuch@notmuchmail.org
\r
4 Received: from localhost (localhost [127.0.0.1])
\r
5 by olra.theworths.org (Postfix) with ESMTP id 8D40240D16A
\r
6 for <notmuch@notmuchmail.org>; Sat, 30 Oct 2010 13:38:35 -0700 (PDT)
\r
7 X-Virus-Scanned: Debian amavisd-new at olra.theworths.org
\r
11 X-Spam-Status: No, score=-2.89 tagged_above=-999 required=5
\r
12 tests=[ALL_TRUSTED=-1, BAYES_00=-1.9, T_MIME_NO_TEXT=0.01]
\r
14 Received: from olra.theworths.org ([127.0.0.1])
\r
15 by localhost (olra.theworths.org [127.0.0.1]) (amavisd-new, port 10024)
\r
16 with ESMTP id RRLhWfh3N25V; Sat, 30 Oct 2010 13:38:24 -0700 (PDT)
\r
17 Received: from yoom.home.cworth.org (localhost [127.0.0.1])
\r
18 by olra.theworths.org (Postfix) with ESMTP id 17DE840D166;
\r
19 Sat, 30 Oct 2010 13:38:24 -0700 (PDT)
\r
20 Received: by yoom.home.cworth.org (Postfix, from userid 1000)
\r
21 id B3CA8254007; Sat, 30 Oct 2010 13:38:23 -0700 (PDT)
\r
22 From: Carl Worth <cworth@cworth.org>
\r
23 To: Felipe Contreras <felipe.contreras@gmail.com>, notmuch@notmuchmail.org
\r
24 Subject: Re: [PATCH 2/2] build: only link to what we really use
\r
25 In-Reply-To: <1288394207-10223-3-git-send-email-felipe.contreras@gmail.com>
\r
26 References: <1288394207-10223-1-git-send-email-felipe.contreras@gmail.com>
\r
27 <1288394207-10223-3-git-send-email-felipe.contreras@gmail.com>
\r
28 User-Agent: Notmuch/0.3.1 (http://notmuchmail.org) Emacs/23.2.1
\r
30 Date: Sat, 30 Oct 2010 13:38:23 -0700
\r
31 Message-ID: <87fwvnpgao.fsf@yoom.home.cworth.org>
\r
33 Content-Type: multipart/signed; boundary="=-=-=";
\r
34 micalg=pgp-sha1; protocol="application/pgp-signature"
\r
35 X-BeenThere: notmuch@notmuchmail.org
\r
36 X-Mailman-Version: 2.1.13
\r
38 List-Id: "Use and development of the notmuch mail system."
\r
39 <notmuch.notmuchmail.org>
\r
40 List-Unsubscribe: <http://notmuchmail.org/mailman/options/notmuch>,
\r
41 <mailto:notmuch-request@notmuchmail.org?subject=unsubscribe>
\r
42 List-Archive: <http://notmuchmail.org/pipermail/notmuch>
\r
43 List-Post: <mailto:notmuch@notmuchmail.org>
\r
44 List-Help: <mailto:notmuch-request@notmuchmail.org?subject=help>
\r
45 List-Subscribe: <http://notmuchmail.org/mailman/listinfo/notmuch>,
\r
46 <mailto:notmuch-request@notmuchmail.org?subject=subscribe>
\r
47 X-List-Received-Date: Sat, 30 Oct 2010 20:38:35 -0000
\r
50 Content-Transfer-Encoding: quoted-printable
\r
52 On Sat, 30 Oct 2010 02:16:47 +0300, Felipe Contreras <felipe.contreras@gmai=
\r
54 > At least linux has the -Wl,--as-needed option.
\r
56 > Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
\r
62 I also followed it up with a change to do a configure-time check for the
\r
63 =2DWl,--as-needed option, (since I don't like having platform-specific
\r
64 conditionals in the Makefile). And this conditional:
\r
66 > -ifneq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1)
\r
67 > +ifeq ($(LINKER_RESOLVES_LIBRARY_DEPENDENCIES),1)
\r
68 > +FINAL_NOTMUCH_LDFLAGS +=3D -Wl,--as-needed
\r
71 wasn't only platform-specific, but actually using one conditional, ("linker
\r
72 resolved library dependencies"), for another, ("platform is
\r
73 linux"). That's a kind of fragility that I also don't like.
\r
75 But thanks very much for adding the --as-needed option.
\r
77 And please let me know if everything is building well for you now. (For the
\r
78 first patch you sent in this set, I had already pushed my own version.)
\r
83 carl.d.worth@intel.com
\r
86 Content-Type: application/pgp-signature
\r
88 -----BEGIN PGP SIGNATURE-----
\r
89 Version: GnuPG v1.4.10 (GNU/Linux)
\r
91 iD8DBQFMzII/6JDdNq8qSWgRArxMAJ9KeMZTPztK86jwjsv+OZBIrDiRhwCfVRnm
\r
92 V4sgg1ijWq5q28I2I2J11Aw=
\r
94 -----END PGP SIGNATURE-----
\r